Tiger Viewer Method Count Mode Wrong for Milestones |
||
Issue descriptionNot sure if the mode is wrong for all diffs, but pretty sure we didn't add 33k methods M68->M69: https://storage.googleapis.com/chrome-supersize/index.html?data_url=milestones%2Farm%2FMonochrome.apk%2Freport_68.0.3440.85_69.0.3497.91.ndjson&method_count=on&diff_mode=on
,
Sep 26
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/eb74ff2fcc974617103437fc5ad7ea2ec6f8448b commit eb74ff2fcc974617103437fc5ad7ea2ec6f8448b Author: Samuel Huang <huangs@chromium.org> Date: Wed Sep 26 19:31:59 2018 [SuperSize] HTML Viewer: Fix Method Count under diff mode. Under diff mode, previously the HTML Viewer would report very large method (delta) counts. This was caused by the Python code assigning a delta count of 1 (instead of 0) for changed symbols. Moreover, to support delta count of 0, the JavaScript code change needs to be updated to read it (i.e., cannot use "||" to assign defaults). This CL fixes the above problems. Moreover, to reduce .ndjson file size, 0 is used as the default symbol count under diff mode (1 is still the defalut if one .size file is used to generate the .ndjson file). Bug: 884985 Change-Id: I8038f8b8298073c8ced5ccf9100cf9911e533861 Reviewed-on: https://chromium-review.googlesource.com/1246280 Reviewed-by: agrieve <agrieve@chromium.org> Reviewed-by: Samuel Huang <huangs@chromium.org> Commit-Queue: Samuel Huang <huangs@chromium.org> Cr-Commit-Position: refs/heads/master@{#594431} [modify] https://crrev.com/eb74ff2fcc974617103437fc5ad7ea2ec6f8448b/tools/binary_size/libsupersize/html_report.py [modify] https://crrev.com/eb74ff2fcc974617103437fc5ad7ea2ec6f8448b/tools/binary_size/libsupersize/models.py [modify] https://crrev.com/eb74ff2fcc974617103437fc5ad7ea2ec6f8448b/tools/binary_size/libsupersize/static/tree-worker.js
,
Sep 26
I ran tools/binary_size/libsupersize/generate_milestone_report.py and updated all the reports but it's still showing 33k methods for me at https://storage.googleapis.com/chrome-supersize/index.html?data_url=milestones%2Farm%2FMonochrome.apk%2Freport_68.0.3440.85_69.0.3497.91.ndjson&method_count=on&diff_mode=on. Then I downloaded the report locally (gsutil cp gs://chrome-supersize/milestones/arm/Monochrome.apk/report_68.0.3440.85_69.0.3497.91.ndjson . ) and it worked
,
Sep 28
Oops, I had forgotten to run tools/binary_size/libsupersize/upload_html_viewer.py. There seems to be a caching problem though since I can't seem to receive the update template when loading in Chrome (requires incognito). |
||
►
Sign in to add a comment |
||
Comment 1 by hua...@chromium.org
, Sep 26