New issue
Advanced search Search tips

Issue 884968 link

Starred by 1 user
Status: Fixed
Owner:
shaktisahu@chromium.org
Closed: Sep 19
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

Enable ChromeOS download notifications for background fetch

Project Member Reported by shaktisahu@chromium.org, Sep 18 
ChromeOS download notifications are currently covered by two classes DownloadNotificationManager and DownloadItemNotification both of which are observers of DownloadItem. We need to convert them to understand OfflineItem.
Project Member

Comment 1 by bugdroid1@chromium.org, Sep 19 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6d9de2f10b8588204101b30085b7e9c62bafba57

commit 6d9de2f10b8588204101b30085b7e9c62bafba57
Author: Shakti Sahu <shaktisahu@chromium.org>
Date: Wed Sep 19 21:52:14 2018

Downloads : Converting chromeos notifications to use DownloadUIModel

ChromeOS download notification code currently is driven by DownloadItem.
This CL decouples them from DownloadItem and makes them observer
DownloadUIModel which will enable OfflineItem as well.

Bug:  884968 
Change-Id: I2e7c9419d174d7ab7361e5738110a690e3529a53
Reviewed-on: https://chromium-review.googlesource.com/1229510
Commit-Queue: Shakti Sahu <shaktisahu@chromium.org>
Reviewed-by: Min Qin <qinmin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#592560}
[modify] https://crrev.com/6d9de2f10b8588204101b30085b7e9c62bafba57/chrome/browser/download/download_item_model.cc
[modify] https://crrev.com/6d9de2f10b8588204101b30085b7e9c62bafba57/chrome/browser/download/download_item_model.h
[modify] https://crrev.com/6d9de2f10b8588204101b30085b7e9c62bafba57/chrome/browser/download/download_ui_model.cc
[modify] https://crrev.com/6d9de2f10b8588204101b30085b7e9c62bafba57/chrome/browser/download/download_ui_model.h
[modify] https://crrev.com/6d9de2f10b8588204101b30085b7e9c62bafba57/chrome/browser/download/notification/download_item_notification.cc
[modify] https://crrev.com/6d9de2f10b8588204101b30085b7e9c62bafba57/chrome/browser/download/notification/download_item_notification.h
[modify] https://crrev.com/6d9de2f10b8588204101b30085b7e9c62bafba57/chrome/browser/download/notification/download_item_notification_unittest.cc
[modify] https://crrev.com/6d9de2f10b8588204101b30085b7e9c62bafba57/chrome/browser/download/notification/download_notification_manager.cc
[modify] https://crrev.com/6d9de2f10b8588204101b30085b7e9c62bafba57/chrome/browser/download/notification/download_notification_manager.h

Comment 2 by shaktisahu@chromium.org, Sep 19

Status: Fixed (was: Started)
►

Sign in to add a comment