New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 884965 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Sep 28
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug


Participants' hotlists:
Better-Together-Launch-Blockers


Sign in to add a comment

MultiDevice setup flow: Password page attempts password as soon as focus changes

Project Member Reported by hansberry@chromium.org, Sep 18

Issue description

Chrome Version: head

If the user enters an incorrect password, and then clicks outside of the password input field, the dialog attempts the password and then displays "incorrect password" (even though the user did not press Confirm). Most strangely from the user's point of view, if the user enters the correct password and taps Cancel, it will actually move forward with the flow and enable Better Together.



 
Labels: -Pri-2 Pri-1
The last sentence here should make this a P1. We can't continue the flow if a user clicks cancel.
Components: -UI>ProximityAuth UI>Multidevice
Owner: jordynass@chromium.org
I fixed the bug in a new CL: https://chromium-review.googlesource.com/c/chromium/src/+/1249574

I just sent it in for review.
Status: Started (was: Available)
That proposed fix was misguided because it removed the handling of the user pressing enter. The updated fix (https://chromium-review.googlesource.com/c/chromium/src/+/1252503) the uses keypress event handling borrowed loosely from ui/webui/resources/cr_elements/cr_dialog/cr_dialog.js because the change event doesn't seem to discriminate between sources of the change submission (i.e. can't discern whether the enter key was pressed).
Project Member

Comment 6 by bugdroid1@chromium.org, Sep 28

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/da4a7dfb643a64d939b05f253c575528a304297e

commit da4a7dfb643a64d939b05f253c575528a304297e
Author: Jordy Greenblatt <jordynass@chromium.org>
Date: Fri Sep 28 21:23:27 2018

[CrOS MultiDevice] Fix Setup Flow bug causing spurious setup attempts

The bug was caused by the change event on the password text field
triggering the event 'user-submitted-password' which causes a forward
navigate attempt. This fails if the password is wrong (this causes the
'incorrect password' issue in the bug) and succeeds if the password is
correct (this causes the spurious flow continuation issue).

Bug:  884965 
Change-Id: I4ae9f9f9fd01901dacd9e69a216bdd3123eb9344
Reviewed-on: https://chromium-review.googlesource.com/1252503
Commit-Queue: Jordy Greenblatt <jordynass@chromium.org>
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595219}
[modify] https://crrev.com/da4a7dfb643a64d939b05f253c575528a304297e/ui/webui/resources/cr_components/chromeos/multidevice_setup/password_page.html
[modify] https://crrev.com/da4a7dfb643a64d939b05f253c575528a304297e/ui/webui/resources/cr_components/chromeos/multidevice_setup/password_page.js

Status: Fixed (was: Started)
 Issue 890903  has been merged into this issue.

Sign in to add a comment