MultiDevice setup flow: Password page attempts password as soon as focus changes |
|||||
Issue descriptionChrome Version: head If the user enters an incorrect password, and then clicks outside of the password input field, the dialog attempts the password and then displays "incorrect password" (even though the user did not press Confirm). Most strangely from the user's point of view, if the user enters the correct password and taps Cancel, it will actually move forward with the flow and enable Better Together.
,
Sep 20
,
Sep 28
,
Sep 28
I fixed the bug in a new CL: https://chromium-review.googlesource.com/c/chromium/src/+/1249574 I just sent it in for review.
,
Sep 28
That proposed fix was misguided because it removed the handling of the user pressing enter. The updated fix (https://chromium-review.googlesource.com/c/chromium/src/+/1252503) the uses keypress event handling borrowed loosely from ui/webui/resources/cr_elements/cr_dialog/cr_dialog.js because the change event doesn't seem to discriminate between sources of the change submission (i.e. can't discern whether the enter key was pressed).
,
Sep 28
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/da4a7dfb643a64d939b05f253c575528a304297e commit da4a7dfb643a64d939b05f253c575528a304297e Author: Jordy Greenblatt <jordynass@chromium.org> Date: Fri Sep 28 21:23:27 2018 [CrOS MultiDevice] Fix Setup Flow bug causing spurious setup attempts The bug was caused by the change event on the password text field triggering the event 'user-submitted-password' which causes a forward navigate attempt. This fails if the password is wrong (this causes the 'incorrect password' issue in the bug) and succeeds if the password is correct (this causes the spurious flow continuation issue). Bug: 884965 Change-Id: I4ae9f9f9fd01901dacd9e69a216bdd3123eb9344 Reviewed-on: https://chromium-review.googlesource.com/1252503 Commit-Queue: Jordy Greenblatt <jordynass@chromium.org> Reviewed-by: Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#595219} [modify] https://crrev.com/da4a7dfb643a64d939b05f253c575528a304297e/ui/webui/resources/cr_components/chromeos/multidevice_setup/password_page.html [modify] https://crrev.com/da4a7dfb643a64d939b05f253c575528a304297e/ui/webui/resources/cr_components/chromeos/multidevice_setup/password_page.js
,
Sep 28
,
Oct 1
Issue 890903 has been merged into this issue. |
|||||
►
Sign in to add a comment |
|||||
Comment 1 by jlklein@chromium.org
, Sep 20