Ah yeah, they need to be changed to "chrome/..." instead of chromium

I think this is the url that's coming in, Ned can you check what's being uploaded? The url is constructed somewhere on the upload side and passed to add_reserved_diagnostics.

chrome vs chromium isn't the only difference. it needs to be: https://ci.chromium.org/p/chrome/builders/luci.chrome.ci/linux-perf-fyi/30

I looked into how this works. First, the perf dashboard upload script on the source side augment the supposed to be log url to the perf dashboard json. It's a field named 'a_stdio_uri'.

The perf dashboard then use the log url to create two URLs serving on the perf dashboard UI, the first one is the log url, and the 2nd one is the build status page. 

This is broken in many ways.
1) How we generate the log url is wrong. That's why the stdio URL hasn't worked with perf dashboard.
2) The assumption that the log url can be used to construct the build url is also wrong. e.g: there is no way to construct https://ci.chromium.org/p/chrome/builders/luci.chrome.ci/win-10-perf/697 from  https://logs.chromium.org/logs/chrome/buildbucket/cr-buildbucket.appspot.com/8934515311910208688/+/steps/components_perftests_on_Intel_GPU_on_Windows_on_Windows-10/0/stdout
(see the logic in https://cs.chromium.org/chromium/src/third_party/catapult/dashboard/dashboard/common/utils.py?rcl=868fbbf41b33c51dd147cfe842b41b9fe0bc808e&l=603)

So how to move this bug forward? I think the simplest way is the data sent to perf dashboard need to more explicit. In particular, I propose the perf dashboard accept two fields:
1) 'stdio_uri' (note: not 'a_stdio_uri' because I don't think we need 'a_' part) --> use this to show the log link.
2) 'build_uri' --> use this to show build link

Simon: if you agree with this proposal, can you take this bug, implement 'stdio_uri' & 'build_uri" for perf dashboard & histogram, then pass this bug to me so I can plumb 'stdio_uri' & 'build_uri' from the source side perf dashboard upload script.

Reassign to Simon to decide whether to go with #4.

#c4 sounds good, I'll add the new diagnostics and reassign this back when done.

The following revision refers to this bug:
  https://chromium.googlesource.com/catapult/+/97534cbfe69006b25c1961391ab90a27bcd1286a

commit 97534cbfe69006b25c1961391ab90a27bcd1286a
Author: Simon <simonhatch@chromium.org>
Date: Mon Oct 01 19:50:23 2018

Dashboard - Add a diagnostic for the build url.

It used to be possible to assemble the build url from the stdio url,
but with the luci migration this isn't true anymore. Just let them
specify the url as well.

Bug:  chromium:884961 
Change-Id: I644d2a5ee972f3e9dd0cd980b6cc22e8bbfb4e91
Reviewed-on: https://chromium-review.googlesource.com/1246641
Reviewed-by: Ethan Kuefner <eakuefner@chromium.org>
Commit-Queue: Simon Hatch <simonhatch@chromium.org>

[modify] https://crrev.com/97534cbfe69006b25c1961391ab90a27bcd1286a/dashboard/dashboard/add_histograms_test.py
[modify] https://crrev.com/97534cbfe69006b25c1961391ab90a27bcd1286a/dashboard/dashboard/add_histograms_queue.py
[modify] https://crrev.com/97534cbfe69006b25c1961391ab90a27bcd1286a/dashboard/dashboard/add_histograms.py
[modify] https://crrev.com/97534cbfe69006b25c1961391ab90a27bcd1286a/tracing/bin/add_reserved_diagnostics
[modify] https://crrev.com/97534cbfe69006b25c1961391ab90a27bcd1286a/tracing/tracing/value/diagnostics/reserved_infos.py

Ned, you can go ahead and make the changes on the waterfall side to enable this. You'll need to pass in the build url to the add_reserved_diagnostics call with --build_urls_k "Build Status" --build_urls_v "http://foo/build"

I still have some changes I need to do dashboard side to surface them, but you can start passing the data through.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/46fd327b669499295800940d58567ec7b5a9a19e

commit 46fd327b669499295800940d58567ec7b5a9a19e
Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Date: Tue Oct 02 01:03:55 2018

Roll src/third_party/catapult 69f64b270397..2ba11d1c2b02 (7 commits)

https://chromium.googlesource.com/catapult.git/+log/69f64b270397..2ba11d1c2b02


git log 69f64b270397..2ba11d1c2b02 --date=short --no-merges --format='%ad %ae %s'
2018-10-01 eakuefner@chromium.org [Dashboard] Key histogram uploads by revision timestamp if necessary
2018-10-01 benjhayden@chromium.org Add option-group for v2spa
2018-10-01 sadrul@chromium.org trace-viewer: Add a close-button to hide a process.
2018-10-01 benjhayden@chromium.org Add column-head for v2spa
2018-10-01 simonhatch@chromium.org Dashboard - Add a diagnostic for the build url.
2018-10-01 benjhayden@chromium.org Add cp-toast for v2spa.
2018-10-01 mlippautz@chromium.org tracing: Fix Blink metrics and add unified GC total sum


Created with:
  gclient setdep -r src/third_party/catapult@2ba11d1c2b02

The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel

BUG= chromium:884961 , chromium:889396 
TBR=sullivan@chromium.org

Change-Id: Ica59de5ef959096a97c5d76b961b0bd56d06df0a
Reviewed-on: https://chromium-review.googlesource.com/1255570
Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#595672}
[modify] https://crrev.com/46fd327b669499295800940d58567ec7b5a9a19e/DEPS

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/043555c46612337596eba9bdec55cc09d7ff0b52

commit 043555c46612337596eba9bdec55cc09d7ff0b52
Author: Ned Nguyen <nednguyen@google.com>
Date: Tue Oct 02 04:17:27 2018

Plumb build bot status url to perf dashboard data

Bug:  884961 
Cq-Include-Trybots: master.tryserver.chromium.perf:obbs_fyi
Change-Id: I4c0bbf99bf369e53f19b0566a8eac68636c69153
Reviewed-on: https://chromium-review.googlesource.com/1256009
Commit-Queue: Ned Nguyen <nednguyen@google.com>
Reviewed-by: John Budorick <jbudorick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595720}
[modify] https://crrev.com/043555c46612337596eba9bdec55cc09d7ff0b52/tools/perf/core/results_dashboard.py
[modify] https://crrev.com/043555c46612337596eba9bdec55cc09d7ff0b52/tools/perf/core/upload_results_to_perf_dashboard.py
[modify] https://crrev.com/043555c46612337596eba9bdec55cc09d7ff0b52/tools/perf/process_perf_results.py
[modify] https://crrev.com/043555c46612337596eba9bdec55cc09d7ff0b52/tools/perf/process_perf_results_unittest.py

The status link is working now

 Issue 887270  has been merged into this issue.

The following revision refers to this bug:
  https://chromium.googlesource.com/catapult/+/3f7d74f7cd026ad3611e089c377b03304277d566

commit 3f7d74f7cd026ad3611e089c377b03304277d566
Author: Simon <simonhatch@chromium.org>
Date: Thu Oct 04 19:22:27 2018

Dashboard - Remove old buildbot link if new one is there

Bug:  chromium:884961 
Change-Id: If5fae731d4a55aa6ae7f1b957f6d5a8ba1d16076
Reviewed-on: https://chromium-review.googlesource.com/c/1257982
Reviewed-by: Ethan Kuefner <eakuefner@chromium.org>
Commit-Queue: Simon Hatch <simonhatch@chromium.org>

[modify] https://crrev.com/3f7d74f7cd026ad3611e089c377b03304277d566/dashboard/dashboard/graph_json.py
[modify] https://crrev.com/3f7d74f7cd026ad3611e089c377b03304277d566/dashboard/dashboard/graph_json_test.py

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9253b83dbeb8dd0e5617db966cbae3bf68ec90e2

commit 9253b83dbeb8dd0e5617db966cbae3bf68ec90e2
Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Date: Thu Oct 04 22:24:12 2018

Roll src/third_party/catapult 1b6e81b579f3..3f7d74f7cd02 (2 commits)

https://chromium.googlesource.com/catapult.git/+log/1b6e81b579f3..3f7d74f7cd02


git log 1b6e81b579f3..3f7d74f7cd02 --date=short --no-merges --format='%ad %ae %s'
2018-10-04 simonhatch@chromium.org Dashboard - Remove old buildbot link if new one is there
2018-10-04 sebmarchand@chromium.org Add more system stats to the UI tracing view


Created with:
  gclient setdep -r src/third_party/catapult@3f7d74f7cd02

The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel

BUG= chromium:884961 
TBR=sullivan@chromium.org

Change-Id: I943091e568645704071b431cb1da5c0aa2f29693
Reviewed-on: https://chromium-review.googlesource.com/c/1262240
Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#596885}
[modify] https://crrev.com/9253b83dbeb8dd0e5617db966cbae3bf68ec90e2/DEPS