New issue
Advanced search Search tips

Issue 884960 link

Starred by 2 users
Status: Fixed
Owner:
bashi@chromium.org
Closed: Oct 9
Cc:
nhiroki@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug

Blocking:
issue 846235



Sign in to add a comment

Some SharedWorkerTest are failing when NetworkService/ServiceWorkerServicification is enabled

Project Member Reported by bashi@chromium.org, Sep 18 
Following tests are failing when NetworkService/ServiceWorkerServicification is enabled:

* SharedWorkerHostTest.Normal
* SharedWorkerHostTest.OnContextClosed
* SharedWorkerHostTest.TerminateAfterStarting

This seems to started happening after https://crrev.com/c/1154743. SharedWorkerHostTest::StartWorker() calls SharedWorkerHost::Start() without providing url loaders and other information but there are some DCHECK() for them.

https://cs.chromium.org/chromium/src/content/browser/shared_worker/shared_worker_host.cc?l=153&rcl=994c3fc22de4fce492a63f6825fb83c52d0d73b2
Project Member

Comment 1 by bugdroid1@chromium.org, Sep 25 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/86f51f0bf99085f17180a6e86a2e3672b461f8f1

commit 86f51f0bf99085f17180a6e86a2e3672b461f8f1
Author: Kenichi Ishibashi <bashi@chromium.org>
Date: Tue Sep 25 04:11:43 2018

Fix SharedWorkerHostTests for NetworkService/S13nServiceWorker

Some tests in SharedWorkerHostTest were failing because they
didn't pass some parameters which are required as of
https://crrev.com/c/1154743. Pass some mock objects to make
them pass.

Bug:  884960 
Cq-Include-Trybots: luci.chromium.try:linux_mojo
Change-Id: I9ea6e04746a632e5ae069f7d810123c628ce7f06
Reviewed-on: https://chromium-review.googlesource.com/1235257
Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org>
Commit-Queue: Kenichi Ishibashi <bashi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#593822}
[modify] https://crrev.com/86f51f0bf99085f17180a6e86a2e3672b461f8f1/content/browser/shared_worker/shared_worker_host_unittest.cc

Comment 2 by bashi@chromium.org, Oct 9

Status: Fixed (was: Assigned)
►

Sign in to add a comment