New issue
Advanced search Search tips

Issue 884956 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Sep 18
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: ----
Type: ----



Sign in to add a comment

[css-grid] Static position should use content-box, not padding-box

Project Member Reported by monorail...@ecosystem-infra.iam.gserviceaccount.com, Sep 18

Issue description

WPT import https://crrev.com/c/1228987 introduced new failures in external/wpt/css/css-grid:

List of new failures:
external/wpt/css/css-grid/abspos/absolute-positioning-grid-container-parent-001.html new failing tests: https://crrev.com/c/1228987/4/third_party/WebKit/LayoutTests/external/wpt/css/css-grid/abspos/absolute-positioning-grid-container-parent-001-expected.txt

This import contains upstream changes from 0cdea14135e5410ffae78c8e57a37ecd4c548408 to faa0fd6c48497daadc4d4da0d1519cce484b5af5:
HTML: test fieldset with percentage padding: https://github.com/web-platform-tests/wpt/commit/faa0fd6c48497daadc4d4da0d1519cce484b5af5
HTML: Test rendering of fieldset with a tall legend: https://github.com/web-platform-tests/wpt/commit/0de4f6b22d32d568047519b00b7503fbc93c9ada
wpt: Remove Mulet check from reftest annotation regex.: https://github.com/web-platform-tests/wpt/commit/e6fd8f35c3604d3b94d0a975a3e1d5fa8ef0cabc [affecting this directory]
Add basic tests for multiple position gradient stops: https://github.com/web-platform-tests/wpt/commit/d36d9f40770a376ddd4582c1ee186aa6885a4ab9 [affecting this directory]
Enable experimental web features for Chrome Dev: https://github.com/web-platform-tests/wpt/commit/406a3e3f7d51f74d8640f96677d96ec624e00a4e
Clarify help text for channel & browser-channel: https://github.com/web-platform-tests/wpt/commit/ac5460bf595e1286eed5806f255a1f38f7cf15bf
Implemented the correct 'self' matching logic according to the spec: https://github.com/web-platform-tests/wpt/commit/aaa732df618787dbcbc6f7ce96a3bf95bd6b03b4
Delete goal-parameter.htm: https://github.com/web-platform-tests/wpt/commit/fb745708cbe264d7477b846cb87d67dcce310e27
Correctly handle ScriptTimeoutException in the WebDriver executor (#13033): https://github.com/web-platform-tests/wpt/commit/931c48432df56de454d72448b8e04cfbe15013da
[testharness.js] Disallow `test` return value (#12958): https://github.com/web-platform-tests/wpt/commit/2da097f6f7b3f91d9b18706cff3cac272d7cdf0a
[Background Fetch] Implement recordsAvailable.: https://github.com/web-platform-tests/wpt/commit/445544dcf920e46d158bfe82b1e45e30360ed278
[css-contain] Layout and size containment and baseline alignment: https://github.com/web-platform-tests/wpt/commit/bec8a89a03674f5cf7a6aa8b7b23d196c377790f [affecting this directory]
[css-properties-values-api] Detect font-relative units via var() refs.: https://github.com/web-platform-tests/wpt/commit/458e92e9b0acc9d3711f5cb24a4024c0fa553696 [affecting this directory]
Update interfaces/payment-handler.idl (#13015): https://github.com/web-platform-tests/wpt/commit/2b12eb901ef17b2caa139ebb659b01a9756e4ab7
[css-flexbox] Flexible Box property parsing tests (#11730): https://github.com/web-platform-tests/wpt/commit/1aaada4bbc936024441fe7995b77c21a2c554da1 [affecting this directory]
DOMWindowTimers::setTimeout and setInterval modified to accept Trusted Types.: https://github.com/web-platform-tests/wpt/commit/d646c3ce22d218a53c365c9c8cd47315175dc6c9
Sync Mozilla CSS tests as of https://hg.mozilla.org/mozilla-central/rev/7ed950e60f3c1f8a47c117c04124d31e94a66e32 . (#13022): https://github.com/web-platform-tests/wpt/commit/8f983f1fae8fb06a5b4a42e2040333407f0d51a8 [affecting this directory]
Merge pull request #13021 from ewilligers/animations-inheritance: https://github.com/web-platform-tests/wpt/commit/7f9db5e2eb8852d317613a1e4017b045ee4096e4
[css-animations] Test inheritance, initial values: https://github.com/web-platform-tests/wpt/commit/65dfd1dc6df2fff9e480836c85ad0525558b883b [affecting this directory]
Test inheritance of CSS Inline Layout properties (#12593): https://github.com/web-platform-tests/wpt/commit/677dfdd2337fd9b2cf50b371e5be7600f73a3a99 [affecting this directory]
[css-text-3] No hyphenation without language: https://github.com/web-platform-tests/wpt/commit/59b6c37f2b02362566e19aba7299434f00de2258 [affecting this directory]
Merge pull request #12956 from Loirooriol/css-computed-insets: https://github.com/web-platform-tests/wpt/commit/5051858e95936197d354cc18ea88365cb9d3e690
part 2 - [css-grid] Static position should use content-box, not padding-box.  Test reference updates.: https://github.com/web-platform-tests/wpt/commit/86ac68734058ed4a623152cc921f6fc9d167c774 [affecting this directory]
Test resolved value for inset CSS properties: https://github.com/web-platform-tests/wpt/commit/2db4dd68bf8ec4b477452ef51380520c8dcdcb7e [affecting this directory]

 
Cc: svil...@igalia.com jfernan...@igalia.com
Status: Available (was: Untriaged)
Summary: [css-grid] Static position should use content-box, not padding-box (was: [WPT] New failures introduced in external/wpt/css/css-grid by import https://crrev.com/c/1228987)
This is due to a recent change in the spec:
https://github.com/w3c/csswg-drafts/issues/3020
Owner: r...@igalia.com
Status: Started (was: Available)
Project Member

Comment 3 by bugdroid1@chromium.org, Sep 18

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/057aefb24ac215df9b93c4307f22e69882355e81

commit 057aefb24ac215df9b93c4307f22e69882355e81
Author: Manuel Rego Casasnovas <rego@igalia.com>
Date: Tue Sep 18 12:49:02 2018

[css-grid] Static position should use content-box, not padding-box

This is a recent change by the CSSWG:
https://github.com/w3c/csswg-drafts/issues/3020

The spec text (https://drafts.csswg.org/css-grid/#static-position):
  "The static position of an absolutely-positioned child
   of a grid container is determined as if it were the sole grid item
   in a grid area whose edges coincide with the content edges
   of the grid container."

The patch is just a simple change in
LayoutGrid::PrepareChildForPositionedLayout() to use border and padding.

BUG= 884956 
TEST=external/wpt/css/css-grid/abspos/absolute-positioning-grid-container-parent-001.html

Change-Id: I01a77dfe41abcfac00c6d45f517c6d216aaa8ff7
Reviewed-on: https://chromium-review.googlesource.com/1229893
Commit-Queue: Manuel Rego <rego@igalia.com>
Reviewed-by: Javier Fernandez <jfernandez@igalia.com>
Cr-Commit-Position: refs/heads/master@{#592010}
[delete] https://crrev.com/c77bd69af6488f19b4ccefc6ea3f6c0e4c2d4412/third_party/WebKit/LayoutTests/external/wpt/css/css-grid/abspos/absolute-positioning-grid-container-parent-001-expected.txt
[modify] https://crrev.com/057aefb24ac215df9b93c4307f22e69882355e81/third_party/blink/renderer/core/layout/layout_grid.cc

Status: Fixed (was: Started)

Sign in to add a comment