New issue
Advanced search Search tips

Issue 884945 link

Starred by 1 user
Status: Fixed
Owner:
steimel@chromium.org
Closed: Oct 15
Cc:
mlamouri@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , Chrome , Mac
Pri: 2
Type: Task


Show other hotlists

Hotlists containing this issue:
Modern-Media-Controls


Sign in to add a comment

Media Controls: Visual tweaks for M71

Project Member Reported by steimel@chromium.org, Sep 18 
We have some visual tweaks we want to do for M71:

1) Add 8px to below scrubber on small breakpoint
2) Make timestamp 14pt on all breakpoints
3) Add padding to align overflow button
4) Smoothen play/pause button size between breakpoints
5) Shrink med/large bp scrubber down so bottom is 16px from bottom of video
6) Optically align timestamp
Project Member

Comment 1 by bugdroid1@chromium.org, Sep 20 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/99e423eea795710e141aa99d5ba18bd1648ae892

commit 99e423eea795710e141aa99d5ba18bd1648ae892
Author: Tommy Steimel <steimel@chromium.org>
Date: Thu Sep 20 00:17:16 2018

[Media Controls] Visual tweaks

This CL makes some visual tweaks to the media controls to match new
specs.

Bug:  884945 
Change-Id: Ifdff1c51b6a2bd37555a7d018679dd77fc8781cc
Reviewed-on: https://chromium-review.googlesource.com/1229696
Reviewed-by: Becca Hughes <beccahughes@chromium.org>
Commit-Queue: Tommy Steimel <steimel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#592623}
[modify] https://crrev.com/99e423eea795710e141aa99d5ba18bd1648ae892/third_party/WebKit/LayoutTests/platform/linux/compositing/video/video-controls-layer-creation-expected.png
[modify] https://crrev.com/99e423eea795710e141aa99d5ba18bd1648ae892/third_party/WebKit/LayoutTests/platform/linux/fast/overflow/overflow-of-video-outline-expected.png
[modify] https://crrev.com/99e423eea795710e141aa99d5ba18bd1648ae892/third_party/WebKit/LayoutTests/platform/linux/media/controls-after-reload-expected.png
[modify] https://crrev.com/99e423eea795710e141aa99d5ba18bd1648ae892/third_party/WebKit/LayoutTests/platform/linux/media/controls-after-reload-expected.txt
[modify] https://crrev.com/99e423eea795710e141aa99d5ba18bd1648ae892/third_party/WebKit/LayoutTests/platform/linux/media/controls-layout-direction-expected.png
[modify] https://crrev.com/99e423eea795710e141aa99d5ba18bd1648ae892/third_party/WebKit/LayoutTests/platform/linux/media/controls-strict-expected.png
[modify] https://crrev.com/99e423eea795710e141aa99d5ba18bd1648ae892/third_party/WebKit/LayoutTests/platform/linux/media/controls-strict-expected.txt
[modify] https://crrev.com/99e423eea795710e141aa99d5ba18bd1648ae892/third_party/WebKit/LayoutTests/platform/linux/media/controls-styling-expected.png
[modify] https://crrev.com/99e423eea795710e141aa99d5ba18bd1648ae892/third_party/WebKit/LayoutTests/platform/linux/media/controls-styling-expected.txt
[modify] https://crrev.com/99e423eea795710e141aa99d5ba18bd1648ae892/third_party/WebKit/LayoutTests/platform/linux/media/controls-styling-strict-expected.png
[modify] https://crrev.com/99e423eea795710e141aa99d5ba18bd1648ae892/third_party/WebKit/LayoutTests/platform/linux/media/controls-styling-strict-expected.txt
[modify] https://crrev.com/99e423eea795710e141aa99d5ba18bd1648ae892/third_party/WebKit/LayoutTests/platform/linux/media/controls-without-preload-expected.png
[modify] https://crrev.com/99e423eea795710e141aa99d5ba18bd1648ae892/third_party/WebKit/LayoutTests/platform/linux/media/controls-without-preload-expected.txt
[modify] https://crrev.com/99e423eea795710e141aa99d5ba18bd1648ae892/third_party/WebKit/LayoutTests/platform/linux/media/controls/lazy-loaded-style-expected.txt
[modify] https://crrev.com/99e423eea795710e141aa99d5ba18bd1648ae892/third_party/WebKit/LayoutTests/platform/linux/media/controls/paint-controls-webkit-appearance-none-custom-bg-expected.png
[modify] https://crrev.com/99e423eea795710e141aa99d5ba18bd1648ae892/third_party/WebKit/LayoutTests/platform/linux/media/controls/paint-controls-webkit-appearance-none-custom-bg-expected.txt
[modify] https://crrev.com/99e423eea795710e141aa99d5ba18bd1648ae892/third_party/WebKit/LayoutTests/platform/linux/media/controls/paint-controls-webkit-appearance-none-expected.png
[modify] https://crrev.com/99e423eea795710e141aa99d5ba18bd1648ae892/third_party/WebKit/LayoutTests/platform/linux/media/controls/paint-controls-webkit-appearance-none-expected.txt
[modify] https://crrev.com/99e423eea795710e141aa99d5ba18bd1648ae892/third_party/WebKit/LayoutTests/platform/linux/media/controls/video-controls-with-cast-rendering-expected.png
[modify] https://crrev.com/99e423eea795710e141aa99d5ba18bd1648ae892/third_party/WebKit/LayoutTests/platform/linux/media/controls/video-controls-with-cast-rendering-expected.txt
[modify] https://crrev.com/99e423eea795710e141aa99d5ba18bd1648ae892/third_party/WebKit/LayoutTests/platform/linux/media/media-controls-clone-expected.png
[modify] https://crrev.com/99e423eea795710e141aa99d5ba18bd1648ae892/third_party/WebKit/LayoutTests/platform/linux/media/media-controls-clone-expected.txt
[modify] https://crrev.com/99e423eea795710e141aa99d5ba18bd1648ae892/third_party/WebKit/LayoutTests/platform/linux/media/media-controls-grey-scrubber-expected.png
[modify] https://crrev.com/99e423eea795710e141aa99d5ba18bd1648ae892/third_party/WebKit/LayoutTests/platform/linux/media/media-controls-grey-scrubber-expected.txt
[modify] https://crrev.com/99e423eea795710e141aa99d5ba18bd1648ae892/third_party/WebKit/LayoutTests/platform/linux/media/video-controls-rendering-expected.png
[modify] https://crrev.com/99e423eea795710e141aa99d5ba18bd1648ae892/third_party/WebKit/LayoutTests/platform/linux/media/video-controls-rendering-expected.txt
[modify] https://crrev.com/99e423eea795710e141aa99d5ba18bd1648ae892/third_party/WebKit/LayoutTests/platform/linux/media/video-display-toggle-expected.png
[modify] https://crrev.com/99e423eea795710e141aa99d5ba18bd1648ae892/third_party/WebKit/LayoutTests/platform/linux/media/video-display-toggle-expected.txt
[modify] https://crrev.com/99e423eea795710e141aa99d5ba18bd1648ae892/third_party/WebKit/LayoutTests/platform/linux/media/video-empty-source-expected.png
[modify] https://crrev.com/99e423eea795710e141aa99d5ba18bd1648ae892/third_party/WebKit/LayoutTests/platform/linux/media/video-empty-source-expected.txt
[modify] https://crrev.com/99e423eea795710e141aa99d5ba18bd1648ae892/third_party/WebKit/LayoutTests/platform/linux/media/video-no-audio-expected.png
[modify] https://crrev.com/99e423eea795710e141aa99d5ba18bd1648ae892/third_party/WebKit/LayoutTests/platform/linux/media/video-no-audio-expected.txt
[modify] https://crrev.com/99e423eea795710e141aa99d5ba18bd1648ae892/third_party/WebKit/LayoutTests/platform/linux/media/video-zoom-controls-expected.png
[modify] https://crrev.com/99e423eea795710e141aa99d5ba18bd1648ae892/third_party/WebKit/LayoutTests/platform/linux/media/video-zoom-controls-expected.txt
[modify] https://crrev.com/99e423eea795710e141aa99d5ba18bd1648ae892/third_party/WebKit/LayoutTests/platform/linux/virtual/android/fullscreen/full-screen-iframe-allowed-video-expected.png
[modify] https://crrev.com/99e423eea795710e141aa99d5ba18bd1648ae892/third_party/WebKit/LayoutTests/platform/linux/virtual/android/fullscreen/video-controls-timeline-expected.png
[modify] https://crrev.com/99e423eea795710e141aa99d5ba18bd1648ae892/third_party/WebKit/LayoutTests/platform/linux/virtual/android/fullscreen/video-scrolled-iframe-expected.png
[modify] https://crrev.com/99e423eea795710e141aa99d5ba18bd1648ae892/third_party/WebKit/LayoutTests/platform/linux/virtual/new-remote-playback-pipeline/media/controls/lazy-loaded-style-expected.txt
[modify] https://crrev.com/99e423eea795710e141aa99d5ba18bd1648ae892/third_party/WebKit/LayoutTests/platform/linux/virtual/new-remote-playback-pipeline/media/controls/paint-controls-webkit-appearance-none-custom-bg-expected.png
[modify] https://crrev.com/99e423eea795710e141aa99d5ba18bd1648ae892/third_party/WebKit/LayoutTests/platform/linux/virtual/new-remote-playback-pipeline/media/controls/paint-controls-webkit-appearance-none-custom-bg-expected.txt
[modify] https://crrev.com/99e423eea795710e141aa99d5ba18bd1648ae892/third_party/WebKit/LayoutTests/platform/linux/virtual/new-remote-playback-pipeline/media/controls/paint-controls-webkit-appearance-none-expected.png
[modify] https://crrev.com/99e423eea795710e141aa99d5ba18bd1648ae892/third_party/WebKit/LayoutTests/platform/linux/virtual/new-remote-playback-pipeline/media/controls/paint-controls-webkit-appearance-none-expected.txt
[modify] https://crrev.com/99e423eea795710e141aa99d5ba18bd1648ae892/third_party/WebKit/LayoutTests/platform/linux/virtual/new-remote-playback-pipeline/media/controls/video-controls-with-cast-rendering-expected.png
[modify] https://crrev.com/99e423eea795710e141aa99d5ba18bd1648ae892/third_party/WebKit/LayoutTests/platform/linux/virtual/new-remote-playback-pipeline/media/controls/video-controls-with-cast-rendering-expected.txt
[modify] https://crrev.com/99e423eea795710e141aa99d5ba18bd1648ae892/third_party/WebKit/LayoutTests/platform/linux/virtual/video-surface-layer/media/controls-after-reload-expected.png
[modify] https://crrev.com/99e423eea795710e141aa99d5ba18bd1648ae892/third_party/WebKit/LayoutTests/platform/linux/virtual/video-surface-layer/media/controls-after-reload-expected.txt
[modify] https://crrev.com/99e423eea795710e141aa99d5ba18bd1648ae892/third_party/WebKit/LayoutTests/platform/linux/virtual/video-surface-layer/media/controls-layout-direction-expected.png
[modify] https://crrev.com/99e423eea795710e141aa99d5ba18bd1648ae892/third_party/WebKit/LayoutTests/platform/linux/virtual/video-surface-layer/media/controls-strict-expected.png
[modify] https://crrev.com/99e423eea795710e141aa99d5ba18bd1648ae892/third_party/WebKit/LayoutTests/platform/linux/virtual/video-surface-layer/media/controls-strict-expected.txt
[modify] https://crrev.com/99e423eea795710e141aa99d5ba18bd1648ae892/third_party/WebKit/LayoutTests/platform/linux/virtual/video-surface-layer/media/controls-styling-expected.png
[modify] https://crrev.com/99e423eea795710e141aa99d5ba18bd1648ae892/third_party/WebKit/LayoutTests/platform/linux/virtual/video-surface-layer/media/controls-styling-expected.txt
[modify] https://crrev.com/99e423eea795710e141aa99d5ba18bd1648ae892/third_party/WebKit/LayoutTests/platform/linux/virtual/video-surface-layer/media/controls-styling-strict-expected.png
[modify] https://crrev.com/99e423eea795710e141aa99d5ba18bd1648ae892/third_party/WebKit/LayoutTests/platform/linux/virtual/video-surface-layer/media/controls-styling-strict-expected.txt
[modify] https://crrev.com/99e423eea795710e141aa99d5ba18bd1648ae892/third_party/WebKit/LayoutTests/platform/linux/virtual/video-surface-layer/media/controls-without-preload-expected.png
[modify] https://crrev.com/99e423eea795710e141aa99d5ba18bd1648ae892/third_party/WebKit/LayoutTests/platform/linux/virtual/video-surface-layer/media/controls-without-preload-expected.txt
[modify] https://crrev.com/99e423eea795710e141aa99d5ba18bd1648ae892/third_party/WebKit/LayoutTests/platform/linux/virtual/video-surface-layer/media/controls/video-controls-with-cast-rendering-expected.png
[modify] https://crrev.com/99e423eea795710e141aa99d5ba18bd1648ae892/third_party/WebKit/LayoutTests/platform/linux/virtual/video-surface-layer/media/controls/video-controls-with-cast-rendering-expected.txt
[modify] https://crrev.com/99e423eea795710e141aa99d5ba18bd1648ae892/third_party/WebKit/LayoutTests/platform/linux/virtual/video-surface-layer/media/media-controls-clone-expected.png
[modify] https://crrev.com/99e423eea795710e141aa99d5ba18bd1648ae892/third_party/WebKit/LayoutTests/platform/linux/virtual/video-surface-layer/media/media-controls-clone-expected.txt
[modify] https://crrev.com/99e423eea795710e141aa99d5ba18bd1648ae892/third_party/WebKit/LayoutTests/platform/linux/virtual/video-surface-layer/media/media-controls-grey-scrubber-expected.png
[modify] https://crrev.com/99e423eea795710e141aa99d5ba18bd1648ae892/third_party/WebKit/LayoutTests/platform/linux/virtual/video-surface-layer/media/media-controls-grey-scrubber-expected.txt
[modify] https://crrev.com/99e423eea795710e141aa99d5ba18bd1648ae892/third_party/WebKit/LayoutTests/platform/linux/virtual/video-surface-layer/media/video-controls-rendering-expected.png
[modify] https://crrev.com/99e423eea795710e141aa99d5ba18bd1648ae892/third_party/WebKit/LayoutTests/platform/linux/virtual/video-surface-layer/media/video-controls-rendering-expected.txt
[modify] https://crrev.com/99e423eea795710e141aa99d5ba18bd1648ae892/third_party/WebKit/LayoutTests/platform/linux/virtual/video-surface-layer/media/video-display-toggle-expected.png
[modify] https://crrev.com/99e423eea795710e141aa99d5ba18bd1648ae892/third_party/WebKit/LayoutTests/platform/linux/virtual/video-surface-layer/media/video-display-toggle-expected.txt
[modify] https://crrev.com/99e423eea795710e141aa99d5ba18bd1648ae892/third_party/WebKit/LayoutTests/platform/linux/virtual/video-surface-layer/media/video-empty-source-expected.png
[modify] https://crrev.com/99e423eea795710e141aa99d5ba18bd1648ae892/third_party/WebKit/LayoutTests/platform/linux/virtual/video-surface-layer/media/video-empty-source-expected.txt
[modify] https://crrev.com/99e423eea795710e141aa99d5ba18bd1648ae892/third_party/WebKit/LayoutTests/platform/linux/virtual/video-surface-layer/media/video-no-audio-expected.png
[modify] https://crrev.com/99e423eea795710e141aa99d5ba18bd1648ae892/third_party/WebKit/LayoutTests/platform/linux/virtual/video-surface-layer/media/video-no-audio-expected.txt
[modify] https://crrev.com/99e423eea795710e141aa99d5ba18bd1648ae892/third_party/WebKit/LayoutTests/platform/linux/virtual/video-surface-layer/media/video-zoom-controls-expected.png
[modify] https://crrev.com/99e423eea795710e141aa99d5ba18bd1648ae892/third_party/WebKit/LayoutTests/platform/linux/virtual/video-surface-layer/media/video-zoom-controls-expected.txt
[delete] https://crrev.com/e130ef9c8ac16f65d4dc5cff95e26118a4e39438/third_party/WebKit/LayoutTests/platform/mac-mac10.11/media/controls-after-reload-expected.png
[delete] https://crrev.com/e130ef9c8ac16f65d4dc5cff95e26118a4e39438/third_party/WebKit/LayoutTests/platform/mac-mac10.11/media/controls-strict-expected.png
[delete] https://crrev.com/e130ef9c8ac16f65d4dc5cff95e26118a4e39438/third_party/WebKit/LayoutTests/platform/mac-mac10.11/media/controls-styling-expected.png
[delete] https://crrev.com/e130ef9c8ac16f65d4dc5cff95e26118a4e39438/third_party/WebKit/LayoutTests/platform/mac-mac10.11/media/controls-styling-strict-expected.png
[delete] https://crrev.com/e130ef9c8ac16f65d4dc5cff95e26118a4e39438/third_party/WebKit/LayoutTests/platform/mac-mac10.11/media/controls-without-preload-expected.png
[delete] https://crrev.com/e130ef9c8ac16f65d4dc5cff95e26118a4e39438/third_party/WebKit/LayoutTests/platform/mac-mac10.11/media/controls/paint-controls-webkit-appearance-none-custom-bg-expected.png
[delete] https://crrev.com/e130ef9c8ac16f65d4dc5cff95e26118a4e39438/third_party/WebKit/LayoutTests/platform/mac-mac10.11/media/controls/paint-controls-webkit-appearance-none-expected.png
[delete] https://crrev.com/e130ef9c8ac16f65d4dc5cff95e26118a4e39438/third_party/WebKit/LayoutTests/platform/mac-mac10.11/media/video-controls-rendering-expected.png
[delete] https://crrev.com/e130ef9c8ac16f65d4dc5cff95e26118a4e39438/third_party/WebKit/LayoutTests/platform/mac-mac10.11/media/video-display-toggle-expected.png
[delete] https://crrev.com/e130ef9c8ac16f65d4dc5cff95e26118a4e39438/third_party/WebKit/LayoutTests/platform/mac-mac10.11/media/video-no-audio-expected.png
[add] https://crrev.com/99e423eea795710e141aa99d5ba18bd1648ae892/third_party/WebKit/LayoutTests/platform/mac-mac10.11/media/video-zoom-controls-expected.png
[delete] https://crrev.com/e130ef9c8ac16f65d4dc5cff95e26118a4e39438/third_party/WebKit/LayoutTests/platform/mac-mac10.11/virtual/new-remote-playback-pipeline/media/controls/paint-controls-webkit-appearance-none-custom-bg-expected.png
[delete] https://crrev.com/e130ef9c8ac16f65d4dc5cff95e26118a4e39438/third_party/WebKit/LayoutTests/platform/mac-mac10.11/virtual/new-remote-playback-pipeline/media/controls/paint-controls-webkit-appearance-none-expected.png
[delete] https://crrev.com/e130ef9c8ac16f65d4dc5cff95e26118a4e39438/third_party/WebKit/LayoutTests/platform/mac-mac10.11/virtual/video-surface-layer/media/controls-after-reload-expected.png
[delete] https://crrev.com/e130ef9c8ac16f65d4dc5cff95e26118a4e39438/third_party/WebKit/LayoutTests/platform/mac-mac10.11/virtual/video-surface-layer/media/controls-strict-expected.png
[delete] https://crrev.com/e130ef9c8ac16f65d4dc5cff95e26118a4e39438/third_party/WebKit/LayoutTests/platform/mac-mac10.11/virtual/video-surface-layer/media/controls-styling-expected.png
[delete] https://crrev.com/e130ef9c8ac16f65d4dc5cff95e26118a4e39438/third_party/WebKit/LayoutTests/platform/mac-mac10.11/virtual/video-surface-layer/media/controls-styling-strict-expected.png
[delete] https://crrev.com/e130ef9c8ac16f65d4dc5cff95e26118a4e39438/third_party/WebKit/LayoutTests/platform/mac-mac10.11/virtual/video-surface-layer/media/controls-without-preload-expected.png
[delete] https://crrev.com/e130ef9c8ac16f65d4dc5cff95e26118a4e39438/third_party/WebKit/LayoutTests/platform/mac-mac10.11/virtual/video-surface-layer/media/video-controls-rendering-expected.png
[delete] https://crrev.com/e130ef9c8ac16f65d4dc5cff95e26118a4e39438/third_party/WebKit/LayoutTests/platform/mac-mac10.11/virtual/video-surface-layer/media/video-display-toggle-expected.png
[add] https://crrev.com/99e423eea795710e141aa99d5ba18bd1648ae892/third_party/WebKit/LayoutTests/platform/mac-mac10.11/virtual/video-surface-layer/media/video-zoom-controls-expected.png
[add] https://crrev.com/99e423eea795710e141aa99d5ba18bd1648ae892/third_party/WebKit/LayoutTests/platform/mac-mac10.12/compositing/video/video-controls-layer-creation-expected.png
[add] https://crrev.com/99e423eea795710e141aa99d5ba18bd1648ae892/third_party/WebKit/LayoutTests/platform/mac-mac10.12/fast/overflow/overflow-of-video-outline-expected.png
[add] https://crrev.com/99e423eea795710e141aa99d5ba18bd1648ae892/third_party/WebKit/LayoutTests/platform/mac-mac10.12/media/controls-after-reload-expected.png
[modify] https://crrev.com/99e423eea795710e141aa99d5ba18bd1648ae892/third_party/WebKit/LayoutTests/platform/mac-mac10.12/media/controls-layout-direction-expected.png
[add] https://crrev.com/99e423eea795710e141aa99d5ba18bd1648ae892/third_party/WebKit/LayoutTests/platform/mac-mac10.12/media/controls-strict-expected.png
[add] https://crrev.com/99e423eea795710e141aa99d5ba18bd1648ae892/third_party/WebKit/LayoutTests/platform/mac-mac10.12/media/controls-styling-expected.png
[add] https://crrev.com/99e423eea795710e141aa99d5ba18bd1648ae892/third_party/WebKit/LayoutTests/platform/mac-mac10.12/media/controls-styling-strict-expected.png
[add] https://crrev.com/99e423eea795710e141aa99d5ba18bd1648ae892/third_party/WebKit/LayoutTests/platform/mac-mac10.12/media/controls-without-preload-expected.png
[add] https://crrev.com/99e423eea795710e141aa99d5ba18bd1648ae892/third_party/WebKit/LayoutTests/platform/mac-mac10.12/media/controls/paint-controls-webkit-appearance-none-custom-bg-expected.png
[add] https://crrev.com/99e423eea795710e141aa99d5ba18bd1648ae892/third_party/WebKit/LayoutTests/platform/mac-mac10.12/media/controls/paint-controls-webkit-appearance-none-expected.png
[modify] https://crrev.com/99e423eea795710e141aa99d5ba18bd1648ae892/third_party/WebKit/LayoutTests/platform/mac-mac10.12/media/media-controls-clone-expected.png
[add] https://crrev.com/99e423eea795710e141aa99d5ba18bd1648ae892/third_party/WebKit/LayoutTests/platform/mac-mac10.12/media/media-controls-grey-scrubber-expected.png
[add] https://crrev.com/99e423eea795710e141aa99d5ba18bd1648ae892/third_party/WebKit/LayoutTests/platform/mac-mac10.12/media/video-controls-rendering-expected.png
[add] https://crrev.com/99e423eea795710e141aa99d5ba18bd1648ae892/third_party/WebKit/LayoutTests/platform/mac-mac10.12/media/video-display-toggle-expected.png
[add] https://crrev.com/99e423eea795710e141aa99d5ba18bd1648ae892/third_party/WebKit/LayoutTests/platform/mac-mac10.12/media/video-empty-source-expected.png
[add] https://crrev.com/99e423eea795710e141aa99d5ba18bd1648ae892/third_party/WebKit/LayoutTests/platform/mac-mac10.12/media/video-no-audio-expected.png
[modify] https://crrev.com/99e423eea795710e141aa99d5ba18bd1648ae892/third_party/WebKit/LayoutTests/platform/mac-mac10.12/media/video-zoom-controls-expected.png
[add] https://crrev.com/99e423eea795710e141aa99d5ba18bd1648ae892/third_party/WebKit/LayoutTests/platform/mac-mac10.12/virtual/new-remote-playback-pipeline/media/controls/paint-controls-webkit-appearance-none-custom-bg-expected.png
[add] https://crrev.com/99e423eea795710e141aa99d5ba18bd1648ae892/third_party/WebKit/LayoutTests/platform/mac-mac10.12/virtual/new-remote-playback-pipeline/media/controls/paint-controls-webkit-appearance-none-expected.png
[add] https://crrev.com/99e423eea795710e141aa99d5ba18bd1648ae892/third_party/WebKit/LayoutTests/platform/mac-mac10.12/virtual/video-surface-layer/media/controls-after-reload-expected.png
[modify] https://crrev.com/99e423eea795710e141aa99d5ba18bd1648ae892/third_party/WebKit/LayoutTests/platform/mac-mac10.12/virtual/video-surface-layer/media/controls-layout-direction-expected.png
[add] https://crrev.com/99e423eea795710e141aa99d5ba18bd1648ae892/third_party/WebKit/LayoutTests/platform/mac-mac10.12/virtual/video-surface-layer/media/controls-strict-expected.png
[add] https://crrev.com/99e423eea795710e141aa99d5ba18bd1648ae892/third_party/WebKit/LayoutTests/platform/mac-mac10.12/virtual/video-surface-layer/media/controls-styling-expected.png
[add] https://crrev.com/99e423eea795710e141aa99d5ba18bd1648ae892/third_party/WebKit/LayoutTests/platform/mac-mac10.12/virtual/video-surface-layer/media/controls-styling-strict-expected.png
[add] https://crrev.com/99e423eea795710e141aa99d5ba18bd1648ae892/third_party/WebKit/LayoutTests/platform/mac-mac10.12/virtual/video-surface-layer/media/controls-without-preload-expected.png
[modify] https://crrev.com/99e423eea795710e141aa99d5ba18bd1648ae892/third_party/WebKit/LayoutTests/platform/mac-mac10.12/virtual/video-surface-layer/media/media-controls-clone-expected.png
[add] https://crrev.com/99e423eea795710e141aa99d5ba18bd1648ae892/third_party/WebKit/LayoutTests/platform/mac-mac10.12/virtual/video-surface-layer/media/media-controls-grey-scrubber-expected.png
[add] https://crrev.com/99e423eea795710e141aa99d5ba18bd1648ae892/third_party/WebKit/LayoutTests/platform/mac-mac10.12/virtual/video-surface-layer/media/video-controls-rendering-expected.png
[add] https://crrev.com/99e423eea795710e141aa99d5ba18bd1648ae892/third_party/WebKit/LayoutTests/platform/mac-mac10.12/virtual/video-surface-layer/media/video-display-toggle-expected.png
[add] https://crrev.com/99e423eea795710e141aa99d5ba18bd1648ae892/third_party/WebKit/LayoutTests/platform/mac-mac10.12/virtual/video-surface-layer/media/video-empty-source-expected.png
[modify] https://crrev.com/99e423eea795710e141aa99d5ba18bd1648ae892/third_party/WebKit/LayoutTests/platform/mac-mac10.12/virtual/video-surface-layer/media/video-zoom-controls-expected.png
[modify] https://crrev.com/99e423eea795710e141aa99d5ba18bd1648ae892/third_party/WebKit/LayoutTests/platform/mac/compositing/video/video-controls-layer-creation-expected.png
[modify] https://crrev.com/99e423eea795710e141aa99d5ba18bd1648ae892/third_party/WebKit/LayoutTests/platform/mac/fast/overflow/overflow-of-video-outline-expected.png
[modify] https://crrev.com/99e423eea795710e141aa99d5ba18bd1648ae892/third_party/WebKit/LayoutTests/platform/mac/media/controls-after-reload-expected.png
[modify] https://crrev.com/99e423eea795710e141aa99d5ba18bd1648ae892/third_party/WebKit/LayoutTests/platform/mac/media/controls-after-reload-expected.txt
[modify] https://crrev.com/99e423eea795710e141aa99d5ba18bd1648ae892/third_party/WebKit/LayoutTests/platform/mac/media/controls-layout-direction-expected.png
[modify] https://crrev.com/99e423eea795710e141aa99d5ba18bd1648ae892/third_party/WebKit/LayoutTests/platform/mac/media/controls-strict-expected.png
[modify] https://crrev.com/99e423eea795710e141aa99d5ba18bd1648ae892/third_party/WebKit/LayoutTests/platform/mac/media/controls-strict-expected.txt
[modify] https://crrev.com/99e423eea795710e141aa99d5ba18bd1648ae892/third_party/WebKit/LayoutTests/platform/mac/media/controls-styling-expected.png
[modify] https://crrev.com/99e423eea795710e141aa99d5ba18bd1648ae892/third_party/WebKit/LayoutTests/platform/mac/media/controls-styling-expected.txt
[modify] https://crrev.com/99e423eea795710e141aa99d5ba18bd1648ae892/third_party/WebKit/LayoutTests/platform/mac/media/controls-styling-strict-expected.png
[modify] https://crrev.com/99e423eea795710e141aa99d5ba18bd1648ae892/third_party/WebKit/LayoutTests/platform/mac/media/controls-styling-strict-expected.txt
[modify] https://crrev.com/99e423eea795710e141aa99d5ba18bd1648ae892/third_party/WebKit/LayoutTests/platform/mac/media/controls-without-preload-expected.png
[modify] https://crrev.com/99e423eea795710e141aa99d5ba18bd1648ae892/third_party/WebKit/LayoutTests/platform/mac/media/controls-without-preload-expected.txt
[modify] https://crrev.com/99e423eea795710e141aa99d5ba18bd1648ae892/third_party/WebKit/LayoutTests/platform/mac/media/controls/lazy-lo

Comment 2 by steimel@chromium.org, Sep 20 

Note that everything is done in the CL above except #4. I want to wait to see our plan for handling the overlay play button on desktop (since if we remove the button on desktop this is essentially moot)

Comment 3 by steimel@chromium.org, Oct 15

Status: Fixed (was: Started)
►

Sign in to add a comment