New issue
Advanced search Search tips

Issue 884924 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Sep 19
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug

Blocking:
issue 806146



Sign in to add a comment

measure_power.py fail

Project Member Reported by mqg@chromium.org, Sep 17

Issue description

self.PREMATURE_RETRIEVAL_WARNING doesn't exist, should be PREMATURE_RETRIEVAL_MSG.

 
Project Member

Comment 1 by bugdroid1@chromium.org, Sep 18

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/hdctools/+/cc046d0ad7ff72d83a82b3ffd8a69be3961af613

commit cc046d0ad7ff72d83a82b3ffd8a69be3961af613
Author: Ruben Rodriguez Buchillon <coconutruben@chromium.org>
Date: Tue Sep 18 21:04:08 2018

servod: fix measure_power warning msg issue

This fixes an issue where a variable name change was not carried out all
the way.

BUG= chromium:884924 
TEST=manual test, commenting out the line 437: processing_done = True

Change-Id: I0e322f9ac890a81bde12393103dc6a296056996e
Signed-off-by: Ruben Rodriguez Buchillon <coconutruben@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/1229533
Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com>
Reviewed-by: Mengqi Guo <mqg@chromium.org>

[modify] https://crrev.com/cc046d0ad7ff72d83a82b3ffd8a69be3961af613/servo/measure_power.py

Status: Fixed (was: Untriaged)
Project Member

Comment 3 by bugdroid1@chromium.org, Sep 21

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/hdctools/+/863ecb0cfc0bc5de8af1015fd090c14a93d2919e

commit 863ecb0cfc0bc5de8af1015fd090c14a93d2919e
Author: Mengqi Guo <mqg@chromium.org>
Date: Fri Sep 21 04:30:12 2018

servod: fix measure_power warning msg issue for GetSummary

This fixes an issue where a variable name change was not carried out all
the way. Everything was fixed except newly added method GetSummary.

BUG= chromium:884924 
TEST=manual test, commenting out the line 437: processing_done = True

Change-Id: I4e4f72d850f05953b92bfe5af248830b7b02c9a7
Signed-off-by: Mengqi Guo <mqg@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/1234456
Reviewed-by: Puthikorn Voravootivat <puthik@chromium.org>

[modify] https://crrev.com/863ecb0cfc0bc5de8af1015fd090c14a93d2919e/servo/measure_power.py

Sign in to add a comment