New issue
Advanced search Search tips

Issue 884919 link

Starred by 1 user
Status: Available
Owner:
jianli@chromium.org
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug



Sign in to add a comment

Offline indicator still shown after signing into captive portal for Marshmallow+

Project Member Reported by jianli@chromium.org, Sep 17 
Chrome Version: Latest canary
OS: Android Marshmallow+

What steps will reproduce the problem?
(1) Enable Offline Indicator feature in about:flags
(2) Connect to a WIFI that imposes captive portal. Do not sign-in or acknowledge in the landing page.
(3) Start chrome. Offline indicator is shown.
(4) Sign-in or acknowledge in the landing page.
(5) Return to Chrome

What is the expected result?
The offline indicator should go away.

What happens instead?
The offline indicator is still shown.
Project Member

Comment 1 by bugdroid1@chromium.org, Oct 9 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b40cc27c432c613376eabbc724ef56273f7b7d34

commit b40cc27c432c613376eabbc724ef56273f7b7d34
Author: Jian Li <jianli@chromium.org>
Date: Tue Oct 09 23:24:23 2018

Improve connectivity detection logic for offline indicator

When we retrieve the connectivity info from the system, we should
get it again when chrome app is foreground and detect() is called
because the system may validate the network at any time. We should
alsp keep retrying with backoff.

Bug: 889252,884919
Change-Id: I1aa8a1b00c52514c60297fe7b03e561d1dd9f8c4
Reviewed-on: https://chromium-review.googlesource.com/c/1257657
Commit-Queue: Jian Li <jianli@chromium.org>
Reviewed-by: Peter Williamson <petewil@chromium.org>
Cr-Commit-Position: refs/heads/master@{#598131}
[modify] https://crrev.com/b40cc27c432c613376eabbc724ef56273f7b7d34/chrome/android/java/src/org/chromium/chrome/browser/offlinepages/indicator/ConnectivityDetector.java
[modify] https://crrev.com/b40cc27c432c613376eabbc724ef56273f7b7d34/chrome/android/java_sources.gni
[add] https://crrev.com/b40cc27c432c613376eabbc724ef56273f7b7d34/chrome/android/javatests/src/org/chromium/chrome/browser/offlinepages/indicator/ConnectivityDetectorDelegateStub.java
[modify] https://crrev.com/b40cc27c432c613376eabbc724ef56273f7b7d34/chrome/android/javatests/src/org/chromium/chrome/browser/offlinepages/indicator/ConnectivityDetectorTest.java
[modify] https://crrev.com/b40cc27c432c613376eabbc724ef56273f7b7d34/chrome/android/javatests/src/org/chromium/chrome/browser/offlinepages/indicator/OfflineIndicatorControllerTest.java
►

Sign in to add a comment