New issue
Advanced search Search tips

Issue 884899 link

Starred by 1 user
Status: Fixed
Owner:
johnidel@chromium.org
Closed: Oct 25
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Measure ad data use of videos using MSE.

Project Member Reported by johnidel@chromium.org, Sep 17 
Currently there are no metrics on the amount of data played in videos that are loaded via Media Source Extensions. This data can be loaded arbitrarily in javascript and does not require any specific mime type. This metrics will helps understand how much data is used for loading videos that we are not accounting for.
Project Member

Comment 1 by bugdroid1@chromium.org, Oct 17 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b93339160a4cb20476f98229c98c9147e9816dd4

commit b93339160a4cb20476f98229c98c9147e9816dd4
Author: John Delaney <johnidel@chromium.org>
Date: Wed Oct 17 21:50:47 2018

Measure media bytes received for MSE/EME/SRC

Currently we are not capturing bytes received by HTML5 media using Media
Source Extensions. The metrics capturing bytes received for SRC are not
reliably reported. These are desirable metrics for measuring impact of any
feature targeting video data usage.


Bug:  884899 
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: I5892630c60fb635994bb2faffc36ef4dc3ba56d4
Reviewed-on: https://chromium-review.googlesource.com/c/1229213
Commit-Queue: John Delaney <johnidel@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Reviewed-by: Mustafa Emre Acer <meacer@chromium.org>
Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Reviewed-by: Fredrik Hubinette <hubbe@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600568}
[modify] https://crrev.com/b93339160a4cb20476f98229c98c9147e9816dd4/media/blink/url_index.cc
[modify] https://crrev.com/b93339160a4cb20476f98229c98c9147e9816dd4/media/blink/url_index.h
[modify] https://crrev.com/b93339160a4cb20476f98229c98c9147e9816dd4/media/blink/watch_time_reporter_unittest.cc
[modify] https://crrev.com/b93339160a4cb20476f98229c98c9147e9816dd4/media/blink/webmediaplayer_impl.cc
[modify] https://crrev.com/b93339160a4cb20476f98229c98c9147e9816dd4/media/blink/webmediaplayer_impl.h
[modify] https://crrev.com/b93339160a4cb20476f98229c98c9147e9816dd4/media/filters/chunk_demuxer.cc
[modify] https://crrev.com/b93339160a4cb20476f98229c98c9147e9816dd4/media/filters/chunk_demuxer.h
[modify] https://crrev.com/b93339160a4cb20476f98229c98c9147e9816dd4/media/mojo/interfaces/media_metrics_provider.mojom
[modify] https://crrev.com/b93339160a4cb20476f98229c98c9147e9816dd4/media/mojo/services/media_metrics_provider.cc
[modify] https://crrev.com/b93339160a4cb20476f98229c98c9147e9816dd4/media/mojo/services/media_metrics_provider.h
[modify] https://crrev.com/b93339160a4cb20476f98229c98c9147e9816dd4/tools/metrics/histograms/histograms.xml
Project Member

Comment 2 by bugdroid1@chromium.org, Oct 21 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6c8ecc1b427efdbdfc462a00ab7d95afc51768ec

commit 6c8ecc1b427efdbdfc462a00ab7d95afc51768ec
Author: John Delaney <johnidel@chromium.org>
Date: Sun Oct 21 19:07:29 2018

Measure media bytes received for ad subframes

Record the Media.BytesRecevied metrics separately for media players
contained in ad subframes. Currently, there is no metric capturing the
amount of bytes used to load ad videos via MSE. These metrics are useful
for measuring impact of any ad interventions targeting video playback.

Bug:  884899 
Change-Id: I95a519d2f7393103b5e67d5bed4bf9217a4b2f99
Reviewed-on: https://chromium-review.googlesource.com/c/1288855
Commit-Queue: John Delaney <johnidel@chromium.org>
Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Reviewed-by: Robert Sesek <rsesek@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Cr-Commit-Position: refs/heads/master@{#601456}
[modify] https://crrev.com/6c8ecc1b427efdbdfc462a00ab7d95afc51768ec/media/blink/watch_time_reporter_unittest.cc
[modify] https://crrev.com/6c8ecc1b427efdbdfc462a00ab7d95afc51768ec/media/blink/webmediaplayer_impl.cc
[modify] https://crrev.com/6c8ecc1b427efdbdfc462a00ab7d95afc51768ec/media/mojo/interfaces/media_metrics_provider.mojom
[modify] https://crrev.com/6c8ecc1b427efdbdfc462a00ab7d95afc51768ec/media/mojo/services/media_metrics_provider.cc
[modify] https://crrev.com/6c8ecc1b427efdbdfc462a00ab7d95afc51768ec/media/mojo/services/media_metrics_provider.h
[modify] https://crrev.com/6c8ecc1b427efdbdfc462a00ab7d95afc51768ec/media/mojo/services/media_metrics_provider_unittest.cc
[modify] https://crrev.com/6c8ecc1b427efdbdfc462a00ab7d95afc51768ec/tools/metrics/histograms/histograms.xml

Comment 3 by johnidel@chromium.org, Oct 25

Status: Fixed (was: Assigned)
►

Sign in to add a comment