New issue
Advanced search Search tips

Issue 884893 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Sep 20
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug

Blocking:
issue 879967



Sign in to add a comment

adhd is failing unit tests in amd64-generic-asan builder

Project Member Reported by manojgupta@chromium.org, Sep 17

Issue description

https://cros-goldeneye.corp.google.com/chromeos/healthmonitoring/buildDetails?buildbucketId=8935126457585675616

adhd-0.0.1-r1574:  * ASAN error detected:
adhd-0.0.1-r1574:  * 
adhd-0.0.1-r1574:  * =================================================================
adhd-0.0.1-r1574:  * ==24972==ERROR: LeakSanitizer: detected memory leaks
adhd-0.0.1-r1574:  * 
adhd-0.0.1-r1574:  * Direct leak of 9 byte(s) in 1 object(s) allocated from:
adhd-0.0.1-r1574:  *     #0 0x7fac332bed8d in __interceptor_strdup (/build/amd64-generic/tmp/portage/media-sound/adhd-0.0.1-r1574/work/adhd-0.0.1/cras/src/alsa_ucm_unittest+0xb8d8d)
adhd-0.0.1-r1574:  *     #1 0x7fac3330ec44 in snd_use_case_get /build/amd64-generic/tmp/portage/media-sound/adhd-0.0.1-r1574/work/adhd-0.0.1/cras/src/tests/alsa_ucm_unittest.cc:1473:12
adhd-0.0.1-r1574:  *     #2 0x7fac333074b5 in get_var(cras_use_case_mgr*, char const*, char const*, char const*, char const**) /build/amd64-generic/tmp/portage/media-sound/adhd-0.0.1-r1574/work/adhd-0.0.1/cras/src/../src/server/cras_alsa_ucm.c:137:7
adhd-0.0.1-r1574:  *     #3 0x7fac33325276 in ucm_get_echo_reference_dev_name_for_dev /build/amd64-generic/tmp/portage/media-sound/adhd-0.0.1-r1574/work/adhd-0.0.1/cras/src/../src/server/cras_alsa_ucm.c:728:7
adhd-0.0.1-r1574:  *     #4 0x7fac33325276 in (anonymous namespace)::AlsaUcm_GetEchoReferenceDev_Test::TestBody() /build/amd64-generic/tmp/portage/media-sound/adhd-0.0.1-r1574/work/adhd-0.0.1/cras/src/tests/alsa_ucm_unittest.cc:471
adhd-0.0.1-r1574:  *     #5 0x7fac331c4f93 in void testing::internal::HandleSehExceptionsInMethodIfSupported<testing::Test, void>(testing::Test*, void (testing::Test::*)(), char const*) /build/amd64-generic/tmp/portage/dev-cpp/gtest-1.8.0-r1/work/googletest-release-1.8.0/googletest-abi_x86_64.amd64/./src/gtest.cc:2402:10
adhd-0.0.1-r1574:  *     #6 0x7fac331c4f93 in void testing::internal::HandleExceptionsInMethodIfSupported<testing::Test, void>(testing::Test*, void (testing::Test::*)(), char const*) /build/amd64-generic/tmp/portage/dev-cpp/gtest-1.8.0-r1/work/googletest-release-1.8.0/googletest-abi_x86_64.amd64/./src/gtest.cc:2438
adhd-0.0.1-r1574:  *     #7 0x7fac331ab6a0 in testing::Test::Run() /build/amd64-generic/tmp/portage/dev-cpp/gtest-1.8.0-r1/work/googletest-release-1.8.0/googletest-abi_x86_64.amd64/./src/gtest.cc:2474:5
adhd-0.0.1-r1574:  *     #8 0x7fac331ac5ff in testing::TestInfo::Run() /build/amd64-generic/tmp/portage/dev-cpp/gtest-1.8.0-r1/work/googletest-release-1.8.0/googletest-abi_x86_64.amd64/./src/gtest.cc:2656:11
adhd-0.0.1-r1574:  *     #9 0x7fac331acc86 in testing::TestCase::Run() /build/amd64-generic/tmp/portage/dev-cpp/gtest-1.8.0-r1/work/googletest-release-1.8.0/googletest-abi_x86_64.amd64/./src/gtest.cc:2774:28
adhd-0.0.1-r1574:  *     #10 0x7fac331b57e6 in testing::internal::UnitTestImpl::RunAllTests() /build/amd64-generic/tmp/portage/dev-cpp/gtest-1.8.0-r1/work/googletest-release-1.8.0/googletest-abi_x86_64.amd64/./src/gtest.cc:4649:43
adhd-0.0.1-r1574:  *     #11 0x7fac331c5ab3 in bool testing::internal::HandleSehExceptionsInMethodIfSupported<testing::internal::UnitTestImpl, bool>(testing::internal::UnitTestImpl*, bool (testing::internal::UnitTestImpl::*)(), char const*) /build/amd64-generic/tmp/portage/dev-cpp/gtest-1.8.0-r1/work/googletest-release-1.8.0/googletest-abi_x86_64.amd64/./src/gtest.cc:2402:10
adhd-0.0.1-r1574:  *     #12 0x7fac331c5ab3 in bool testing::internal::HandleExceptionsInMethodIfSupported<testing::internal::UnitTestImpl, bool>(testing::internal::UnitTestImpl*, bool (testing::internal::UnitTestImpl::*)(), char const*) /build/amd64-generic/tmp/portage/dev-cpp/gtest-1.8.0-r1/work/googletest-release-1.8.0/googletest-abi_x86_64.amd64/./src/gtest.cc:2438
adhd-0.0.1-r1574:  *     #13 0x7fac331b539e in testing::UnitTest::Run() /build/amd64-generic/tmp/portage/dev-cpp/gtest-1.8.0-r1/work/googletest-release-1.8.0/googletest-abi_x86_64.amd64/./src/gtest.cc:4257:10
adhd-0.0.1-r1574:  *     #14 0x7fac3330f106 in RUN_ALL_TESTS() /build/amd64-generic/tmp/portage/media-sound/adhd-0.0.1-r1574/work/adhd-0.0.1/cras/src/../../../../../../../../usr/include/gtest/gtest.h:2233:46
adhd-0.0.1-r1574:  *     #15 0x7fac3330f106 in main /build/amd64-generic/tmp/portage/media-sound/adhd-0.0.1-r1574/work/adhd-0.0.1/cras/src/tests/alsa_ucm_unittest.cc:1505
adhd-0.0.1-r1574:  *     #16 0x7fac3225c72f in __libc_start_main (/lib64/libc.so.6+0x2072f)
adhd-0.0.1-r1574:  * 
adhd-0.0.1-r1574:  * SUMMARY: AddressSanitizer: 9 byte(s) leaked in 1 allocation(s).
adhd-0.0.1-r1574: 
adhd-0.0.1-r1574: >>> Failed to emerge media-sound/adhd-0.0.1-r1574 for /build/amd64-generic/, Log file:
adhd-0.0.1-r1574: >>>  '/build/amd64-generic/tmp/portage/logs/media-sound:adhd-0.0.1-r1574:20180917-164023.log'
adhd-0.0.1-r1574: 
adhd-0.0.1-r1574:  * Messages for package media-sound/adhd-0.0.1-r1574 merged to /build/amd64-generic/:
adhd-0.0.1-r1574: 
adhd-0.0.1-r1574:  * ERROR: media-sound/adhd-0.0.1-r1574::chromiumos failed (test phase):
adhd-0.0.1-r1574:  *   emake failed
 
Status: Assigned (was: Untriaged)
Cc: dgreid@chromium.org cychiang@chromium.org
This first appeared here:
https://cros-goldeneye.corp.google.com/chromeos/healthmonitoring/buildDetails?id=2943276

Bad Version:  R71-11067.0.0-b2943276
Good Version: R71-11066.0.0-b2942607

CrOS changes:
https://crosland.corp.google.com/log/11066.0.0..11067.0.0

adhd changes:

src/third_party/adhd
10d579e5	1180783	879967	Mon Sep 03 07:36:31 2018	hychao@google.com	CRAS: iodev_list - open server stream to activate echo reference
536c28ee	1212623	879967	Fri Sep 07 02:44:44 2018	hychao@google.com	CRAS: system_state - Add task support
a3509d54	1180782	879967	Mon Aug 13 02:43:16 2018	hychao@chromium.org	CRAS: alsa_ucm - label to specify echo reference iodev
Blocking: 879967
Project Member

Comment 4 by bugdroid1@chromium.org, Sep 19

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/adhd/+/81fdac505005f2d88d9d8b0d3bfb8b896dc52bf9

commit 81fdac505005f2d88d9d8b0d3bfb8b896dc52bf9
Author: Hsin-Yu Chao <hychao@google.com>
Date: Wed Sep 19 15:59:39 2018

CRAS: alsa_ucm - Free echo ref dev name

Echo ref dev name returned from UCM manager should
be freed by caller. Fix it in a few places.

BUG= chromium:884893 
TEST=USE=asan FEATURES=test emerge-nocturne adhd

Change-Id: I6f905a501d62c9019f460fba56232dca61016a34
Reviewed-on: https://chromium-review.googlesource.com/1229795
Commit-Ready: Hsinyu Chao <hychao@chromium.org>
Tested-by: Hsinyu Chao <hychao@chromium.org>
Reviewed-by: Cheng-Yi Chiang <cychiang@chromium.org>
Reviewed-by: Dylan Reid <dgreid@chromium.org>

[modify] https://crrev.com/81fdac505005f2d88d9d8b0d3bfb8b896dc52bf9/cras/src/tests/alsa_card_unittest.cc
[modify] https://crrev.com/81fdac505005f2d88d9d8b0d3bfb8b896dc52bf9/cras/src/tests/alsa_ucm_unittest.cc
[modify] https://crrev.com/81fdac505005f2d88d9d8b0d3bfb8b896dc52bf9/cras/src/server/cras_alsa_card.c
[modify] https://crrev.com/81fdac505005f2d88d9d8b0d3bfb8b896dc52bf9/cras/src/server/cras_alsa_ucm.h

Status: Verified (was: Assigned)
Project Member

Comment 6 by bugdroid1@chromium.org, Sep 25

Labels: merge-merged-release-R70-11021.B
The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/adhd/+/7e0bd0b92f672b975180144051ab21900a6917cd

commit 7e0bd0b92f672b975180144051ab21900a6917cd
Author: Hsin-Yu Chao <hychao@google.com>
Date: Tue Sep 25 02:58:03 2018

CRAS: alsa_ucm - Free echo ref dev name

Echo ref dev name returned from UCM manager should
be freed by caller. Fix it in a few places.

BUG= chromium:884893 
TEST=USE=asan FEATURES=test emerge-nocturne adhd

Change-Id: I6f905a501d62c9019f460fba56232dca61016a34
Reviewed-on: https://chromium-review.googlesource.com/1229795
Commit-Ready: Hsinyu Chao <hychao@chromium.org>
Tested-by: Hsinyu Chao <hychao@chromium.org>
Reviewed-by: Cheng-Yi Chiang <cychiang@chromium.org>
Reviewed-by: Dylan Reid <dgreid@chromium.org>
(cherry picked from commit 81fdac505005f2d88d9d8b0d3bfb8b896dc52bf9)
Reviewed-on: https://chromium-review.googlesource.com/1242498
Reviewed-by: Hsinyu Chao <hychao@chromium.org>
Commit-Queue: Hsinyu Chao <hychao@chromium.org>

[modify] https://crrev.com/7e0bd0b92f672b975180144051ab21900a6917cd/cras/src/tests/alsa_card_unittest.cc
[modify] https://crrev.com/7e0bd0b92f672b975180144051ab21900a6917cd/cras/src/tests/alsa_ucm_unittest.cc
[modify] https://crrev.com/7e0bd0b92f672b975180144051ab21900a6917cd/cras/src/server/cras_alsa_card.c
[modify] https://crrev.com/7e0bd0b92f672b975180144051ab21900a6917cd/cras/src/server/cras_alsa_ucm.h

Sign in to add a comment