New issue
Advanced search Search tips

Issue 884891 link

Starred by 1 user
Status: Fixed
Merged: issue 884783
Owner: ----
Closed: Sep 17
Cc:
atotic@chromium.org
robertma@chromium.org
khushals...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Results.html giving error "Uncaught TypeError: this.file.match"

Project Member Reported by pdr@chromium.org, Sep 17 
The webkit layout test results page is throwing the following error when you click the "Did not pass" button:
--------------8<--------------
results.html:456 Uncaught TypeError: this.file.match is not a function or its return value is not iterable
    at new PathParser (results.html:456)
    at printPlainTest (results.html:534)
    at Traversal._helper (results.html:436)
    at Traversal._helper (results.html:440)
    at Traversal._helper (results.html:440)
    at Traversal._helper (results.html:440)
    at Traversal._helper (results.html:440)
    at Traversal._helper (results.html:440)
    at Traversal.traverse (results.html:419)
    at window.setTimeout._ (results.html:948)
--------------8<--------------

https://test-results.appspot.com/data/layout_results/linux-blink-rel/882/layout-test-results/results.html

This file has not changed in a long time so it's not clear to me if this is new. This could be the related to  https://crbug.com/884860 .

Comment 1 by robertma@chromium.org, Sep 17 

This is likely related to  issue 884783 . The result JSON is now almost
empty. Can you mark as dupe? (I'm replying from my phone.) Thanks.

Comment 2 by pdr@chromium.org, Sep 17

Mergedinto: 884783
Status: Duplicate (was: Untriaged)
Project Member

Comment 3 by bugdroid1@chromium.org, Sep 18 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e518f9a2a14d28355e6714d4dc84c2598390afba

commit e518f9a2a14d28355e6714d4dc84c2598390afba
Author: Aleks Totic <atotic@chromium.org>
Date: Tue Sep 18 01:19:23 2018

[LayoutTestResults] Catch corrupt input failure

Did not deal correctly with tests with blank names:
 "object-src": {
            "": { <= BLANK NAME WAS HERE.
              "actual": "SKIP",
              "bugs": [
                "crbug.com/694525"
              ],
              "expected": "SKIP"
            }
          },

Bug:  884891 
Change-Id: I5f2f490d0f0dd3db8520afc5268aa929753bad90
Reviewed-on: https://chromium-review.googlesource.com/1229414
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Aleks Totic <atotic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#591907}
[modify] https://crrev.com/e518f9a2a14d28355e6714d4dc84c2598390afba/third_party/WebKit/LayoutTests/fast/harness/results.html

Comment 4 by atotic@chromium.org, Sep 18

Status: Fixed (was: Duplicate)
►

Sign in to add a comment