New issue
Advanced search Search tips

Issue 884875 link

Starred by 1 user
Status: Fixed
Owner:
tiborg@chromium.org
Closed: Sep 26
Cc:
benmason@chromium.org
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Task



Sign in to add a comment

AR / VR-DFM: Add compile flag to conditionally package AR / VR into a module

Project Member Reported by tiborg@chromium.org, Sep 17 
It is not certain yet that the AR / VR DFMs will be ready by the time we want to switch to bundles. Therefore, add GN arg that lets us configure whether AR / VR are put into the base module or into a feature module.
Project Member

Comment 1 by bugdroid1@chromium.org, Sep 21 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8c7b385bf04cc07e278e0bc60dd95e2ab01d58a9

commit 8c7b385bf04cc07e278e0bc60dd95e2ab01d58a9
Author: Tibor Goldschwendt <tiborg@chromium.org>
Date: Fri Sep 21 20:22:56 2018

[ar/vr] Add flag to disable modularization of AR / VR

Bug:  884875 
Cq-Include-Trybots: luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: I402201609f98425169c56983aafb108bb76cb406
Reviewed-on: https://chromium-review.googlesource.com/1238817
Reviewed-by: agrieve <agrieve@chromium.org>
Reviewed-by: Bill Orr <billorr@chromium.org>
Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#593319}
[modify] https://crrev.com/8c7b385bf04cc07e278e0bc60dd95e2ab01d58a9/chrome/android/BUILD.gn
[modify] https://crrev.com/8c7b385bf04cc07e278e0bc60dd95e2ab01d58a9/chrome/android/chrome_public_apk_tmpl.gni
[modify] https://crrev.com/8c7b385bf04cc07e278e0bc60dd95e2ab01d58a9/chrome/android/modules/ar/ar_module_tmpl.gni
[modify] https://crrev.com/8c7b385bf04cc07e278e0bc60dd95e2ab01d58a9/chrome/android/modules/vr/vr_module_tmpl.gni
[modify] https://crrev.com/8c7b385bf04cc07e278e0bc60dd95e2ab01d58a9/device/vr/buildflags/buildflags.gni

Comment 2 by tiborg@chromium.org, Sep 24

Status: Fixed (was: Assigned)

Comment 3 by tiborg@chromium.org, Sep 26

Status: Started (was: Fixed)
Missed downstream
Project Member

Comment 4 by bugdroid1@chromium.org, Sep 26 

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/clank/internal/apps/+/c787d28dcd2b2ef4df67c234cdd417a51395ee22

commit c787d28dcd2b2ef4df67c234cdd417a51395ee22
Author: Tibor Goldschwendt <tiborg@google.com>
Date: Wed Sep 26 20:48:21 2018

Comment 5 by tiborg@chromium.org, Sep 26

Status: Fixed (was: Started)
►

Sign in to add a comment