New issue
Advanced search Search tips

Issue 884861 link

Starred by 1 user
Status: Fixed
Owner:
siyua@chromium.org
Closed: Oct 4
Cc:
dlkumar@google.com
jiahuiguo@chromium.org
se...@chromium.org
jsaul@google.com
ma...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 1
Type: Bug



Sign in to add a comment

[Merge Request M70] Fix migratable_credit_cards reference passing

Project Member Reported by siyua@chromium.org, Sep 17 
Requesting to merge CL https://chromium-review.googlesource.com/c/chromium/src/+/1205105 into M70.

Have manually tested in Canary successfully. The whole flow is protected by Finch flag (https://cs.chromium.org/chromium/src/components/autofill/core/common/autofill_features.cc?l=46-47&rcl=49f19b63fd8b172ef07213efe9ec510f5a9732f5).

Attached a screenshot of the test result in Canary. The two cards in circle are browser-saved cards before migration. During migration, only selected the visa card ending with 9430. And when migration was finished, only the selected card pointed by the arrow was uploaded to Google Payments.
MergeRequest.png
101 KB View Download
Project Member

Comment 1 by sheriffbot@chromium.org, Sep 17

Labels: -Merge-Request-70 Merge-Review-70 Hotlist-Merge-Review
This bug requires manual review: M70 has already been promoted to the beta branch, so this requires manual review
Please contact the milestone owner if you have questions.
Owners: benmason@(Android), kariahda@(iOS), geohsu@(ChromeOS), abdulsyed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 2 by abdulsyed@chromium.org, Sep 17 

This is a huge change. Why is this required for M70, vs waiting until M71?

Comment 3 by abdulsyed@chromium.org, Sep 17

Labels: -Merge-Review-70 Merge-Rejected-70
Please provide clear justification why this is an absolutely critical change that can't wait until M71.

Comment 4 by siyua@chromium.org, Sep 17 

Here is the design doc: go/ib-paradise.

This CL fixes the bug that no matter if the users has checked/unchecked the checkboxes on UI, the migration flow would upload all browser-saved credit cards, which would a hard blocker for the whole project. 

This CL contains changes only related to the migration flow. It does not touch any other existing stuff. And the migration flow is protected by the Finch flag.

Comment 5 by jiahuiguo@chromium.org, Oct 4

Status: Fixed (was: Assigned)
Mark this as closed as we will launch in M71.
►

Sign in to add a comment