New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 884855 link

Starred by 1 user
Status: Assigned
Owner:
hinoka@chromium.org
Cc:
hinoka@chromium.org
tandrii@chromium.org
no...@chromium.org
iannu...@google.com
█ smut@chromium.org
efoo@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

Milo exposes Logdog 500s to users

Project Member Reported by efoo@chromium.org, Sep 17 
As part of production weekly (18-09-10), it was discussed that Milo should NOT expose LogDog 500 errors directly to the user. 

Background: 
LuciMilo5xxRateHigh was alerted due to retry threshold being reached due to Milo unable to contact LogDog. Milo would then expose LogDog 500 to user. 

There are 2 issues here: 
1. LogDog output error code should not be a 500.
2. Milo should not expose an internal server side error code to user. 

This is a master bug to track this.

Comment 1 by efoo@chromium.org, Sep 17

Owner: hinoka@chromium.org
Status: Assigned (was: Available)
Assigning to Ryan to comment as per discussion.

Comment 2 by hinoka@chromium.org, Sep 17 

Our conclusion was:

1. LogDog shouldn't have been serving 500's for lost logs.  It should've been 410 gone.
2. A 500 in LogDog should be propagated as 503 in Milo.

Comment 3 by iannu...@google.com, Oct 18

Cc: iannu...@google.com

Comment 4 by iannu...@google.com, Oct 18

Cc: -iannucci@chromium.org
►

Sign in to add a comment