New issue
Advanced search Search tips

Issue 884837 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Nov 5
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Feature

Blocking:
issue 914423



Sign in to add a comment

Parse IEEM sitelist

Project Member Reported by nicolaso@chromium.org, Sep 17

Issue description

We should have a setting to use the IEEM sitelist in BrowserSwitcher. When enabled, it should download & parse the XML sitelist used by IEEM and use it as an additional sitelist.

Reference implementation:
https://github.com/LegacyBrowserSupport/legacy-browser-support/blob/master/core/ieem_site_list_parser.h
 
Project Member

Comment 1 by bugdroid1@chromium.org, Sep 25

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5198eaca71f9931423a4eabb3cd8c59acf34b732

commit 5198eaca71f9931423a4eabb3cd8c59acf34b732
Author: Nicolas Ouellet-Payeur <nicolaso@chromium.org>
Date: Tue Sep 25 14:44:12 2018

[BrowserSwitcher] Add parser for IEEM schema v.1 sitelists

It uses functions from |safe_xml_parser.h| to parse the raw XML string,
then extracts the sitelist as a list of strings.

Note that this change only adds support for _parsing_ the IEEM sitelist,
but not for _downloading_ it, so this still needs more work.

Bug:  884837 
Change-Id: I6669c22c1127a2fe9f766ad1941777b1f90e633b
Reviewed-on: https://chromium-review.googlesource.com/1234329
Reviewed-by: Julian Pastarmov <pastarmovj@chromium.org>
Commit-Queue: Nicolas Ouellet-Payeur <nicolaso@chromium.org>
Cr-Commit-Position: refs/heads/master@{#593926}
[modify] https://crrev.com/5198eaca71f9931423a4eabb3cd8c59acf34b732/chrome/browser/BUILD.gn
[add] https://crrev.com/5198eaca71f9931423a4eabb3cd8c59acf34b732/chrome/browser/browser_switcher/ieem_sitelist_parser.cc
[add] https://crrev.com/5198eaca71f9931423a4eabb3cd8c59acf34b732/chrome/browser/browser_switcher/ieem_sitelist_parser.h
[add] https://crrev.com/5198eaca71f9931423a4eabb3cd8c59acf34b732/chrome/browser/browser_switcher/ieem_sitelist_parser_browsertest.cc
[modify] https://crrev.com/5198eaca71f9931423a4eabb3cd8c59acf34b732/chrome/test/BUILD.gn

Project Member

Comment 2 by bugdroid1@chromium.org, Sep 26

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d85df1623f2ddb34c6b1ad796e184d64287f25ae

commit d85df1623f2ddb34c6b1ad796e184d64287f25ae
Author: Nicolas Ouellet-Payeur <nicolaso@chromium.org>
Date: Wed Sep 26 15:20:22 2018

[BrowserSwitcher] Parse IEEM schema v.2

Bug:  884837 
Change-Id: I17ebf4c7563640a6ad2f98477a79ca7440e383e6
Reviewed-on: https://chromium-review.googlesource.com/1243364
Reviewed-by: Julian Pastarmov <pastarmovj@chromium.org>
Commit-Queue: Nicolas Ouellet-Payeur <nicolaso@chromium.org>
Cr-Commit-Position: refs/heads/master@{#594321}
[modify] https://crrev.com/d85df1623f2ddb34c6b1ad796e184d64287f25ae/chrome/browser/browser_switcher/ieem_sitelist_parser.cc
[modify] https://crrev.com/d85df1623f2ddb34c6b1ad796e184d64287f25ae/chrome/browser/browser_switcher/ieem_sitelist_parser_browsertest.cc

Project Member

Comment 3 by bugdroid1@chromium.org, Oct 1

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/15a90436835a78e8438127b866bccb6769325af4

commit 15a90436835a78e8438127b866bccb6769325af4
Author: Nicolas Ouellet-Payeur <nicolaso@chromium.org>
Date: Mon Oct 01 14:46:24 2018

[BrowserSwitcher] Add BrowserSwitcherSitelist::SetIeemSitelist()

This new method can be used to set a second source of rules for
BrowserSwitcherSitelist, in addition to the 'url_list' and
'url_greylist' prefs.

Once the IEEM sitelist download code is ready, we can use this method to
apply the downloaded rules.

Bug:  884837 
Change-Id: I0e6d20a03fb27425dd3e9d7b9fd9b2b9fa19d163
Reviewed-on: https://chromium-review.googlesource.com/1249524
Reviewed-by: Julian Pastarmov <pastarmovj@chromium.org>
Commit-Queue: Nicolas Ouellet-Payeur <nicolaso@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595452}
[modify] https://crrev.com/15a90436835a78e8438127b866bccb6769325af4/chrome/browser/browser_switcher/browser_switcher_navigation_throttle_unittest.cc
[modify] https://crrev.com/15a90436835a78e8438127b866bccb6769325af4/chrome/browser/browser_switcher/browser_switcher_sitelist.cc
[modify] https://crrev.com/15a90436835a78e8438127b866bccb6769325af4/chrome/browser/browser_switcher/browser_switcher_sitelist.h
[modify] https://crrev.com/15a90436835a78e8438127b866bccb6769325af4/chrome/browser/browser_switcher/browser_switcher_sitelist_unittest.cc

Project Member

Comment 4 by bugdroid1@chromium.org, Oct 29

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0637edbd49bc89e86d34c06927d6a4babb050a43

commit 0637edbd49bc89e86d34c06927d6a4babb050a43
Author: Nicolas Ouellet-Payeur <nicolaso@chromium.org>
Date: Mon Oct 29 19:20:51 2018

[BrowserSwitcher] Download IE Enterprise Mode SiteList if configured

Adds the "browser_switcher.use_ie_sitelist" boolean pref. When set to
true, BrowserSwitcherService will download IE's sitelist after 60s.

Once the sitelist XML is downloaded, the rules are parsed and applied.

Bug:  884837 
Change-Id: Ib7a6c374526c56c42265187667ea2d6febc3628b
Reviewed-on: https://chromium-review.googlesource.com/c/1286288
Commit-Queue: Nicolas Ouellet-Payeur <nicolaso@chromium.org>
Reviewed-by: Ramin Halavati <rhalavati@chromium.org>
Reviewed-by: Julian Pastarmov <pastarmovj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603582}
[modify] https://crrev.com/0637edbd49bc89e86d34c06927d6a4babb050a43/chrome/browser/browser_switcher/browser_switcher_prefs.cc
[modify] https://crrev.com/0637edbd49bc89e86d34c06927d6a4babb050a43/chrome/browser/browser_switcher/browser_switcher_prefs.h
[modify] https://crrev.com/0637edbd49bc89e86d34c06927d6a4babb050a43/chrome/browser/browser_switcher/browser_switcher_service.cc
[modify] https://crrev.com/0637edbd49bc89e86d34c06927d6a4babb050a43/chrome/browser/browser_switcher/browser_switcher_service.h
[add] https://crrev.com/0637edbd49bc89e86d34c06927d6a4babb050a43/chrome/browser/browser_switcher/browser_switcher_service_browsertest.cc
[modify] https://crrev.com/0637edbd49bc89e86d34c06927d6a4babb050a43/chrome/browser/browser_switcher/browser_switcher_service_factory.cc
[modify] https://crrev.com/0637edbd49bc89e86d34c06927d6a4babb050a43/chrome/browser/browser_switcher/ieem_sitelist_parser.cc
[modify] https://crrev.com/0637edbd49bc89e86d34c06927d6a4babb050a43/chrome/browser/browser_switcher/ieem_sitelist_parser.h
[modify] https://crrev.com/0637edbd49bc89e86d34c06927d6a4babb050a43/chrome/test/BUILD.gn
[modify] https://crrev.com/0637edbd49bc89e86d34c06927d6a4babb050a43/tools/traffic_annotation/summary/annotations.xml

Status: Verified (was: Started)
Also added policy to control this. See  bug 876805 .

Sign in to add a comment