Restart prompt from RelaunchNotification takes focus |
|||||||||
Issue descriptionChrome Version: 70.0.3538.16 (Official Build) beta (64-bit) OS: Linux What steps will reproduce the problem? (1) Enable the RelaunchNotification = 2 policy so it enforces a reboot X days after an update is available (2) An update is available (3) The user is typing in a text area (Google Doc, Search, etc.) (4) Browser pops up a notification asking you to restart Chrome within X days. The button to restart Chrome now takes focus. (5) User still typing in the text area pushes enter to get to the next line. (6) Chrome restarts without the user perceiving the prompt What is the expected result? User reads the relaunch notification and chooses to reboot or delay until the time runs out at which time it should automatically reboot. What happens instead? I accidentally rebooted Chrome. This could look to users like Chrome "randomly" restarting itself. Suggestion: Not put focus on the Restart button when the prompt shows up
,
Sep 19
Seems reasonable to have nothing focused at the get-go to prevent accidental actions like this. FYI srahim@ in case other consumers of constrained_window::CreateBrowserModalDialogViews should make a similar change. Removing Chrome from the list of platforms, as this dialog isn't used there.
,
Sep 19
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/bf8f4d1ca020c1ae88fb4489c76651b0dfa7573f commit bf8f4d1ca020c1ae88fb4489c76651b0dfa7573f Author: Greg Thompson <grt@chromium.org> Date: Wed Sep 19 18:09:03 2018 Do not focus any buttons in the relaunch required dialog. To prevent users from accidentally restarting or dismissing the dialog if they happen to be typing when it appears. BUG= 884831 R=bsep@chromium.org Change-Id: I91c31bd5b122632a3a2ceb13214aac266dfc6020 Reviewed-on: https://chromium-review.googlesource.com/1233576 Reviewed-by: Bret Sepulveda <bsep@chromium.org> Commit-Queue: Greg Thompson <grt@chromium.org> Cr-Commit-Position: refs/heads/master@{#592473} [modify] https://crrev.com/bf8f4d1ca020c1ae88fb4489c76651b0dfa7573f/chrome/browser/ui/views/relaunch_notification/relaunch_required_dialog_view.cc [modify] https://crrev.com/bf8f4d1ca020c1ae88fb4489c76651b0dfa7573f/chrome/browser/ui/views/relaunch_notification/relaunch_required_dialog_view.h
,
Sep 19
,
Sep 20
nrpeter@, It would be more helpful if you provide us screencast of the issue to reproduce and verify from TE end as per C#0 steps. Thanks in advance!
,
Sep 20
,
Sep 21
Requesting a merge to M70 since this can lead to surprise relaunches, thereby irritating users. The merge is super-safe. I've verified the change with a fresh build at r593109. Thanks.
,
Sep 21
This bug requires manual review: M70 has already been promoted to the beta branch, so this requires manual review Please contact the milestone owner if you have questions. Owners: benmason@(Android), kariahda@(iOS), geohsu@(ChromeOS), abdulsyed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Sep 21
,
Sep 25
nrpeter@/grt@, As per C#5, could you please verify the issue from your end or else please provide us clear screencast of the issue to check from TE end. Thanks in advance!
,
Sep 25
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2a858483c48b54df1318ed6054abe2446bbe2505 commit 2a858483c48b54df1318ed6054abe2446bbe2505 Author: Greg Thompson <grt@chromium.org> Date: Tue Sep 25 13:39:28 2018 Do not focus any buttons in the relaunch required dialog. To prevent users from accidentally restarting or dismissing the dialog if they happen to be typing when it appears. BUG= 884831 R=bsep@chromium.org Change-Id: I91c31bd5b122632a3a2ceb13214aac266dfc6020 Reviewed-on: https://chromium-review.googlesource.com/1233576 Reviewed-by: Bret Sepulveda <bsep@chromium.org> Commit-Queue: Greg Thompson <grt@chromium.org> Cr-Commit-Position: refs/heads/master@{#592473}(cherry picked from commit bf8f4d1ca020c1ae88fb4489c76651b0dfa7573f) TBR=grt@chromium.org Change-Id: I5c63b48ce5d20220dc028b3ad961c90529ace2ba Reviewed-on: https://chromium-review.googlesource.com/1243070 Reviewed-by: Greg Thompson <grt@chromium.org> Cr-Commit-Position: refs/branch-heads/3538@{#651} Cr-Branched-From: 79f7c91a2b2a2932cd447fa6f865cb6662fa8fa6-refs/heads/master@{#587811} [modify] https://crrev.com/2a858483c48b54df1318ed6054abe2446bbe2505/chrome/browser/ui/views/relaunch_notification/relaunch_required_dialog_view.cc [modify] https://crrev.com/2a858483c48b54df1318ed6054abe2446bbe2505/chrome/browser/ui/views/relaunch_notification/relaunch_required_dialog_view.h
,
Sep 25
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2a858483c48b54df1318ed6054abe2446bbe2505 Commit: 2a858483c48b54df1318ed6054abe2446bbe2505 Author: grt@chromium.org Commiter: grt@chromium.org Date: 2018-09-25 13:39:28 +0000 UTC Do not focus any buttons in the relaunch required dialog. To prevent users from accidentally restarting or dismissing the dialog if they happen to be typing when it appears. BUG= 884831 R=bsep@chromium.org Change-Id: I91c31bd5b122632a3a2ceb13214aac266dfc6020 Reviewed-on: https://chromium-review.googlesource.com/1233576 Reviewed-by: Bret Sepulveda <bsep@chromium.org> Commit-Queue: Greg Thompson <grt@chromium.org> Cr-Commit-Position: refs/heads/master@{#592473}(cherry picked from commit bf8f4d1ca020c1ae88fb4489c76651b0dfa7573f) TBR=grt@chromium.org Change-Id: I5c63b48ce5d20220dc028b3ad961c90529ace2ba Reviewed-on: https://chromium-review.googlesource.com/1243070 Reviewed-by: Greg Thompson <grt@chromium.org> Cr-Commit-Position: refs/branch-heads/3538@{#651} Cr-Branched-From: 79f7c91a2b2a2932cd447fa6f865cb6662fa8fa6-refs/heads/master@{#587811}
,
Sep 29
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/82de4f84bb746e41d1be136dbab39c23651def9d commit 82de4f84bb746e41d1be136dbab39c23651def9d Author: Greg Thompson <grt@chromium.org> Date: Sat Sep 29 06:33:31 2018 More documentation on CreateBrowserModalDialogViews. Give a little info about default buttons so that consumers think about whether or not they're a good thing. BUG= 884831 R=pkasting@chromium.org Change-Id: I9f65cfdfc349fb71a270973d416decd5528c8e88 Reviewed-on: https://chromium-review.googlesource.com/1251082 Reviewed-by: Peter Kasting <pkasting@chromium.org> Reviewed-by: Michael Wasserman <msw@chromium.org> Commit-Queue: Greg Thompson <grt@chromium.org> Cr-Commit-Position: refs/heads/master@{#595306} [modify] https://crrev.com/82de4f84bb746e41d1be136dbab39c23651def9d/components/constrained_window/constrained_window_views.h |
|||||||||
►
Sign in to add a comment |
|||||||||
Comment 1 by atwilson@chromium.org
, Sep 19