New issue
Advanced search Search tips

Issue 884817 link

Starred by 1 user
Status: Assigned
Owner:
annelim@google.com
Cc:
dlkumar@google.com
jsaul@google.com
ios-bugs@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , iOS , Chrome , Mac
Pri: 2
Type: Bug



Sign in to add a comment

Implementation bug: Project Traffic Light

Project Member Reported by jsaul@google.com, Sep 17 
This is the implementation bug for Project Traffic Light, also known as Project "Enacting a limit on offering to save the same credit card repeatedly (and creating an infrastructure for other Autofill projects to do similarly)".

Launch bug: http://crbug.com/881116
Project Member

Comment 1 by bugdroid1@chromium.org, Sep 18 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/614a7d915a29db00f8724e81c542ae078f11e18b

commit 614a7d915a29db00f8724e81c542ae078f11e18b
Author: Anne Lim <annelim@google.com>
Date: Tue Sep 18 15:29:17 2018

Added AutofillStrikeDatabase Framework

Added skeleton framework for AutofillStrikeDatabase.
It will be used to store data about the number of times a user
refuses to save their info.

Bug: 884817

Change-Id: Iaffac0ab45785e4c0ff261ecb9bbde31e270e00a
Reviewed-on: https://chromium-review.googlesource.com/1228774
Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Reviewed-by: Jared Saul <jsaul@google.com>
Commit-Queue: Anne Lim <annelim@google.com>
Cr-Commit-Position: refs/heads/master@{#592047}
[modify] https://crrev.com/614a7d915a29db00f8724e81c542ae078f11e18b/chrome/browser/BUILD.gn
[add] https://crrev.com/614a7d915a29db00f8724e81c542ae078f11e18b/chrome/browser/autofill/BUILD.gn
[add] https://crrev.com/614a7d915a29db00f8724e81c542ae078f11e18b/chrome/browser/autofill/strike_data.proto
[add] https://crrev.com/614a7d915a29db00f8724e81c542ae078f11e18b/chrome/browser/autofill/strike_database.cc
[add] https://crrev.com/614a7d915a29db00f8724e81c542ae078f11e18b/chrome/browser/autofill/strike_database.h
Project Member

Comment 2 by bugdroid1@chromium.org, Sep 21 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4183887eee19744f76c81804f78f3cf2b5a26c4d

commit 4183887eee19744f76c81804f78f3cf2b5a26c4d
Author: Anne Lim <annelim@google.com>
Date: Fri Sep 21 18:57:19 2018

[Autofill] StrikeSystem Get/Add/ClearStrikes Architecture

Implemented StrikeSystem Architecture, which includes functions to
Get, Add, and Clear strike count

Bug: 884817
Change-Id: I3d936dd902213646d6bcd84e9a5fbfe8eee4fbea
Reviewed-on: https://chromium-review.googlesource.com/1231988
Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Reviewed-by: Jared Saul <jsaul@google.com>
Commit-Queue: Anne Lim <annelim@google.com>
Cr-Commit-Position: refs/heads/master@{#593280}
[modify] https://crrev.com/4183887eee19744f76c81804f78f3cf2b5a26c4d/chrome/browser/BUILD.gn
[modify] https://crrev.com/4183887eee19744f76c81804f78f3cf2b5a26c4d/chrome/browser/autofill/strike_database.cc
[modify] https://crrev.com/4183887eee19744f76c81804f78f3cf2b5a26c4d/chrome/browser/autofill/strike_database.h
[add] https://crrev.com/4183887eee19744f76c81804f78f3cf2b5a26c4d/chrome/browser/autofill/strike_database_unittest.cc
[add] https://crrev.com/4183887eee19744f76c81804f78f3cf2b5a26c4d/chrome/browser/autofill/test_strike_database.cc
[add] https://crrev.com/4183887eee19744f76c81804f78f3cf2b5a26c4d/chrome/browser/autofill/test_strike_database.h
[modify] https://crrev.com/4183887eee19744f76c81804f78f3cf2b5a26c4d/chrome/test/BUILD.gn
Project Member

Comment 3 by bugdroid1@chromium.org, Oct 5 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c6c35131444ea3b36b7cb0e380cc380e1c43dae5

commit c6c35131444ea3b36b7cb0e380cc380e1c43dae5
Author: Jared Saul <jsaul@google.com>
Date: Fri Oct 05 21:06:19 2018

[Autofill] Create a singleton instance of Autofill StrikeDatabase

Bug: 884817
Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
Change-Id: Ifdf444eab32052a9b84d17a9b21ccf14edb78e52
Reviewed-on: https://chromium-review.googlesource.com/c/1255723
Reviewed-by: Fabio Tirelo <ftirelo@chromium.org>
Reviewed-by: Moe Ahmadi <mahmadi@chromium.org>
Reviewed-by: Richard Coles <torne@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Commit-Queue: Jared Saul <jsaul@google.com>
Cr-Commit-Position: refs/heads/master@{#597289}
[modify] https://crrev.com/c6c35131444ea3b36b7cb0e380cc380e1c43dae5/android_webview/browser/aw_autofill_client.cc
[modify] https://crrev.com/c6c35131444ea3b36b7cb0e380cc380e1c43dae5/android_webview/browser/aw_autofill_client.h
[modify] https://crrev.com/c6c35131444ea3b36b7cb0e380cc380e1c43dae5/chrome/browser/BUILD.gn
[add] https://crrev.com/c6c35131444ea3b36b7cb0e380cc380e1c43dae5/chrome/browser/autofill/strike_database_factory.cc
[add] https://crrev.com/c6c35131444ea3b36b7cb0e380cc380e1c43dae5/chrome/browser/autofill/strike_database_factory.h
[modify] https://crrev.com/c6c35131444ea3b36b7cb0e380cc380e1c43dae5/chrome/browser/ui/autofill/chrome_autofill_client.cc
[modify] https://crrev.com/c6c35131444ea3b36b7cb0e380cc380e1c43dae5/chrome/browser/ui/autofill/chrome_autofill_client.h
[modify] https://crrev.com/c6c35131444ea3b36b7cb0e380cc380e1c43dae5/components/autofill/core/browser/autofill_client.h
[modify] https://crrev.com/c6c35131444ea3b36b7cb0e380cc380e1c43dae5/components/autofill/core/browser/strike_database.h
[modify] https://crrev.com/c6c35131444ea3b36b7cb0e380cc380e1c43dae5/components/autofill/core/browser/test_autofill_client.cc
[modify] https://crrev.com/c6c35131444ea3b36b7cb0e380cc380e1c43dae5/components/autofill/core/browser/test_autofill_client.h
[modify] https://crrev.com/c6c35131444ea3b36b7cb0e380cc380e1c43dae5/ios/chrome/browser/autofill/BUILD.gn
[add] https://crrev.com/c6c35131444ea3b36b7cb0e380cc380e1c43dae5/ios/chrome/browser/autofill/strike_database_factory.cc
[add] https://crrev.com/c6c35131444ea3b36b7cb0e380cc380e1c43dae5/ios/chrome/browser/autofill/strike_database_factory.h
[modify] https://crrev.com/c6c35131444ea3b36b7cb0e380cc380e1c43dae5/ios/chrome/browser/ui/autofill/BUILD.gn
[modify] https://crrev.com/c6c35131444ea3b36b7cb0e380cc380e1c43dae5/ios/chrome/browser/ui/autofill/chrome_autofill_client_ios.h
[modify] https://crrev.com/c6c35131444ea3b36b7cb0e380cc380e1c43dae5/ios/chrome/browser/ui/autofill/chrome_autofill_client_ios.mm
[modify] https://crrev.com/c6c35131444ea3b36b7cb0e380cc380e1c43dae5/ios/web_view/BUILD.gn
[modify] https://crrev.com/c6c35131444ea3b36b7cb0e380cc380e1c43dae5/ios/web_view/internal/autofill/cwv_autofill_controller.mm
[modify] https://crrev.com/c6c35131444ea3b36b7cb0e380cc380e1c43dae5/ios/web_view/internal/autofill/web_view_autofill_client_ios.h
[modify] https://crrev.com/c6c35131444ea3b36b7cb0e380cc380e1c43dae5/ios/web_view/internal/autofill/web_view_autofill_client_ios.mm
[add] https://crrev.com/c6c35131444ea3b36b7cb0e380cc380e1c43dae5/ios/web_view/internal/autofill/web_view_strike_database_factory.cc
[add] https://crrev.com/c6c35131444ea3b36b7cb0e380cc380e1c43dae5/ios/web_view/internal/autofill/web_view_strike_database_factory.h
Project Member

Comment 4 by bugdroid1@chromium.org, Oct 8 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4f4542eae187ee47e39291b9c5f1ac835eb32e6d

commit 4f4542eae187ee47e39291b9c5f1ac835eb32e6d
Author: Jared Saul <jsaul@google.com>
Date: Mon Oct 08 20:08:47 2018

[Autofill] Action post-review comments from 1255723

Bug: 884817
Change-Id: I211273874e90848260c236c15d9bce7f5d70c37a
Reviewed-on: https://chromium-review.googlesource.com/c/1269105
Reviewed-by: Evan Stade <estade@chromium.org>
Commit-Queue: Jared Saul <jsaul@google.com>
Cr-Commit-Position: refs/heads/master@{#597658}
[modify] https://crrev.com/4f4542eae187ee47e39291b9c5f1ac835eb32e6d/chrome/browser/autofill/strike_database_factory.cc
[modify] https://crrev.com/4f4542eae187ee47e39291b9c5f1ac835eb32e6d/chrome/browser/autofill/strike_database_factory.h
[modify] https://crrev.com/4f4542eae187ee47e39291b9c5f1ac835eb32e6d/chrome/browser/ui/autofill/chrome_autofill_client.cc
Project Member

Comment 5 by bugdroid1@chromium.org, Oct 9 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cfe6e706d0aa049c636103a0a6f4eaf62117fd7e

commit cfe6e706d0aa049c636103a0a6f4eaf62117fd7e
Author: Anne Lim <annelim@google.com>
Date: Tue Oct 09 19:01:05 2018

[AF][Traffic Light] UMA for Nth Strike Added

Add a metric recording the number of Nth refusals for credit card uploads
per user.

Bug: 884817
Change-Id: I134a6fec898c1068f2e65066c4c581626b19905f
Reviewed-on: https://chromium-review.googlesource.com/c/1262645
Commit-Queue: Anne Lim <annelim@google.com>
Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Reviewed-by: Jared Saul <jsaul@google.com>
Cr-Commit-Position: refs/heads/master@{#598018}
[modify] https://crrev.com/cfe6e706d0aa049c636103a0a6f4eaf62117fd7e/components/autofill/core/browser/strike_database.cc
[modify] https://crrev.com/cfe6e706d0aa049c636103a0a6f4eaf62117fd7e/components/autofill/core/browser/strike_database.h
[modify] https://crrev.com/cfe6e706d0aa049c636103a0a6f4eaf62117fd7e/components/autofill/core/browser/strike_database_unittest.cc
[modify] https://crrev.com/cfe6e706d0aa049c636103a0a6f4eaf62117fd7e/tools/metrics/histograms/histograms.xml
Project Member

Comment 6 by bugdroid1@chromium.org, Oct 10 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8a0c1e9236a8cf5f42f3930f14b6f433275cad09

commit 8a0c1e9236a8cf5f42f3930f14b6f433275cad09
Author: Jared Saul <jsaul@google.com>
Date: Wed Oct 10 18:22:47 2018

[Autofill] [Traffic Light] Don't offer to save if too many strikes

This change checks the Autofill StrikeDatabase before credit card save.
If the card has been ignored/declined/rejected too many times in the
past, it will not show the save card bubble (but still show the icon) on
Desktop, or not show the save card infobar on Mobile.

Bug: 884817
Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
Change-Id: I5c6591f5efd3d4719ce856080685b601c4f4be4f
Reviewed-on: https://chromium-review.googlesource.com/c/1236291
Commit-Queue: Jared Saul <jsaul@google.com>
Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Reviewed-by: Rouslan Solomakhin <rouslan@chromium.org>
Reviewed-by: Moe Ahmadi <mahmadi@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Reviewed-by: Richard Coles <torne@chromium.org>
Reviewed-by: Evan Stade <estade@chromium.org>
Cr-Commit-Position: refs/heads/master@{#598409}
[modify] https://crrev.com/8a0c1e9236a8cf5f42f3930f14b6f433275cad09/android_webview/browser/aw_autofill_client.cc
[modify] https://crrev.com/8a0c1e9236a8cf5f42f3930f14b6f433275cad09/android_webview/browser/aw_autofill_client.h
[modify] https://crrev.com/8a0c1e9236a8cf5f42f3930f14b6f433275cad09/chrome/browser/about_flags.cc
[modify] https://crrev.com/8a0c1e9236a8cf5f42f3930f14b6f433275cad09/chrome/browser/flag_descriptions.cc
[modify] https://crrev.com/8a0c1e9236a8cf5f42f3930f14b6f433275cad09/chrome/browser/flag_descriptions.h
[modify] https://crrev.com/8a0c1e9236a8cf5f42f3930f14b6f433275cad09/chrome/browser/ui/autofill/chrome_autofill_client.cc
[modify] https://crrev.com/8a0c1e9236a8cf5f42f3930f14b6f433275cad09/chrome/browser/ui/autofill/chrome_autofill_client.h
[modify] https://crrev.com/8a0c1e9236a8cf5f42f3930f14b6f433275cad09/chrome/browser/ui/autofill/save_card_bubble_controller_impl.cc
[modify] https://crrev.com/8a0c1e9236a8cf5f42f3930f14b6f433275cad09/chrome/browser/ui/autofill/save_card_bubble_controller_impl.h
[modify] https://crrev.com/8a0c1e9236a8cf5f42f3930f14b6f433275cad09/chrome/browser/ui/autofill/save_card_bubble_controller_impl_browsertest.cc
[modify] https://crrev.com/8a0c1e9236a8cf5f42f3930f14b6f433275cad09/chrome/browser/ui/autofill/save_card_bubble_controller_impl_unittest.cc
[modify] https://crrev.com/8a0c1e9236a8cf5f42f3930f14b6f433275cad09/components/autofill/core/browser/BUILD.gn
[modify] https://crrev.com/8a0c1e9236a8cf5f42f3930f14b6f433275cad09/components/autofill/core/browser/autofill_client.h
[modify] https://crrev.com/8a0c1e9236a8cf5f42f3930f14b6f433275cad09/components/autofill/core/browser/autofill_metrics.h
[modify] https://crrev.com/8a0c1e9236a8cf5f42f3930f14b6f433275cad09/components/autofill/core/browser/credit_card_save_manager.cc
[modify] https://crrev.com/8a0c1e9236a8cf5f42f3930f14b6f433275cad09/components/autofill/core/browser/credit_card_save_manager.h
[modify] https://crrev.com/8a0c1e9236a8cf5f42f3930f14b6f433275cad09/components/autofill/core/browser/credit_card_save_manager_unittest.cc
[modify] https://crrev.com/8a0c1e9236a8cf5f42f3930f14b6f433275cad09/components/autofill/core/browser/form_data_importer.cc
[modify] https://crrev.com/8a0c1e9236a8cf5f42f3930f14b6f433275cad09/components/autofill/core/browser/strike_database.cc
[modify] https://crrev.com/8a0c1e9236a8cf5f42f3930f14b6f433275cad09/components/autofill/core/browser/strike_database.h
[modify] https://crrev.com/8a0c1e9236a8cf5f42f3930f14b6f433275cad09/components/autofill/core/browser/strike_database_unittest.cc
[modify] https://crrev.com/8a0c1e9236a8cf5f42f3930f14b6f433275cad09/components/autofill/core/browser/test_autofill_client.cc
[modify] https://crrev.com/8a0c1e9236a8cf5f42f3930f14b6f433275cad09/components/autofill/core/browser/test_autofill_client.h
[modify] https://crrev.com/8a0c1e9236a8cf5f42f3930f14b6f433275cad09/components/autofill/core/browser/test_strike_database.cc
[modify] https://crrev.com/8a0c1e9236a8cf5f42f3930f14b6f433275cad09/components/autofill/core/browser/test_strike_database.h
[modify] https://crrev.com/8a0c1e9236a8cf5f42f3930f14b6f433275cad09/components/autofill/core/common/autofill_features.cc
[modify] https://crrev.com/8a0c1e9236a8cf5f42f3930f14b6f433275cad09/components/autofill/core/common/autofill_features.h
[modify] https://crrev.com/8a0c1e9236a8cf5f42f3930f14b6f433275cad09/components/autofill/ios/browser/BUILD.gn
[modify] https://crrev.com/8a0c1e9236a8cf5f42f3930f14b6f433275cad09/components/payments/core/BUILD.gn
[modify] https://crrev.com/8a0c1e9236a8cf5f42f3930f14b6f433275cad09/ios/chrome/browser/ui/autofill/chrome_autofill_client_ios.h
[modify] https://crrev.com/8a0c1e9236a8cf5f42f3930f14b6f433275cad09/ios/chrome/browser/ui/autofill/chrome_autofill_client_ios.mm
[modify] https://crrev.com/8a0c1e9236a8cf5f42f3930f14b6f433275cad09/ios/web_view/internal/autofill/web_view_autofill_client_ios.h
[modify] https://crrev.com/8a0c1e9236a8cf5f42f3930f14b6f433275cad09/ios/web_view/internal/autofill/web_view_autofill_client_ios.mm
[modify] https://crrev.com/8a0c1e9236a8cf5f42f3930f14b6f433275cad09/tools/metrics/histograms/enums.xml
Project Member

Comment 7 by bugdroid1@chromium.org, Oct 10 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d96e83a11e6464c09a526ec4dd2a7992a79e46ba

commit d96e83a11e6464c09a526ec4dd2a7992a79e46ba
Author: Jared Saul <jsaul@google.com>
Date: Wed Oct 10 23:57:00 2018

[Autofill] Clear strikes if credit card is saved

Still no tests yet, as I haven't yet solved the problem of having a
multi-threaded CreditCardSaveManager test.  I might be able to follow up
on these with browsertests instead.

Diffbased on CL 1236291.

Bug: 884817
Change-Id: I00d816b1b519f19b25d39cfe4321d98405469d0b
Reviewed-on: https://chromium-review.googlesource.com/c/1269628
Commit-Queue: Jared Saul <jsaul@google.com>
Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#598577}
[modify] https://crrev.com/d96e83a11e6464c09a526ec4dd2a7992a79e46ba/components/autofill/core/browser/autofill_metrics_unittest.cc
[modify] https://crrev.com/d96e83a11e6464c09a526ec4dd2a7992a79e46ba/components/autofill/core/browser/credit_card_save_manager.cc
[modify] https://crrev.com/d96e83a11e6464c09a526ec4dd2a7992a79e46ba/components/autofill/core/browser/credit_card_save_manager.h
[modify] https://crrev.com/d96e83a11e6464c09a526ec4dd2a7992a79e46ba/components/autofill/core/browser/credit_card_save_manager_unittest.cc
[modify] https://crrev.com/d96e83a11e6464c09a526ec4dd2a7992a79e46ba/components/autofill/core/browser/personal_data_manager.cc
[modify] https://crrev.com/d96e83a11e6464c09a526ec4dd2a7992a79e46ba/components/autofill/core/browser/test_strike_database.cc
[modify] https://crrev.com/d96e83a11e6464c09a526ec4dd2a7992a79e46ba/components/autofill/core/browser/test_strike_database.h
Project Member

Comment 8 by bugdroid1@chromium.org, Oct 11 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/87b1d08a24fdaaa3b29a3343e7e799e45e713179

commit 87b1d08a24fdaaa3b29a3343e7e799e45e713179
Author: Jared Saul <jsaul@google.com>
Date: Thu Oct 11 19:50:30 2018

[Autofill] Replace ElapsedTimer with AutofillClock for save card

Bug: 884817
Change-Id: Ie08d29f7f5b1b8715740a34be8d5894fd3b90d2b
Reviewed-on: https://chromium-review.googlesource.com/c/1277645
Commit-Queue: Jared Saul <jsaul@google.com>
Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Reviewed-by: Fabio Tirelo <ftirelo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#598897}
[modify] https://crrev.com/87b1d08a24fdaaa3b29a3343e7e799e45e713179/chrome/browser/ui/autofill/save_card_bubble_controller_impl.cc
[modify] https://crrev.com/87b1d08a24fdaaa3b29a3343e7e799e45e713179/chrome/browser/ui/autofill/save_card_bubble_controller_impl.h
[modify] https://crrev.com/87b1d08a24fdaaa3b29a3343e7e799e45e713179/chrome/browser/ui/autofill/save_card_bubble_controller_impl_unittest.cc
Project Member

Comment 9 by bugdroid1@chromium.org, Oct 11 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fa35085a33c62472f67a298c485cd77825e35f90

commit fa35085a33c62472f67a298c485cd77825e35f90
Author: Jared Saul <jsaul@google.com>
Date: Thu Oct 11 20:54:44 2018

[Autofill] Log metrics on Autofill StrikeDatabase usage

Records two new metrics situations (local and server for both):
1) How many strikes a card had when it was successfully saved
2) When save is not offered due to being a 3-striked card

Bug: 884817
Change-Id: I225994e6ad210cc6f0d768f209ff17a5cea23532
Reviewed-on: https://chromium-review.googlesource.com/c/1275026
Commit-Queue: Jared Saul <jsaul@google.com>
Commit-Queue: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Cr-Commit-Position: refs/heads/master@{#598925}
[modify] https://crrev.com/fa35085a33c62472f67a298c485cd77825e35f90/components/autofill/core/browser/autofill_metrics.cc
[modify] https://crrev.com/fa35085a33c62472f67a298c485cd77825e35f90/components/autofill/core/browser/autofill_metrics.h
[modify] https://crrev.com/fa35085a33c62472f67a298c485cd77825e35f90/components/autofill/core/browser/credit_card_save_manager.cc
[modify] https://crrev.com/fa35085a33c62472f67a298c485cd77825e35f90/components/autofill/core/browser/credit_card_save_manager.h
[modify] https://crrev.com/fa35085a33c62472f67a298c485cd77825e35f90/components/autofill/core/browser/credit_card_save_manager_unittest.cc
[modify] https://crrev.com/fa35085a33c62472f67a298c485cd77825e35f90/tools/metrics/histograms/enums.xml
[modify] https://crrev.com/fa35085a33c62472f67a298c485cd77825e35f90/tools/metrics/histograms/histograms.xml
Project Member

Comment 10 by bugdroid1@chromium.org, Oct 17 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d82a26bd00c46d54e07521af6fb56a9348edae90

commit d82a26bd00c46d54e07521af6fb56a9348edae90
Author: Jared Saul <jsaul@google.com>
Date: Wed Oct 17 18:38:05 2018

[Autofill] Add strikes when credit card save ignored/denied/fails

(When a card accrues 3 strikes, future offers to save for that card
should show the omnibox save icon, but NOT pop up the bubble.
On Android, no offer to save is shown at all.)

Bug: 884817
Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
Change-Id: I0d6ad27a4e03d0128970af6e22d2a40a62d0601b
Reviewed-on: https://chromium-review.googlesource.com/c/1269524
Commit-Queue: Jared Saul <jsaul@google.com>
Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Reviewed-by: Fabio Tirelo <ftirelo@chromium.org>
Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Reviewed-by: Moe Ahmadi <mahmadi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600490}
[modify] https://crrev.com/d82a26bd00c46d54e07521af6fb56a9348edae90/chrome/browser/autofill/autofill_save_card_infobar_delegate_mobile_unittest.cc
[modify] https://crrev.com/d82a26bd00c46d54e07521af6fb56a9348edae90/chrome/browser/ui/autofill/chrome_autofill_client.cc
[modify] https://crrev.com/d82a26bd00c46d54e07521af6fb56a9348edae90/chrome/browser/ui/autofill/save_card_bubble_controller_impl.cc
[modify] https://crrev.com/d82a26bd00c46d54e07521af6fb56a9348edae90/chrome/browser/ui/autofill/save_card_bubble_controller_impl.h
[modify] https://crrev.com/d82a26bd00c46d54e07521af6fb56a9348edae90/chrome/browser/ui/views/autofill/save_card_bubble_views_browsertest.cc
[modify] https://crrev.com/d82a26bd00c46d54e07521af6fb56a9348edae90/chrome/browser/ui/views/autofill/save_card_bubble_views_browsertest_base.cc
[modify] https://crrev.com/d82a26bd00c46d54e07521af6fb56a9348edae90/chrome/browser/ui/views/autofill/save_card_bubble_views_browsertest_base.h
[modify] https://crrev.com/d82a26bd00c46d54e07521af6fb56a9348edae90/components/autofill/core/browser/autofill_save_card_infobar_delegate_mobile.cc
[modify] https://crrev.com/d82a26bd00c46d54e07521af6fb56a9348edae90/components/autofill/core/browser/autofill_save_card_infobar_delegate_mobile.h
[modify] https://crrev.com/d82a26bd00c46d54e07521af6fb56a9348edae90/components/autofill/core/browser/credit_card_save_manager.cc
[modify] https://crrev.com/d82a26bd00c46d54e07521af6fb56a9348edae90/components/autofill/core/browser/credit_card_save_manager.h
[modify] https://crrev.com/d82a26bd00c46d54e07521af6fb56a9348edae90/components/autofill/core/browser/strike_database.h
[modify] https://crrev.com/d82a26bd00c46d54e07521af6fb56a9348edae90/components/autofill/core/common/autofill_constants.h
[modify] https://crrev.com/d82a26bd00c46d54e07521af6fb56a9348edae90/components/autofill/ios/browser/credit_card_save_manager_test_observer_bridge.h
[modify] https://crrev.com/d82a26bd00c46d54e07521af6fb56a9348edae90/components/autofill/ios/browser/credit_card_save_manager_test_observer_bridge.mm
[modify] https://crrev.com/d82a26bd00c46d54e07521af6fb56a9348edae90/ios/chrome/browser/ui/autofill/chrome_autofill_client_ios.mm
[modify] https://crrev.com/d82a26bd00c46d54e07521af6fb56a9348edae90/ios/chrome/browser/ui/autofill/save_card_infobar_egtest.mm
Project Member

Comment 11 by bugdroid1@chromium.org, Oct 17 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/df2e4163068a0a1876d95b4ae29c1f79a5e5ce7b

commit df2e4163068a0a1876d95b4ae29c1f79a5e5ce7b
Author: Findit <findit-for-me@appspot.gserviceaccount.com>
Date: Wed Oct 17 22:54:11 2018

Revert "[Autofill] Add strikes when credit card save ignored/denied/fails"

This reverts commit d82a26bd00c46d54e07521af6fb56a9348edae90.

Reason for revert:

Findit (https://goo.gl/kROfz5) identified CL at revision 600490 as the
culprit for flakes in the build cycles as shown on:
https://findit-for-me.appspot.com/waterfall/flake/flake-culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyQwsSDEZsYWtlQ3VscHJpdCIxY2hyb21pdW0vZDgyYTI2YmQwMGM0NmQ1NGUwNzUyMWFmNmZiNTZhOTM0OGVkYWU5MAw

Sample Failed Build: https://ci.chromium.org/buildbot/chromium.win/Win%207%20Tests%20x64%20%281%29/44415

Sample Failed Step: browser_tests

Sample Flaky Test: SaveCardBubbleViewsFullFormBrowserTest.StrikeDatabase_Local_AddStrikeIfBubbleIgnored

Original change's description:
> [Autofill] Add strikes when credit card save ignored/denied/fails
> 
> (When a card accrues 3 strikes, future offers to save for that card
> should show the omnibox save icon, but NOT pop up the bubble.
> On Android, no offer to save is shown at all.)
> 
> Bug: 884817
> Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
> Change-Id: I0d6ad27a4e03d0128970af6e22d2a40a62d0601b
> Reviewed-on: https://chromium-review.googlesource.com/c/1269524
> Commit-Queue: Jared Saul <jsaul@google.com>
> Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
> Reviewed-by: Fabio Tirelo <ftirelo@chromium.org>
> Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
> Reviewed-by: Moe Ahmadi <mahmadi@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#600490}

Change-Id: I7d0536b919212228db19f87c6cc09358928ffd35
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 884817,  896493 
Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
Reviewed-on: https://chromium-review.googlesource.com/c/1287252
Cr-Commit-Position: refs/heads/master@{#600583}
[modify] https://crrev.com/df2e4163068a0a1876d95b4ae29c1f79a5e5ce7b/chrome/browser/autofill/autofill_save_card_infobar_delegate_mobile_unittest.cc
[modify] https://crrev.com/df2e4163068a0a1876d95b4ae29c1f79a5e5ce7b/chrome/browser/ui/autofill/chrome_autofill_client.cc
[modify] https://crrev.com/df2e4163068a0a1876d95b4ae29c1f79a5e5ce7b/chrome/browser/ui/autofill/save_card_bubble_controller_impl.cc
[modify] https://crrev.com/df2e4163068a0a1876d95b4ae29c1f79a5e5ce7b/chrome/browser/ui/autofill/save_card_bubble_controller_impl.h
[modify] https://crrev.com/df2e4163068a0a1876d95b4ae29c1f79a5e5ce7b/chrome/browser/ui/views/autofill/save_card_bubble_views_browsertest.cc
[modify] https://crrev.com/df2e4163068a0a1876d95b4ae29c1f79a5e5ce7b/chrome/browser/ui/views/autofill/save_card_bubble_views_browsertest_base.cc
[modify] https://crrev.com/df2e4163068a0a1876d95b4ae29c1f79a5e5ce7b/chrome/browser/ui/views/autofill/save_card_bubble_views_browsertest_base.h
[modify] https://crrev.com/df2e4163068a0a1876d95b4ae29c1f79a5e5ce7b/components/autofill/core/browser/autofill_save_card_infobar_delegate_mobile.cc
[modify] https://crrev.com/df2e4163068a0a1876d95b4ae29c1f79a5e5ce7b/components/autofill/core/browser/autofill_save_card_infobar_delegate_mobile.h
[modify] https://crrev.com/df2e4163068a0a1876d95b4ae29c1f79a5e5ce7b/components/autofill/core/browser/credit_card_save_manager.cc
[modify] https://crrev.com/df2e4163068a0a1876d95b4ae29c1f79a5e5ce7b/components/autofill/core/browser/credit_card_save_manager.h
[modify] https://crrev.com/df2e4163068a0a1876d95b4ae29c1f79a5e5ce7b/components/autofill/core/browser/strike_database.h
[modify] https://crrev.com/df2e4163068a0a1876d95b4ae29c1f79a5e5ce7b/components/autofill/core/common/autofill_constants.h
[modify] https://crrev.com/df2e4163068a0a1876d95b4ae29c1f79a5e5ce7b/components/autofill/ios/browser/credit_card_save_manager_test_observer_bridge.h
[modify] https://crrev.com/df2e4163068a0a1876d95b4ae29c1f79a5e5ce7b/components/autofill/ios/browser/credit_card_save_manager_test_observer_bridge.mm
[modify] https://crrev.com/df2e4163068a0a1876d95b4ae29c1f79a5e5ce7b/ios/chrome/browser/ui/autofill/chrome_autofill_client_ios.mm
[modify] https://crrev.com/df2e4163068a0a1876d95b4ae29c1f79a5e5ce7b/ios/chrome/browser/ui/autofill/save_card_infobar_egtest.mm
Project Member

Comment 12 by bugdroid1@chromium.org, Oct 18 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/aec3d51c69233971e8f90a76121b9de5ef1a3f35

commit aec3d51c69233971e8f90a76121b9de5ef1a3f35
Author: Anne Lim <annelim@google.com>
Date: Thu Oct 18 03:13:53 2018

[Autofill] Clear strikes when autofill data wiped out

Clears all strikes in a profile's StrikeDatabase when Autofill
data is wiped out from Chrome Settings (chrome://settings ->
Clear Browsing Data -> Advanced -> Autofill Form Data).

Bug: 884817
Change-Id: I15cab8ab6812b1367d386c7bf321be24b1a0086c
Reviewed-on: https://chromium-review.googlesource.com/c/1277842
Commit-Queue: Anne Lim <annelim@google.com>
Reviewed-by: Martin Šrámek <msramek@chromium.org>
Reviewed-by: Jared Saul <jsaul@google.com>
Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600648}
[modify] https://crrev.com/aec3d51c69233971e8f90a76121b9de5ef1a3f35/chrome/browser/browsing_data/chrome_browsing_data_remover_delegate.cc
[modify] https://crrev.com/aec3d51c69233971e8f90a76121b9de5ef1a3f35/chrome/browser/browsing_data/chrome_browsing_data_remover_delegate_unittest.cc
[modify] https://crrev.com/aec3d51c69233971e8f90a76121b9de5ef1a3f35/components/autofill/core/browser/strike_database.cc
[modify] https://crrev.com/aec3d51c69233971e8f90a76121b9de5ef1a3f35/components/autofill/core/browser/strike_database.h
[modify] https://crrev.com/aec3d51c69233971e8f90a76121b9de5ef1a3f35/components/autofill/core/browser/strike_database_unittest.cc
[modify] https://crrev.com/aec3d51c69233971e8f90a76121b9de5ef1a3f35/components/autofill/core/browser/test_strike_database.cc
[modify] https://crrev.com/aec3d51c69233971e8f90a76121b9de5ef1a3f35/components/autofill/core/browser/test_strike_database.h
Project Member

Comment 13 by bugdroid1@chromium.org, Oct 19 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4d310087323bb7200f81a4d4fb6a0e72f7fc6bd2

commit 4d310087323bb7200f81a4d4fb6a0e72f7fc6bd2
Author: Jared Saul <jsaul@google.com>
Date: Fri Oct 19 20:26:25 2018

[Autofill] Add strikes when CC save ignored/denied/fails

This is a retry/relanding of
https://chromium-review.googlesource.com/c/chromium/src/+/1269524.
We're having a *very* hard time reproducing the flakes that the trybots
experienced, but I've made some improvements to attempt to reduce
possible race conditions in the browsertests.

Patch set 1 is the original CL; patch set 2 contains the new changes.

(When a card accrues 3 strikes, future offers to save for that card
should show the omnibox save icon, but NOT pop up the bubble.
On Android, no offer to save is shown at all.)

TBR=mahmadi@chromium.org

Bug: 884817
Change-Id: If641cff300cab6122bfd0a52942376b8b6449fed
Reviewed-on: https://chromium-review.googlesource.com/c/1292169
Commit-Queue: Jared Saul <jsaul@google.com>
Reviewed-by: Evan Stade <estade@chromium.org>
Cr-Commit-Position: refs/heads/master@{#601278}
[modify] https://crrev.com/4d310087323bb7200f81a4d4fb6a0e72f7fc6bd2/chrome/browser/autofill/autofill_save_card_infobar_delegate_mobile_unittest.cc
[modify] https://crrev.com/4d310087323bb7200f81a4d4fb6a0e72f7fc6bd2/chrome/browser/ui/autofill/chrome_autofill_client.cc
[modify] https://crrev.com/4d310087323bb7200f81a4d4fb6a0e72f7fc6bd2/chrome/browser/ui/autofill/save_card_bubble_controller_impl.cc
[modify] https://crrev.com/4d310087323bb7200f81a4d4fb6a0e72f7fc6bd2/chrome/browser/ui/autofill/save_card_bubble_controller_impl.h
[modify] https://crrev.com/4d310087323bb7200f81a4d4fb6a0e72f7fc6bd2/chrome/browser/ui/views/autofill/save_card_bubble_views_browsertest.cc
[modify] https://crrev.com/4d310087323bb7200f81a4d4fb6a0e72f7fc6bd2/chrome/browser/ui/views/autofill/save_card_bubble_views_browsertest_base.cc
[modify] https://crrev.com/4d310087323bb7200f81a4d4fb6a0e72f7fc6bd2/chrome/browser/ui/views/autofill/save_card_bubble_views_browsertest_base.h
[modify] https://crrev.com/4d310087323bb7200f81a4d4fb6a0e72f7fc6bd2/components/autofill/core/browser/autofill_save_card_infobar_delegate_mobile.cc
[modify] https://crrev.com/4d310087323bb7200f81a4d4fb6a0e72f7fc6bd2/components/autofill/core/browser/autofill_save_card_infobar_delegate_mobile.h
[modify] https://crrev.com/4d310087323bb7200f81a4d4fb6a0e72f7fc6bd2/components/autofill/core/browser/credit_card_save_manager.cc
[modify] https://crrev.com/4d310087323bb7200f81a4d4fb6a0e72f7fc6bd2/components/autofill/core/browser/credit_card_save_manager.h
[modify] https://crrev.com/4d310087323bb7200f81a4d4fb6a0e72f7fc6bd2/components/autofill/core/browser/strike_database.cc
[modify] https://crrev.com/4d310087323bb7200f81a4d4fb6a0e72f7fc6bd2/components/autofill/core/browser/strike_database.h
[modify] https://crrev.com/4d310087323bb7200f81a4d4fb6a0e72f7fc6bd2/components/autofill/core/common/autofill_constants.h
[modify] https://crrev.com/4d310087323bb7200f81a4d4fb6a0e72f7fc6bd2/components/autofill/ios/browser/credit_card_save_manager_test_observer_bridge.h
[modify] https://crrev.com/4d310087323bb7200f81a4d4fb6a0e72f7fc6bd2/components/autofill/ios/browser/credit_card_save_manager_test_observer_bridge.mm
[modify] https://crrev.com/4d310087323bb7200f81a4d4fb6a0e72f7fc6bd2/ios/chrome/browser/ui/autofill/chrome_autofill_client_ios.mm
[modify] https://crrev.com/4d310087323bb7200f81a4d4fb6a0e72f7fc6bd2/ios/chrome/browser/ui/autofill/save_card_infobar_egtest.mm
Project Member

Comment 14 by bugdroid1@chromium.org, Oct 22 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b2120236296360719160d1910cbd6622ccd45158

commit b2120236296360719160d1910cbd6622ccd45158
Author: Fergal Daly <fergal@chromium.org>
Date: Mon Oct 22 05:56:13 2018

Revert "[Autofill] Add strikes when CC save ignored/denied/fails"

This reverts commit 4d310087323bb7200f81a4d4fb6a0e72f7fc6bd2.

Reason for revert:

Findit identifies this CL as a source of flakiness with 100% confidence

https://findit-for-me.appspot.com/waterfall/flake?key=ag9zfmZpbmRpdC1mb3ItbWVy4AELEhdNYXN0ZXJGbGFrZUFuYWx5c2lzUm9vdCKpAWNocm9taXVtLndpbi9XaW4gNyBUZXN0cyB4NjQgKDEpLzQ0NTYxL25ldHdvcmtfc2VydmljZV9icm93c2VyX3Rlc3RzL1UyRjJaVU5oY21SQ2RXSmliR1ZXYVdWM2MwWjFiR3hHYjNKdFFuSnZkM05sY2xSbGMzUXVVM1J5YVd0bFJHRjBZV0poYzJWZlZYQnNiMkZrWDBaMWJHeEdiRzkzVkdWemRBPT0MCxITTWFzdGVyRmxha2VBbmFseXNpcxgBDA

Original change's description:
> [Autofill] Add strikes when CC save ignored/denied/fails
> 
> This is a retry/relanding of
> https://chromium-review.googlesource.com/c/chromium/src/+/1269524.
> We're having a *very* hard time reproducing the flakes that the trybots
> experienced, but I've made some improvements to attempt to reduce
> possible race conditions in the browsertests.
> 
> Patch set 1 is the original CL; patch set 2 contains the new changes.
> 
> (When a card accrues 3 strikes, future offers to save for that card
> should show the omnibox save icon, but NOT pop up the bubble.
> On Android, no offer to save is shown at all.)
> 
> TBR=mahmadi@chromium.org
> 
> Bug: 884817
> Change-Id: If641cff300cab6122bfd0a52942376b8b6449fed
> Reviewed-on: https://chromium-review.googlesource.com/c/1292169
> Commit-Queue: Jared Saul <jsaul@google.com>
> Reviewed-by: Evan Stade <estade@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#601278}

TBR=estade@chromium.org,mahmadi@chromium.org,jsaul@google.com

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 884817
Change-Id: I1761991641b0b89274e2e8233c8150c8d688cb34
Reviewed-on: https://chromium-review.googlesource.com/c/1293055
Reviewed-by: Fergal Daly <fergal@chromium.org>
Commit-Queue: Fergal Daly <fergal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#601482}
[modify] https://crrev.com/b2120236296360719160d1910cbd6622ccd45158/chrome/browser/autofill/autofill_save_card_infobar_delegate_mobile_unittest.cc
[modify] https://crrev.com/b2120236296360719160d1910cbd6622ccd45158/chrome/browser/ui/autofill/chrome_autofill_client.cc
[modify] https://crrev.com/b2120236296360719160d1910cbd6622ccd45158/chrome/browser/ui/autofill/save_card_bubble_controller_impl.cc
[modify] https://crrev.com/b2120236296360719160d1910cbd6622ccd45158/chrome/browser/ui/autofill/save_card_bubble_controller_impl.h
[modify] https://crrev.com/b2120236296360719160d1910cbd6622ccd45158/chrome/browser/ui/views/autofill/save_card_bubble_views_browsertest.cc
[modify] https://crrev.com/b2120236296360719160d1910cbd6622ccd45158/chrome/browser/ui/views/autofill/save_card_bubble_views_browsertest_base.cc
[modify] https://crrev.com/b2120236296360719160d1910cbd6622ccd45158/chrome/browser/ui/views/autofill/save_card_bubble_views_browsertest_base.h
[modify] https://crrev.com/b2120236296360719160d1910cbd6622ccd45158/components/autofill/core/browser/autofill_save_card_infobar_delegate_mobile.cc
[modify] https://crrev.com/b2120236296360719160d1910cbd6622ccd45158/components/autofill/core/browser/autofill_save_card_infobar_delegate_mobile.h
[modify] https://crrev.com/b2120236296360719160d1910cbd6622ccd45158/components/autofill/core/browser/credit_card_save_manager.cc
[modify] https://crrev.com/b2120236296360719160d1910cbd6622ccd45158/components/autofill/core/browser/credit_card_save_manager.h
[modify] https://crrev.com/b2120236296360719160d1910cbd6622ccd45158/components/autofill/core/browser/strike_database.cc
[modify] https://crrev.com/b2120236296360719160d1910cbd6622ccd45158/components/autofill/core/browser/strike_database.h
[modify] https://crrev.com/b2120236296360719160d1910cbd6622ccd45158/components/autofill/core/common/autofill_constants.h
[modify] https://crrev.com/b2120236296360719160d1910cbd6622ccd45158/components/autofill/ios/browser/credit_card_save_manager_test_observer_bridge.h
[modify] https://crrev.com/b2120236296360719160d1910cbd6622ccd45158/components/autofill/ios/browser/credit_card_save_manager_test_observer_bridge.mm
[modify] https://crrev.com/b2120236296360719160d1910cbd6622ccd45158/ios/chrome/browser/ui/autofill/chrome_autofill_client_ios.mm
[modify] https://crrev.com/b2120236296360719160d1910cbd6622ccd45158/ios/chrome/browser/ui/autofill/save_card_infobar_egtest.mm
Project Member

Comment 15 by bugdroid1@chromium.org, Oct 22 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bb15c8040b58a4e7d9d3adf7729ebf9904d82e28

commit bb15c8040b58a4e7d9d3adf7729ebf9904d82e28
Author: Jared Saul <jsaul@google.com>
Date: Mon Oct 22 20:48:52 2018

[Autofill] Add strikes when CC save ignored/denied/fails

This is a retry/relanding of
https://chromium-review.googlesource.com/c/chromium/src/+/1269524,
but with the browsertest additions removed, because something is causing
them to be flaky on Win7 builds.  Despite making progress, the original
CL has already been reverted twice, so I'd like to land this portion of
it so if it's reverted in the future, only the browsertests (done as a
subsequent CL) will be reverted instead of this big 18-file thing.

Bug: 884817
Change-Id: I05983ff8b13c7dbac25e615bba8a5d1fa7cc0819
Reviewed-on: https://chromium-review.googlesource.com/c/1294429
Reviewed-by: Moe Ahmadi <mahmadi@chromium.org>
Reviewed-by: Evan Stade <estade@chromium.org>
Commit-Queue: Jared Saul <jsaul@google.com>
Cr-Commit-Position: refs/heads/master@{#601720}
[modify] https://crrev.com/bb15c8040b58a4e7d9d3adf7729ebf9904d82e28/chrome/browser/autofill/autofill_save_card_infobar_delegate_mobile_unittest.cc
[modify] https://crrev.com/bb15c8040b58a4e7d9d3adf7729ebf9904d82e28/chrome/browser/ui/autofill/chrome_autofill_client.cc
[modify] https://crrev.com/bb15c8040b58a4e7d9d3adf7729ebf9904d82e28/chrome/browser/ui/autofill/save_card_bubble_controller_impl.cc
[modify] https://crrev.com/bb15c8040b58a4e7d9d3adf7729ebf9904d82e28/chrome/browser/ui/autofill/save_card_bubble_controller_impl.h
[modify] https://crrev.com/bb15c8040b58a4e7d9d3adf7729ebf9904d82e28/chrome/browser/ui/views/autofill/save_card_bubble_views_browsertest.cc
[modify] https://crrev.com/bb15c8040b58a4e7d9d3adf7729ebf9904d82e28/chrome/browser/ui/views/autofill/save_card_bubble_views_browsertest_base.cc
[modify] https://crrev.com/bb15c8040b58a4e7d9d3adf7729ebf9904d82e28/chrome/browser/ui/views/autofill/save_card_bubble_views_browsertest_base.h
[modify] https://crrev.com/bb15c8040b58a4e7d9d3adf7729ebf9904d82e28/components/autofill/core/browser/autofill_save_card_infobar_delegate_mobile.cc
[modify] https://crrev.com/bb15c8040b58a4e7d9d3adf7729ebf9904d82e28/components/autofill/core/browser/autofill_save_card_infobar_delegate_mobile.h
[modify] https://crrev.com/bb15c8040b58a4e7d9d3adf7729ebf9904d82e28/components/autofill/core/browser/credit_card_save_manager.cc
[modify] https://crrev.com/bb15c8040b58a4e7d9d3adf7729ebf9904d82e28/components/autofill/core/browser/credit_card_save_manager.h
[modify] https://crrev.com/bb15c8040b58a4e7d9d3adf7729ebf9904d82e28/components/autofill/core/browser/strike_database.cc
[modify] https://crrev.com/bb15c8040b58a4e7d9d3adf7729ebf9904d82e28/components/autofill/core/browser/strike_database.h
[modify] https://crrev.com/bb15c8040b58a4e7d9d3adf7729ebf9904d82e28/components/autofill/core/common/autofill_constants.h
[modify] https://crrev.com/bb15c8040b58a4e7d9d3adf7729ebf9904d82e28/components/autofill/ios/browser/credit_card_save_manager_test_observer_bridge.h
[modify] https://crrev.com/bb15c8040b58a4e7d9d3adf7729ebf9904d82e28/components/autofill/ios/browser/credit_card_save_manager_test_observer_bridge.mm
[modify] https://crrev.com/bb15c8040b58a4e7d9d3adf7729ebf9904d82e28/ios/chrome/browser/ui/autofill/chrome_autofill_client_ios.mm
[modify] https://crrev.com/bb15c8040b58a4e7d9d3adf7729ebf9904d82e28/ios/chrome/browser/ui/autofill/save_card_infobar_egtest.mm
Project Member

Comment 16 by bugdroid1@chromium.org, Oct 24

Labels: merge-merged-3578
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9cf05ba10e0d5dc2015133462807d5c88c39ccbb

commit 9cf05ba10e0d5dc2015133462807d5c88c39ccbb
Author: sebsg <sebsg@chromium.org>
Date: Wed Oct 24 13:41:18 2018

Merge-71 [Autofill] Clear strikes when autofill data wiped out

Clears all strikes in a profile's StrikeDatabase when Autofill
data is wiped out from Chrome Settings (chrome://settings ->
Clear Browsing Data -> Advanced -> Autofill Form Data).

TBR=annelim@google.com

(cherry picked from commit aec3d51c69233971e8f90a76121b9de5ef1a3f35)

Bug: 884817
Change-Id: I15cab8ab6812b1367d386c7bf321be24b1a0086c
Reviewed-on: https://chromium-review.googlesource.com/c/1277842
Commit-Queue: Anne Lim <annelim@google.com>
Reviewed-by: Martin Šrámek <msramek@chromium.org>
Reviewed-by: Jared Saul <jsaul@google.com>
Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#600648}
Reviewed-on: https://chromium-review.googlesource.com/c/1297265
Cr-Commit-Position: refs/branch-heads/3578@{#285}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}
[modify] https://crrev.com/9cf05ba10e0d5dc2015133462807d5c88c39ccbb/chrome/browser/browsing_data/chrome_browsing_data_remover_delegate.cc
[modify] https://crrev.com/9cf05ba10e0d5dc2015133462807d5c88c39ccbb/chrome/browser/browsing_data/chrome_browsing_data_remover_delegate_unittest.cc
[modify] https://crrev.com/9cf05ba10e0d5dc2015133462807d5c88c39ccbb/components/autofill/core/browser/strike_database.cc
[modify] https://crrev.com/9cf05ba10e0d5dc2015133462807d5c88c39ccbb/components/autofill/core/browser/strike_database.h
[modify] https://crrev.com/9cf05ba10e0d5dc2015133462807d5c88c39ccbb/components/autofill/core/browser/strike_database_unittest.cc
[modify] https://crrev.com/9cf05ba10e0d5dc2015133462807d5c88c39ccbb/components/autofill/core/browser/test_strike_database.cc
[modify] https://crrev.com/9cf05ba10e0d5dc2015133462807d5c88c39ccbb/components/autofill/core/browser/test_strike_database.h
Project Member

Comment 17 by cr-audit...@appspot.gserviceaccount.com, Oct 24

Labels: CommitLog-Audit-Violation Merge-Without-Approval M-71
Here's a summary of the rules that were executed: 
 - OnlyMergeApprovedChange: Rule Failed -- Revision 9cf05ba10e0d5dc2015133462807d5c88c39ccbb was merged to refs/branch-heads/3578 branch with no merge approval from a TPM! 
Please explain why this change was merged to the branch!
 - AcknowledgeMerge: Notification Required --
Project Member

Comment 18 by cr-audit...@appspot.gserviceaccount.com, Oct 24

Labels: Merge-Merged-71-3578
The following revision refers to this bug: 
https://chromium.googlesource.com/chromium/src.git/+/9cf05ba10e0d5dc2015133462807d5c88c39ccbb

Commit: 9cf05ba10e0d5dc2015133462807d5c88c39ccbb
Author: sebsg@chromium.org
Commiter: sebsg@chromium.org
Date: 2018-10-24 13:41:18 +0000 UTC

Merge-71 [Autofill] Clear strikes when autofill data wiped out

Clears all strikes in a profile's StrikeDatabase when Autofill
data is wiped out from Chrome Settings (chrome://settings ->
Clear Browsing Data -> Advanced -> Autofill Form Data).

TBR=annelim@google.com

(cherry picked from commit aec3d51c69233971e8f90a76121b9de5ef1a3f35)

Bug: 884817
Change-Id: I15cab8ab6812b1367d386c7bf321be24b1a0086c
Reviewed-on: https://chromium-review.googlesource.com/c/1277842
Commit-Queue: Anne Lim <annelim@google.com>
Reviewed-by: Martin Šrámek <msramek@chromium.org>
Reviewed-by: Jared Saul <jsaul@google.com>
Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#600648}
Reviewed-on: https://chromium-review.googlesource.com/c/1297265
Cr-Commit-Position: refs/branch-heads/3578@{#285}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}
Project Member

Comment 19 by bugdroid1@chromium.org, Oct 24 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/065f56b4156b5661ca19221204994e6b41094d8a

commit 065f56b4156b5661ca19221204994e6b41094d8a
Author: sebsg <sebsg@chromium.org>
Date: Wed Oct 24 13:43:40 2018

Merge-71 [Autofill] Add strikes when CC save ignored/denied/fails

This is a retry/relanding of
https://chromium-review.googlesource.com/c/chromium/src/+/1269524,
but with the browsertest additions removed, because something is causing
them to be flaky on Win7 builds.  Despite making progress, the original
CL has already been reverted twice, so I'd like to land this portion of
it so if it's reverted in the future, only the browsertests (done as a
subsequent CL) will be reverted instead of this big 18-file thing.

TBR=jsaul@google.com

(cherry picked from commit bb15c8040b58a4e7d9d3adf7729ebf9904d82e28)

Bug: 884817
Change-Id: I05983ff8b13c7dbac25e615bba8a5d1fa7cc0819
Reviewed-on: https://chromium-review.googlesource.com/c/1294429
Reviewed-by: Moe Ahmadi <mahmadi@chromium.org>
Reviewed-by: Evan Stade <estade@chromium.org>
Commit-Queue: Jared Saul <jsaul@google.com>
Cr-Original-Commit-Position: refs/heads/master@{#601720}
Reviewed-on: https://chromium-review.googlesource.com/c/1297727
Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Cr-Commit-Position: refs/branch-heads/3578@{#286}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}
[modify] https://crrev.com/065f56b4156b5661ca19221204994e6b41094d8a/chrome/browser/autofill/autofill_save_card_infobar_delegate_mobile_unittest.cc
[modify] https://crrev.com/065f56b4156b5661ca19221204994e6b41094d8a/chrome/browser/ui/autofill/chrome_autofill_client.cc
[modify] https://crrev.com/065f56b4156b5661ca19221204994e6b41094d8a/chrome/browser/ui/autofill/save_card_bubble_controller_impl.cc
[modify] https://crrev.com/065f56b4156b5661ca19221204994e6b41094d8a/chrome/browser/ui/autofill/save_card_bubble_controller_impl.h
[modify] https://crrev.com/065f56b4156b5661ca19221204994e6b41094d8a/chrome/browser/ui/views/autofill/save_card_bubble_views_browsertest.cc
[modify] https://crrev.com/065f56b4156b5661ca19221204994e6b41094d8a/chrome/browser/ui/views/autofill/save_card_bubble_views_browsertest_base.cc
[modify] https://crrev.com/065f56b4156b5661ca19221204994e6b41094d8a/chrome/browser/ui/views/autofill/save_card_bubble_views_browsertest_base.h
[modify] https://crrev.com/065f56b4156b5661ca19221204994e6b41094d8a/components/autofill/core/browser/autofill_save_card_infobar_delegate_mobile.cc
[modify] https://crrev.com/065f56b4156b5661ca19221204994e6b41094d8a/components/autofill/core/browser/autofill_save_card_infobar_delegate_mobile.h
[modify] https://crrev.com/065f56b4156b5661ca19221204994e6b41094d8a/components/autofill/core/browser/credit_card_save_manager.cc
[modify] https://crrev.com/065f56b4156b5661ca19221204994e6b41094d8a/components/autofill/core/browser/credit_card_save_manager.h
[modify] https://crrev.com/065f56b4156b5661ca19221204994e6b41094d8a/components/autofill/core/browser/strike_database.cc
[modify] https://crrev.com/065f56b4156b5661ca19221204994e6b41094d8a/components/autofill/core/browser/strike_database.h
[modify] https://crrev.com/065f56b4156b5661ca19221204994e6b41094d8a/components/autofill/core/common/autofill_constants.h
[modify] https://crrev.com/065f56b4156b5661ca19221204994e6b41094d8a/components/autofill/ios/browser/credit_card_save_manager_test_observer_bridge.h
[modify] https://crrev.com/065f56b4156b5661ca19221204994e6b41094d8a/components/autofill/ios/browser/credit_card_save_manager_test_observer_bridge.mm
[modify] https://crrev.com/065f56b4156b5661ca19221204994e6b41094d8a/ios/chrome/browser/ui/autofill/chrome_autofill_client_ios.mm
[modify] https://crrev.com/065f56b4156b5661ca19221204994e6b41094d8a/ios/chrome/browser/ui/autofill/save_card_infobar_egtest.mm
Project Member

Comment 20 by cr-audit...@appspot.gserviceaccount.com, Oct 24 

The following revision refers to this bug: 
https://chromium.googlesource.com/chromium/src.git/+/065f56b4156b5661ca19221204994e6b41094d8a

Commit: 065f56b4156b5661ca19221204994e6b41094d8a
Author: sebsg@chromium.org
Commiter: sebsg@chromium.org
Date: 2018-10-24 13:43:40 +0000 UTC

Merge-71 [Autofill] Add strikes when CC save ignored/denied/fails

This is a retry/relanding of
https://chromium-review.googlesource.com/c/chromium/src/+/1269524,
but with the browsertest additions removed, because something is causing
them to be flaky on Win7 builds.  Despite making progress, the original
CL has already been reverted twice, so I'd like to land this portion of
it so if it's reverted in the future, only the browsertests (done as a
subsequent CL) will be reverted instead of this big 18-file thing.

TBR=jsaul@google.com

(cherry picked from commit bb15c8040b58a4e7d9d3adf7729ebf9904d82e28)

Bug: 884817
Change-Id: I05983ff8b13c7dbac25e615bba8a5d1fa7cc0819
Reviewed-on: https://chromium-review.googlesource.com/c/1294429
Reviewed-by: Moe Ahmadi <mahmadi@chromium.org>
Reviewed-by: Evan Stade <estade@chromium.org>
Commit-Queue: Jared Saul <jsaul@google.com>
Cr-Original-Commit-Position: refs/heads/master@{#601720}
Reviewed-on: https://chromium-review.googlesource.com/c/1297727
Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Cr-Commit-Position: refs/branch-heads/3578@{#286}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}
Project Member

Comment 21 by cr-audit...@appspot.gserviceaccount.com, Oct 24 

Here's a summary of the rules that were executed: 
 - OnlyMergeApprovedChange: Rule Failed -- Revision 065f56b4156b5661ca19221204994e6b41094d8a was merged to refs/branch-heads/3578 branch with no merge approval from a TPM! 
Please explain why this change was merged to the branch!
 - AcknowledgeMerge: Notification Required --

Comment 22 by jsaul@google.com, Oct 24

Labels: -CommitLog-Audit-Violation -Merge-Without-Approval -merge-merged-3578 -Merge-Merged-71-3578
Apologies, the merge bug is  Issue 897965 , and approval *was* granted.  Removing incorrect labels...
Project Member

Comment 23 by bugdroid1@chromium.org, Oct 26 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2e55e7f1f6e3bbc23946ab48ebfd44d656e73e81

commit 2e55e7f1f6e3bbc23946ab48ebfd44d656e73e81
Author: Jared Saul <jsaul@google.com>
Date: Fri Oct 26 20:44:43 2018

[Autofill] Add Autofill StrikeDatabase switch to about_flags for iOS

Bug: 884817
Change-Id: Ie2535ee36d806801ecc98891c6ec37c53a339365
Reviewed-on: https://chromium-review.googlesource.com/c/1302329
Reviewed-by: Moe Ahmadi <mahmadi@chromium.org>
Commit-Queue: Jared Saul <jsaul@google.com>
Cr-Commit-Position: refs/heads/master@{#603185}
[modify] https://crrev.com/2e55e7f1f6e3bbc23946ab48ebfd44d656e73e81/ios/chrome/browser/about_flags.mm
[modify] https://crrev.com/2e55e7f1f6e3bbc23946ab48ebfd44d656e73e81/ios/chrome/browser/ios_chrome_flag_descriptions.cc
[modify] https://crrev.com/2e55e7f1f6e3bbc23946ab48ebfd44d656e73e81/ios/chrome/browser/ios_chrome_flag_descriptions.h
Project Member

Comment 24 by bugdroid1@chromium.org, Nov 5 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/dc7a451a22d3e98df2f754082d5f95f2c28c078b

commit dc7a451a22d3e98df2f754082d5f95f2c28c078b
Author: Jared Saul <jsaul@google.com>
Date: Mon Nov 05 23:07:36 2018

Add StrikeDatabase browsertests

The tests in this CL have been landed and reverted a couple of times;
they work, but end up being a little flaky on Win7. We've had a hard
time getting a reproducible setup, and the Chrome testing team have
verified our feature works as intended, so for the time being we're
marking the tests as flaky on Windows and will follow up.

(Sheriffs: If somehow the landing of this CL causes additional
flakes, feel free to revert. Flake analysis hasn't shown anything
outside of Win7.)

Bug: 884817
Change-Id: Iec545cb861bfc1aa3d50746c3a413257c9a9ec82
Reviewed-on: https://chromium-review.googlesource.com/c/1316666
Commit-Queue: Jared Saul <jsaul@google.com>
Reviewed-by: Evan Stade <estade@chromium.org>
Cr-Commit-Position: refs/heads/master@{#605507}
[modify] https://crrev.com/dc7a451a22d3e98df2f754082d5f95f2c28c078b/chrome/browser/ui/views/autofill/save_card_bubble_views_browsertest.cc
Project Member

Comment 25 by bugdroid1@chromium.org, Nov 6 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/24c124f39f00bf5b62d3c573d19c2518f8b15b7e

commit 24c124f39f00bf5b62d3c573d19c2518f8b15b7e
Author: Dmitry Titov <dimich@chromium.org>
Date: Tue Nov 06 02:51:43 2018

Revert "Add StrikeDatabase browsertests"

This reverts commit dc7a451a22d3e98df2f754082d5f95f2c28c078b.

Reason for revert: Broke tests on Mac (at least): https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mac10.12%20Tests/16499

Broken test output: https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8930653299367123984/+/steps/network_service_browser_tests_on_Intel_GPU_on_Mac_on_Mac-10.12.6/0/logs/SaveCardBubbleViewsFullFormBrowserTest.StrikeDatabase_Upload_AddStrikeIfSaveFails/0


Original change's description:
> Add StrikeDatabase browsertests
> 
> The tests in this CL have been landed and reverted a couple of times;
> they work, but end up being a little flaky on Win7. We've had a hard
> time getting a reproducible setup, and the Chrome testing team have
> verified our feature works as intended, so for the time being we're
> marking the tests as flaky on Windows and will follow up.
> 
> (Sheriffs: If somehow the landing of this CL causes additional
> flakes, feel free to revert. Flake analysis hasn't shown anything
> outside of Win7.)
> 
> Bug: 884817
> Change-Id: Iec545cb861bfc1aa3d50746c3a413257c9a9ec82
> Reviewed-on: https://chromium-review.googlesource.com/c/1316666
> Commit-Queue: Jared Saul <jsaul@google.com>
> Reviewed-by: Evan Stade <estade@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#605507}

TBR=estade@chromium.org,jsaul@google.com

Change-Id: I1e408b6395c80c425d982544bfdd88e01231db7b
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 884817
Reviewed-on: https://chromium-review.googlesource.com/c/1319190
Reviewed-by: Dmitry Titov <dimich@chromium.org>
Commit-Queue: Dmitry Titov <dimich@chromium.org>
Cr-Commit-Position: refs/heads/master@{#605579}
[modify] https://crrev.com/24c124f39f00bf5b62d3c573d19c2518f8b15b7e/chrome/browser/ui/views/autofill/save_card_bubble_views_browsertest.cc
Project Member

Comment 26 by bugdroid1@chromium.org, Nov 7 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e1a5c58c309f54a15104f156da81ee16b56c0918

commit e1a5c58c309f54a15104f156da81ee16b56c0918
Author: Jared Saul <jsaul@google.com>
Date: Wed Nov 07 18:30:02 2018

[Autofill] Add Autofill StrikeSystem to waterfall testing config

Bug: 884817
Change-Id: Iab61ac0b51d4541313f48263cadbfe2110fac543
Reviewed-on: https://chromium-review.googlesource.com/c/1321255
Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Commit-Queue: Jared Saul <jsaul@google.com>
Cr-Commit-Position: refs/heads/master@{#606087}
[modify] https://crrev.com/e1a5c58c309f54a15104f156da81ee16b56c0918/testing/variations/fieldtrial_testing_config.json
Project Member

Comment 27 by bugdroid1@chromium.org, Nov 8 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/aea3512db1445bf5aedcb33ca212bb75bb9aa1c5

commit aea3512db1445bf5aedcb33ca212bb75bb9aa1c5
Author: Hans Wennborg <hans@chromium.org>
Date: Thu Nov 08 15:07:37 2018

Revert "[Autofill] Add Autofill StrikeSystem to waterfall testing config"

This reverts commit e1a5c58c309f54a15104f156da81ee16b56c0918.

Reason for revert: Multiple reports of flakiness, see bugs.

Original change's description:
> [Autofill] Add Autofill StrikeSystem to waterfall testing config
> 
> Bug: 884817
> Change-Id: Iab61ac0b51d4541313f48263cadbfe2110fac543
> Reviewed-on: https://chromium-review.googlesource.com/c/1321255
> Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
> Commit-Queue: Jared Saul <jsaul@google.com>
> Cr-Commit-Position: refs/heads/master@{#606087}

TBR=rkaplow@chromium.org,jsaul@google.com

Change-Id: I6b8f3f6961891fc876900a574d2e3683fc63d5c0
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 884817,  903055 ,  903080 ,  903083 ,  903228 
Reviewed-on: https://chromium-review.googlesource.com/c/1326503
Reviewed-by: Hans Wennborg <hans@chromium.org>
Commit-Queue: Hans Wennborg <hans@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606466}
[modify] https://crrev.com/aea3512db1445bf5aedcb33ca212bb75bb9aa1c5/testing/variations/fieldtrial_testing_config.json
Project Member

Comment 28 by bugdroid1@chromium.org, Nov 12 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/49cdf9a248be775ea5ec0c128dd35d627cef2867

commit 49cdf9a248be775ea5ec0c128dd35d627cef2867
Author: Anne Lim <annelim@google.com>
Date: Mon Nov 12 19:47:09 2018

[AF] ClearStrikes when ios browser data cleared

Clears all strikes in a profile's StrikeDatabase when Autofill
data is wiped out from Chrome Settings in iOS
(chrome://settings -> Clear Browsing Data -> Advanced ->
Autofill Form Data).

Bug: 884817
Change-Id: Ic5065176f58d3785b9636c32df150801f583bb7d
Reviewed-on: https://chromium-review.googlesource.com/c/1323795
Reviewed-by: David Roger <droger@chromium.org>
Reviewed-by: Martin Šrámek <msramek@chromium.org>
Reviewed-by: Jared Saul <jsaul@google.com>
Commit-Queue: Anne Lim <annelim@google.com>
Cr-Commit-Position: refs/heads/master@{#607307}
[modify] https://crrev.com/49cdf9a248be775ea5ec0c128dd35d627cef2867/chrome/browser/browsing_data/chrome_browsing_data_remover_delegate.cc
[modify] https://crrev.com/49cdf9a248be775ea5ec0c128dd35d627cef2867/ios/chrome/browser/browsing_data/browsing_data_remover_impl.mm
Project Member

Comment 29 by bugdroid1@chromium.org, Nov 13 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5ba4cd1682069db3050b1e06f2d4d62c9d0675c2

commit 5ba4cd1682069db3050b1e06f2d4d62c9d0675c2
Author: Jared Saul <jsaul@google.com>
Date: Tue Nov 13 01:37:25 2018

[Autofill] Log metric when CC omnibox icon is shown but not prompt

When a card has max strikes on desktop, instead of showing the
offer-to-save bubble, only the omnibox icon is shown. This metric tracks
these occurrences.

Bug: 884817
Change-Id: I43f5cf0b1c9d6a3431790e8a2788bbf489fcdbe6
Reviewed-on: https://chromium-review.googlesource.com/c/1330898
Reviewed-by: Fabio Tirelo <ftirelo@chromium.org>
Commit-Queue: Jared Saul <jsaul@google.com>
Cr-Commit-Position: refs/heads/master@{#607414}
[modify] https://crrev.com/5ba4cd1682069db3050b1e06f2d4d62c9d0675c2/chrome/browser/ui/autofill/save_card_bubble_controller_impl.cc
[modify] https://crrev.com/5ba4cd1682069db3050b1e06f2d4d62c9d0675c2/chrome/browser/ui/autofill/save_card_bubble_controller_impl_unittest.cc
[modify] https://crrev.com/5ba4cd1682069db3050b1e06f2d4d62c9d0675c2/components/autofill/core/browser/autofill_metrics.h
[modify] https://crrev.com/5ba4cd1682069db3050b1e06f2d4d62c9d0675c2/tools/metrics/histograms/enums.xml
Project Member

Comment 30 by bugdroid1@chromium.org, Nov 13 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b5b99113feb4249e941fb738d7ba19fa8557c62b

commit b5b99113feb4249e941fb738d7ba19fa8557c62b
Author: Anne Lim <annelim@google.com>
Date: Tue Nov 13 19:45:05 2018

[Autofill] Rename existing strike_database files

Renamed strike_database.h/cc to legacy_strike_database.h/cc and
strike_database_unittest.cc to legacy_strike_database_unittest.cc.
This is so that the files for the  new version of StrikeDatabase
can take the old name.

Bug: 884817
Change-Id: Id4d1496b792d93f7e38afdab1ddad0419ec27f10
Reviewed-on: https://chromium-review.googlesource.com/c/1330724
Reviewed-by: Fabio Tirelo <ftirelo@chromium.org>
Reviewed-by: Martin Šrámek <msramek@chromium.org>
Reviewed-by: Moe Ahmadi <mahmadi@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Reviewed-by: Richard Coles <torne@chromium.org>
Reviewed-by: Jared Saul <jsaul@google.com>
Commit-Queue: Anne Lim <annelim@google.com>
Cr-Commit-Position: refs/heads/master@{#607707}
[modify] https://crrev.com/b5b99113feb4249e941fb738d7ba19fa8557c62b/android_webview/browser/aw_autofill_client.cc
[modify] https://crrev.com/b5b99113feb4249e941fb738d7ba19fa8557c62b/android_webview/browser/aw_autofill_client.h
[modify] https://crrev.com/b5b99113feb4249e941fb738d7ba19fa8557c62b/chrome/browser/BUILD.gn
[rename] https://crrev.com/b5b99113feb4249e941fb738d7ba19fa8557c62b/chrome/browser/autofill/legacy_strike_database_factory.cc
[add] https://crrev.com/b5b99113feb4249e941fb738d7ba19fa8557c62b/chrome/browser/autofill/legacy_strike_database_factory.h
[delete] https://crrev.com/0f7418d00aab1551c6006c04a32e9acc297009fc/chrome/browser/autofill/strike_database_factory.h
[modify] https://crrev.com/b5b99113feb4249e941fb738d7ba19fa8557c62b/chrome/browser/browsing_data/chrome_browsing_data_remover_delegate.cc
[modify] https://crrev.com/b5b99113feb4249e941fb738d7ba19fa8557c62b/chrome/browser/browsing_data/chrome_browsing_data_remover_delegate_unittest.cc
[modify] https://crrev.com/b5b99113feb4249e941fb738d7ba19fa8557c62b/chrome/browser/ui/autofill/chrome_autofill_client.cc
[modify] https://crrev.com/b5b99113feb4249e941fb738d7ba19fa8557c62b/chrome/browser/ui/autofill/chrome_autofill_client.h
[modify] https://crrev.com/b5b99113feb4249e941fb738d7ba19fa8557c62b/chrome/browser/ui/autofill/save_card_bubble_controller_impl.cc
[modify] https://crrev.com/b5b99113feb4249e941fb738d7ba19fa8557c62b/chrome/browser/ui/autofill/save_card_bubble_controller_impl.h
[modify] https://crrev.com/b5b99113feb4249e941fb738d7ba19fa8557c62b/components/autofill/core/browser/BUILD.gn
[modify] https://crrev.com/b5b99113feb4249e941fb738d7ba19fa8557c62b/components/autofill/core/browser/autofill_client.h
[modify] https://crrev.com/b5b99113feb4249e941fb738d7ba19fa8557c62b/components/autofill/core/browser/autofill_save_card_infobar_delegate_mobile.cc
[modify] https://crrev.com/b5b99113feb4249e941fb738d7ba19fa8557c62b/components/autofill/core/browser/autofill_save_card_infobar_delegate_mobile.h
[modify] https://crrev.com/b5b99113feb4249e941fb738d7ba19fa8557c62b/components/autofill/core/browser/credit_card_save_manager.cc
[modify] https://crrev.com/b5b99113feb4249e941fb738d7ba19fa8557c62b/components/autofill/core/browser/credit_card_save_manager_unittest.cc
[add] https://crrev.com/b5b99113feb4249e941fb738d7ba19fa8557c62b/components/autofill/core/browser/legacy_strike_database.cc
[rename] https://crrev.com/b5b99113feb4249e941fb738d7ba19fa8557c62b/components/autofill/core/browser/legacy_strike_database.h
[rename] https://crrev.com/b5b99113feb4249e941fb738d7ba19fa8557c62b/components/autofill/core/browser/legacy_strike_database_unittest.cc
[delete] https://crrev.com/0f7418d00aab1551c6006c04a32e9acc297009fc/components/autofill/core/browser/strike_database.cc
[modify] https://crrev.com/b5b99113feb4249e941fb738d7ba19fa8557c62b/components/autofill/core/browser/test_autofill_client.cc
[modify] https://crrev.com/b5b99113feb4249e941fb738d7ba19fa8557c62b/components/autofill/core/browser/test_autofill_client.h
[rename] https://crrev.com/b5b99113feb4249e941fb738d7ba19fa8557c62b/components/autofill/core/browser/test_legacy_strike_database.cc
[rename] https://crrev.com/b5b99113feb4249e941fb738d7ba19fa8557c62b/components/autofill/core/browser/test_legacy_strike_database.h
[modify] https://crrev.com/b5b99113feb4249e941fb738d7ba19fa8557c62b/components/autofill/core/common/autofill_constants.h
[modify] https://crrev.com/b5b99113feb4249e941fb738d7ba19fa8557c62b/ios/chrome/browser/autofill/BUILD.gn
[add] https://crrev.com/b5b99113feb4249e941fb738d7ba19fa8557c62b/ios/chrome/browser/autofill/legacy_strike_database_factory.cc
[add] https://crrev.com/b5b99113feb4249e941fb738d7ba19fa8557c62b/ios/chrome/browser/autofill/legacy_strike_database_factory.h
[delete] https://crrev.com/0f7418d00aab1551c6006c04a32e9acc297009fc/ios/chrome/browser/autofill/strike_database_factory.cc
[delete] https://crrev.com/0f7418d00aab1551c6006c04a32e9acc297009fc/ios/chrome/browser/autofill/strike_database_factory.h
[modify] https://crrev.com/b5b99113feb4249e941fb738d7ba19fa8557c62b/ios/chrome/browser/browsing_data/browsing_data_remover_impl.mm
[modify] https://crrev.com/b5b99113feb4249e941fb738d7ba19fa8557c62b/ios/chrome/browser/ios_chrome_flag_descriptions.h
[modify] https://crrev.com/b5b99113feb4249e941fb738d7ba19fa8557c62b/ios/chrome/browser/ui/autofill/chrome_autofill_client_ios.h
[modify] https://crrev.com/b5b99113feb4249e941fb738d7ba19fa8557c62b/ios/chrome/browser/ui/autofill/chrome_autofill_client_ios.mm
[modify] https://crrev.com/b5b99113feb4249e941fb738d7ba19fa8557c62b/ios/web_view/BUILD.gn
[modify] https://crrev.com/b5b99113feb4249e941fb738d7ba19fa8557c62b/ios/web_view/internal/autofill/cwv_autofill_controller.mm
[modify] https://crrev.com/b5b99113feb4249e941fb738d7ba19fa8557c62b/ios/web_view/internal/autofill/web_view_autofill_client_ios.h
[modify] https://crrev.com/b5b99113feb4249e941fb738d7ba19fa8557c62b/ios/web_view/internal/autofill/web_view_autofill_client_ios.mm
[add] https://crrev.com/b5b99113feb4249e941fb738d7ba19fa8557c62b/ios/web_view/internal/autofill/web_view_legacy_strike_database_factory.cc
[add] https://crrev.com/b5b99113feb4249e941fb738d7ba19fa8557c62b/ios/web_view/internal/autofill/web_view_legacy_strike_database_factory.h
[delete] https://crrev.com/0f7418d00aab1551c6006c04a32e9acc297009fc/ios/web_view/internal/autofill/web_view_strike_database_factory.cc
[delete] https://crrev.com/0f7418d00aab1551c6006c04a32e9acc297009fc/ios/web_view/internal/autofill/web_view_strike_database_factory.h
Project Member

Comment 31 by bugdroid1@chromium.org, Nov 21 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8ae6a515cd4857ea611201cad049cd88c2865822

commit 8ae6a515cd4857ea611201cad049cd88c2865822
Author: Anne Lim <annelim@google.com>
Date: Wed Nov 21 01:49:10 2018

[Autofill] New StrikeDatabase class/interface for v2

New StrikeDatabase class for the StrikeDatabase v2. It shares the
same existing ProtoDatabase as legacy_strike_database.h/cc which
is used as persistent storage, as well as an in-memory cache.
Virtual functions are also introduced, which are to be implemented
per project.

Bug: 884817
Change-Id: I48c38b17274ec440afd593dc48223b97c2b2d90e
Reviewed-on: https://chromium-review.googlesource.com/c/1334832
Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Reviewed-by: Jared Saul <jsaul@google.com>
Commit-Queue: Anne Lim <annelim@google.com>
Cr-Commit-Position: refs/heads/master@{#609887}
[modify] https://crrev.com/8ae6a515cd4857ea611201cad049cd88c2865822/components/autofill/core/browser/BUILD.gn
[add] https://crrev.com/8ae6a515cd4857ea611201cad049cd88c2865822/components/autofill/core/browser/strike_database.cc
[add] https://crrev.com/8ae6a515cd4857ea611201cad049cd88c2865822/components/autofill/core/browser/strike_database.h
[add] https://crrev.com/8ae6a515cd4857ea611201cad049cd88c2865822/components/autofill/core/browser/strike_database_unittest.cc
[add] https://crrev.com/8ae6a515cd4857ea611201cad049cd88c2865822/components/autofill/core/browser/test_strike_database.cc
[add] https://crrev.com/8ae6a515cd4857ea611201cad049cd88c2865822/components/autofill/core/browser/test_strike_database.h
[modify] https://crrev.com/8ae6a515cd4857ea611201cad049cd88c2865822/tools/metrics/histograms/histograms.xml
Project Member

Comment 32 by bugdroid1@chromium.org, Nov 23 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6c753cec155bf42d0655fe03ddf37acc3c89c960

commit 6c753cec155bf42d0655fe03ddf37acc3c89c960
Author: Daniel Bratell <bratell@opera.com>
Date: Fri Nov 23 14:01:37 2018

Give autofill's LegacyStrikeDatabas constants legacy names

In some (non default) jumbo configurations, strike.cc and
legacy_strike_database.cc compile in the same translation
unit and then some constants clash. Assuming
LegacyStrikeDatabase will soon go away, just give its
constants a bit longer names.

Bug: 884817
Change-Id: I1dc6d8b6499d3c6195a56423236198a02c32f3f0
Reviewed-on: https://chromium-review.googlesource.com/c/1348471
Commit-Queue: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#610594}
[modify] https://crrev.com/6c753cec155bf42d0655fe03ddf37acc3c89c960/components/autofill/core/browser/legacy_strike_database.cc
Project Member

Comment 33 by bugdroid1@chromium.org, Nov 28 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bf7bae040138061921eb788f6ddbe49305f0c073

commit bf7bae040138061921eb788f6ddbe49305f0c073
Author: Anne Lim <annelim@google.com>
Date: Wed Nov 28 00:43:08 2018

[Autofill] CreditCardSaveStrikeDatabase implementation

Created CreditCardSaveStrikeDatabase implementation of
StrikeDatabase, which is to be used to count strikes for credit
card saves.

Bug: 884817
Change-Id: I96b2b98894d06f97f6ea3bb24f3566cea273133f
Reviewed-on: https://chromium-review.googlesource.com/c/1349169
Commit-Queue: Anne Lim <annelim@google.com>
Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Reviewed-by: Jared Saul <jsaul@google.com>
Cr-Commit-Position: refs/heads/master@{#611466}
[modify] https://crrev.com/bf7bae040138061921eb788f6ddbe49305f0c073/components/autofill/core/browser/BUILD.gn
[add] https://crrev.com/bf7bae040138061921eb788f6ddbe49305f0c073/components/autofill/core/browser/credit_card_save_strike_database.cc
[add] https://crrev.com/bf7bae040138061921eb788f6ddbe49305f0c073/components/autofill/core/browser/credit_card_save_strike_database.h
[add] https://crrev.com/bf7bae040138061921eb788f6ddbe49305f0c073/components/autofill/core/browser/credit_card_save_strike_database_unittest.cc
[modify] https://crrev.com/bf7bae040138061921eb788f6ddbe49305f0c073/components/autofill/core/browser/strike_database.cc
[modify] https://crrev.com/bf7bae040138061921eb788f6ddbe49305f0c073/components/autofill/core/browser/strike_database.h
[add] https://crrev.com/bf7bae040138061921eb788f6ddbe49305f0c073/components/autofill/core/browser/test_credit_card_save_strike_database.cc
[add] https://crrev.com/bf7bae040138061921eb788f6ddbe49305f0c073/components/autofill/core/browser/test_credit_card_save_strike_database.h
Project Member

Comment 34 by bugdroid1@chromium.org, Nov 30 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c883abe3d453b8cee016a2b8a25ffcb2f2a2ff8f

commit c883abe3d453b8cee016a2b8a25ffcb2f2a2ff8f
Author: Anne Lim <annelim@google.com>
Date: Fri Nov 30 20:19:54 2018

[Autofill] Remove expired strikes on StrikeDB init

Added GetExpiryTime() to StrikeDatabase interface and removes
expired striked on StrikeDB init.

Bug: 884817
Change-Id: Ie99173b631f668f3be848f1afa925d7feec801ef
Reviewed-on: https://chromium-review.googlesource.com/c/1351887
Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Reviewed-by: Jared Saul <jsaul@google.com>
Commit-Queue: Anne Lim <annelim@google.com>
Cr-Commit-Position: refs/heads/master@{#612754}
[modify] https://crrev.com/c883abe3d453b8cee016a2b8a25ffcb2f2a2ff8f/components/autofill/core/browser/credit_card_save_strike_database.cc
[modify] https://crrev.com/c883abe3d453b8cee016a2b8a25ffcb2f2a2ff8f/components/autofill/core/browser/credit_card_save_strike_database.h
[modify] https://crrev.com/c883abe3d453b8cee016a2b8a25ffcb2f2a2ff8f/components/autofill/core/browser/credit_card_save_strike_database_unittest.cc
[modify] https://crrev.com/c883abe3d453b8cee016a2b8a25ffcb2f2a2ff8f/components/autofill/core/browser/strike_database.cc
[modify] https://crrev.com/c883abe3d453b8cee016a2b8a25ffcb2f2a2ff8f/components/autofill/core/browser/strike_database.h
[modify] https://crrev.com/c883abe3d453b8cee016a2b8a25ffcb2f2a2ff8f/components/autofill/core/browser/strike_database_unittest.cc
Project Member

Comment 35 by bugdroid1@chromium.org, Dec 8 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/565c28a3e27938b8fd4f638587b2c26895e4d547

commit 565c28a3e27938b8fd4f638587b2c26895e4d547
Author: Jared Saul <jsaul@google.com>
Date: Sat Dec 08 02:38:14 2018

[Autofill] Add SaveCardOfferUserDecision to save card callbacks

Instead of having CreditCardSaveManager be contacted via a callback
only whenever credit card save is accepted, this change causes it to
also be notified if the user ignored or outright rejected the credit
card save prompt.

This is required in order to implement iOS-based browsertests for the
StrikeDatabase system, but it also has the additional bonus of removing
calls to LegacyStrikeDatabase from UI code, placing them back in the
hands of CreditCardSaveManager (where they should be).

Bug: 884817
Change-Id: I84adfcf6520361613b107dedccd3849cc7a14671
Reviewed-on: https://chromium-review.googlesource.com/c/1357725
Commit-Queue: Jared Saul <jsaul@google.com>
Reviewed-by: Richard Coles <torne@chromium.org>
Reviewed-by: Evan Stade <estade@chromium.org>
Reviewed-by: Moe Ahmadi <mahmadi@chromium.org>
Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#614925}
[modify] https://crrev.com/565c28a3e27938b8fd4f638587b2c26895e4d547/android_webview/browser/aw_autofill_client.cc
[modify] https://crrev.com/565c28a3e27938b8fd4f638587b2c26895e4d547/android_webview/browser/aw_autofill_client.h
[modify] https://crrev.com/565c28a3e27938b8fd4f638587b2c26895e4d547/chrome/browser/autofill/autofill_save_card_infobar_delegate_mobile_unittest.cc
[modify] https://crrev.com/565c28a3e27938b8fd4f638587b2c26895e4d547/chrome/browser/ui/autofill/chrome_autofill_client.cc
[modify] https://crrev.com/565c28a3e27938b8fd4f638587b2c26895e4d547/chrome/browser/ui/autofill/chrome_autofill_client.h
[modify] https://crrev.com/565c28a3e27938b8fd4f638587b2c26895e4d547/chrome/browser/ui/autofill/save_card_bubble_controller_impl.cc
[modify] https://crrev.com/565c28a3e27938b8fd4f638587b2c26895e4d547/chrome/browser/ui/autofill/save_card_bubble_controller_impl.h
[modify] https://crrev.com/565c28a3e27938b8fd4f638587b2c26895e4d547/chrome/browser/ui/autofill/save_card_bubble_controller_impl_unittest.cc
[modify] https://crrev.com/565c28a3e27938b8fd4f638587b2c26895e4d547/chrome/browser/ui/views/autofill/save_card_bubble_views_browsertest_base.cc
[modify] https://crrev.com/565c28a3e27938b8fd4f638587b2c26895e4d547/chrome/browser/ui/views/autofill/save_card_bubble_views_browsertest_base.h
[modify] https://crrev.com/565c28a3e27938b8fd4f638587b2c26895e4d547/components/autofill/core/browser/autofill_client.h
[modify] https://crrev.com/565c28a3e27938b8fd4f638587b2c26895e4d547/components/autofill/core/browser/autofill_save_card_infobar_delegate_mobile.cc
[modify] https://crrev.com/565c28a3e27938b8fd4f638587b2c26895e4d547/components/autofill/core/browser/autofill_save_card_infobar_delegate_mobile.h
[modify] https://crrev.com/565c28a3e27938b8fd4f638587b2c26895e4d547/components/autofill/core/browser/credit_card_save_manager.cc
[modify] https://crrev.com/565c28a3e27938b8fd4f638587b2c26895e4d547/components/autofill/core/browser/credit_card_save_manager.h
[modify] https://crrev.com/565c28a3e27938b8fd4f638587b2c26895e4d547/components/autofill/core/browser/credit_card_save_manager_unittest.cc
[modify] https://crrev.com/565c28a3e27938b8fd4f638587b2c26895e4d547/components/autofill/core/browser/test_autofill_client.cc
[modify] https://crrev.com/565c28a3e27938b8fd4f638587b2c26895e4d547/components/autofill/core/browser/test_autofill_client.h
[modify] https://crrev.com/565c28a3e27938b8fd4f638587b2c26895e4d547/components/autofill/ios/browser/credit_card_save_manager_test_observer_bridge.h
[modify] https://crrev.com/565c28a3e27938b8fd4f638587b2c26895e4d547/components/autofill/ios/browser/credit_card_save_manager_test_observer_bridge.mm
[modify] https://crrev.com/565c28a3e27938b8fd4f638587b2c26895e4d547/ios/chrome/browser/ui/autofill/chrome_autofill_client_ios.h
[modify] https://crrev.com/565c28a3e27938b8fd4f638587b2c26895e4d547/ios/chrome/browser/ui/autofill/chrome_autofill_client_ios.mm
[modify] https://crrev.com/565c28a3e27938b8fd4f638587b2c26895e4d547/ios/chrome/browser/ui/autofill/save_card_infobar_egtest.mm
[modify] https://crrev.com/565c28a3e27938b8fd4f638587b2c26895e4d547/ios/web_view/internal/autofill/cwv_autofill_client_ios_bridge.h
[modify] https://crrev.com/565c28a3e27938b8fd4f638587b2c26895e4d547/ios/web_view/internal/autofill/cwv_autofill_controller.mm
[modify] https://crrev.com/565c28a3e27938b8fd4f638587b2c26895e4d547/ios/web_view/internal/autofill/web_view_autofill_client_ios.h
[modify] https://crrev.com/565c28a3e27938b8fd4f638587b2c26895e4d547/ios/web_view/internal/autofill/web_view_autofill_client_ios.mm
Project Member

Comment 36 by bugdroid1@chromium.org, Dec 18 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6cc36db5bc01e53f06b22add2ca6cc6a04423770

commit 6cc36db5bc01e53f06b22add2ca6cc6a04423770
Author: Anne Lim <annelim@google.com>
Date: Tue Dec 18 15:52:31 2018

[Autofill] StrikeDB Cache initialized in CCSM

StrikeDatabase is now a singleton which is initialized when CCSM is
initialized. Virtual per-project functions are moved into the
StrikeDatabaseIntegratorBase class, which has access to the StrikeDB
cache.

Bug: 884817
Change-Id: I786365d6763feb20876c0c60a75917708f750e00
Reviewed-on: https://chromium-review.googlesource.com/c/1377317
Reviewed-by: Olivier Robin <olivierrobin@chromium.org>
Reviewed-by: John Wu <jzw@chromium.org>
Reviewed-by: Evan Stade <estade@chromium.org>
Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Reviewed-by: Richard Coles <torne@chromium.org>
Reviewed-by: Jared Saul <jsaul@google.com>
Commit-Queue: Anne Lim <annelim@google.com>
Cr-Commit-Position: refs/heads/master@{#617503}
[modify] https://crrev.com/6cc36db5bc01e53f06b22add2ca6cc6a04423770/android_webview/browser/aw_autofill_client.cc
[modify] https://crrev.com/6cc36db5bc01e53f06b22add2ca6cc6a04423770/android_webview/browser/aw_autofill_client.h
[modify] https://crrev.com/6cc36db5bc01e53f06b22add2ca6cc6a04423770/chrome/browser/BUILD.gn
[add] https://crrev.com/6cc36db5bc01e53f06b22add2ca6cc6a04423770/chrome/browser/autofill/strike_database_factory.cc
[add] https://crrev.com/6cc36db5bc01e53f06b22add2ca6cc6a04423770/chrome/browser/autofill/strike_database_factory.h
[modify] https://crrev.com/6cc36db5bc01e53f06b22add2ca6cc6a04423770/chrome/browser/ui/autofill/chrome_autofill_client.cc
[modify] https://crrev.com/6cc36db5bc01e53f06b22add2ca6cc6a04423770/chrome/browser/ui/autofill/chrome_autofill_client.h
[modify] https://crrev.com/6cc36db5bc01e53f06b22add2ca6cc6a04423770/components/autofill/core/browser/BUILD.gn
[modify] https://crrev.com/6cc36db5bc01e53f06b22add2ca6cc6a04423770/components/autofill/core/browser/autofill_client.h
[modify] https://crrev.com/6cc36db5bc01e53f06b22add2ca6cc6a04423770/components/autofill/core/browser/credit_card_save_manager.cc
[modify] https://crrev.com/6cc36db5bc01e53f06b22add2ca6cc6a04423770/components/autofill/core/browser/credit_card_save_manager_unittest.cc
[modify] https://crrev.com/6cc36db5bc01e53f06b22add2ca6cc6a04423770/components/autofill/core/browser/credit_card_save_strike_database.cc
[modify] https://crrev.com/6cc36db5bc01e53f06b22add2ca6cc6a04423770/components/autofill/core/browser/credit_card_save_strike_database.h
[modify] https://crrev.com/6cc36db5bc01e53f06b22add2ca6cc6a04423770/components/autofill/core/browser/credit_card_save_strike_database_unittest.cc
[modify] https://crrev.com/6cc36db5bc01e53f06b22add2ca6cc6a04423770/components/autofill/core/browser/strike_database.cc
[modify] https://crrev.com/6cc36db5bc01e53f06b22add2ca6cc6a04423770/components/autofill/core/browser/strike_database.h
[add] https://crrev.com/6cc36db5bc01e53f06b22add2ca6cc6a04423770/components/autofill/core/browser/strike_database_integrator_base.cc
[add] https://crrev.com/6cc36db5bc01e53f06b22add2ca6cc6a04423770/components/autofill/core/browser/strike_database_integrator_base.h
[modify] https://crrev.com/6cc36db5bc01e53f06b22add2ca6cc6a04423770/components/autofill/core/browser/strike_database_unittest.cc
[modify] https://crrev.com/6cc36db5bc01e53f06b22add2ca6cc6a04423770/components/autofill/core/browser/test_autofill_client.cc
[modify] https://crrev.com/6cc36db5bc01e53f06b22add2ca6cc6a04423770/components/autofill/core/browser/test_autofill_client.h
[modify] https://crrev.com/6cc36db5bc01e53f06b22add2ca6cc6a04423770/components/autofill/core/browser/test_credit_card_save_strike_database.cc
[modify] https://crrev.com/6cc36db5bc01e53f06b22add2ca6cc6a04423770/components/autofill/core/browser/test_credit_card_save_strike_database.h
[modify] https://crrev.com/6cc36db5bc01e53f06b22add2ca6cc6a04423770/ios/chrome/browser/autofill/BUILD.gn
[add] https://crrev.com/6cc36db5bc01e53f06b22add2ca6cc6a04423770/ios/chrome/browser/autofill/strike_database_factory.cc
[add] https://crrev.com/6cc36db5bc01e53f06b22add2ca6cc6a04423770/ios/chrome/browser/autofill/strike_database_factory.h
[modify] https://crrev.com/6cc36db5bc01e53f06b22add2ca6cc6a04423770/ios/chrome/browser/ui/autofill/chrome_autofill_client_ios.h
[modify] https://crrev.com/6cc36db5bc01e53f06b22add2ca6cc6a04423770/ios/chrome/browser/ui/autofill/chrome_autofill_client_ios.mm
[modify] https://crrev.com/6cc36db5bc01e53f06b22add2ca6cc6a04423770/ios/web_view/BUILD.gn
[modify] https://crrev.com/6cc36db5bc01e53f06b22add2ca6cc6a04423770/ios/web_view/internal/autofill/cwv_autofill_controller.mm
[modify] https://crrev.com/6cc36db5bc01e53f06b22add2ca6cc6a04423770/ios/web_view/internal/autofill/web_view_autofill_client_ios.h
[modify] https://crrev.com/6cc36db5bc01e53f06b22add2ca6cc6a04423770/ios/web_view/internal/autofill/web_view_autofill_client_ios.mm
[add] https://crrev.com/6cc36db5bc01e53f06b22add2ca6cc6a04423770/ios/web_view/internal/autofill/web_view_strike_database_factory.cc
[add] https://crrev.com/6cc36db5bc01e53f06b22add2ca6cc6a04423770/ios/web_view/internal/autofill/web_view_strike_database_factory.h
Project Member

Comment 37 by bugdroid1@chromium.org, Jan 7 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9d8f66a9baadd509a480c66ee48e9e7d960c1cda

commit 9d8f66a9baadd509a480c66ee48e9e7d960c1cda
Author: Anne Lim <annelim@google.com>
Date: Mon Jan 07 23:49:21 2019

[Autofill] CC Save Integration of StrikeDB v2

Credit card uploads now checks strikes on StrikeDatabase v2 instead of
v1 if it is behind the kAutofillSaveCreditCardUsesStrikeSystem2 flag.

Bug: 884817
Change-Id: I0a7ce95ad728463927826071b5467c72166b5a17
Reviewed-on: https://chromium-review.googlesource.com/c/1385851
Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Reviewed-by: Jared Saul <jsaul@google.com>
Commit-Queue: Anne Lim <annelim@google.com>
Cr-Commit-Position: refs/heads/master@{#620536}
[modify] https://crrev.com/9d8f66a9baadd509a480c66ee48e9e7d960c1cda/chrome/browser/about_flags.cc
[modify] https://crrev.com/9d8f66a9baadd509a480c66ee48e9e7d960c1cda/chrome/browser/flag-metadata.json
[modify] https://crrev.com/9d8f66a9baadd509a480c66ee48e9e7d960c1cda/chrome/browser/flag_descriptions.cc
[modify] https://crrev.com/9d8f66a9baadd509a480c66ee48e9e7d960c1cda/chrome/browser/flag_descriptions.h
[modify] https://crrev.com/9d8f66a9baadd509a480c66ee48e9e7d960c1cda/components/autofill/core/browser/credit_card_save_manager.cc
[modify] https://crrev.com/9d8f66a9baadd509a480c66ee48e9e7d960c1cda/components/autofill/core/browser/credit_card_save_manager.h
[modify] https://crrev.com/9d8f66a9baadd509a480c66ee48e9e7d960c1cda/components/autofill/core/browser/credit_card_save_manager_unittest.cc
[modify] https://crrev.com/9d8f66a9baadd509a480c66ee48e9e7d960c1cda/components/autofill/core/browser/credit_card_save_strike_database.h
[modify] https://crrev.com/9d8f66a9baadd509a480c66ee48e9e7d960c1cda/components/autofill/core/browser/strike_database_integrator_base.h
[modify] https://crrev.com/9d8f66a9baadd509a480c66ee48e9e7d960c1cda/components/autofill/core/browser/test_credit_card_save_manager.cc
[modify] https://crrev.com/9d8f66a9baadd509a480c66ee48e9e7d960c1cda/components/autofill/core/browser/test_credit_card_save_manager.h
[modify] https://crrev.com/9d8f66a9baadd509a480c66ee48e9e7d960c1cda/components/autofill/core/common/autofill_features.cc
[modify] https://crrev.com/9d8f66a9baadd509a480c66ee48e9e7d960c1cda/components/autofill/core/common/autofill_features.h
[modify] https://crrev.com/9d8f66a9baadd509a480c66ee48e9e7d960c1cda/components/autofill/ios/browser/BUILD.gn
[modify] https://crrev.com/9d8f66a9baadd509a480c66ee48e9e7d960c1cda/ios/chrome/browser/about_flags.mm
[modify] https://crrev.com/9d8f66a9baadd509a480c66ee48e9e7d960c1cda/ios/chrome/browser/ios_chrome_flag_descriptions.cc
[modify] https://crrev.com/9d8f66a9baadd509a480c66ee48e9e7d960c1cda/ios/chrome/browser/ios_chrome_flag_descriptions.h
[modify] https://crrev.com/9d8f66a9baadd509a480c66ee48e9e7d960c1cda/ios/chrome/browser/ui/autofill/BUILD.gn
[modify] https://crrev.com/9d8f66a9baadd509a480c66ee48e9e7d960c1cda/tools/metrics/histograms/enums.xml
Project Member

Comment 38 by bugdroid1@chromium.org, Jan 10 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1f6ba121a2c1525e17838d6268edea5e7e39ca48

commit 1f6ba121a2c1525e17838d6268edea5e7e39ca48
Author: Anne Lim <annelim@google.com>
Date: Thu Jan 10 16:39:25 2019

[Autofill] CCSM init StrikeDB v2 only when flag on

Credit Card Save manager only initializes StrikeDB v2 on init
when flag for v2 is on.

Bug: 884817, 919832
Change-Id: Id181e8ebc06875221ed5695d6743d06141c438c5
Reviewed-on: https://chromium-review.googlesource.com/c/1403929
Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Reviewed-by: Jared Saul <jsaul@google.com>
Commit-Queue: Anne Lim <annelim@google.com>
Cr-Commit-Position: refs/heads/master@{#621600}
[modify] https://crrev.com/1f6ba121a2c1525e17838d6268edea5e7e39ca48/components/autofill/core/browser/credit_card_save_manager.cc
Project Member

Comment 39 by bugdroid1@chromium.org, Jan 18 (4 days ago) 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1974e1c98ca654f144410d4f5cf751f660ff249a

commit 1974e1c98ca654f144410d4f5cf751f660ff249a
Author: Anne Lim <annelim@google.com>
Date: Fri Jan 18 23:03:49 2019

[Autofill] Add Autofill StrikeSystem to FieldTrial

Bug: 884817
Change-Id: Id9ad9e372a9bf722e99a04fe4d9b37a5b7cd09f8
Reviewed-on: https://chromium-review.googlesource.com/c/1412994
Reviewed-by: Evan Stade <estade@chromium.org>
Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Reviewed-by: Jared Saul <jsaul@google.com>
Commit-Queue: Anne Lim <annelim@google.com>
Cr-Commit-Position: refs/heads/master@{#624337}
[modify] https://crrev.com/1974e1c98ca654f144410d4f5cf751f660ff249a/chrome/browser/ui/views/autofill/save_card_bubble_views_browsertest_base.cc
[modify] https://crrev.com/1974e1c98ca654f144410d4f5cf751f660ff249a/testing/variations/fieldtrial_testing_config.json
►

Sign in to add a comment