New issue
Advanced search Search tips

Issue 884791 link

Starred by 2 users

Issue metadata

Status: Duplicate
Merged: issue 901002
Owner:
Closed: Oct 26
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 2
Type: Bug



Sign in to add a comment

Can't dismiss "Relaunch Chrome within XXX days window"

Project Member Reported by shrike@chromium.org, Sep 17

Issue description

Chrome Version: 68.0.3440.106
OS: macOS 10.13

What steps will reproduce the problem?
(1) Leave Chrome as is until you get the Relaunch Chrome window
(2) Click the Got It button to dismiss the dialog


What is the expected result?
The Relaunch Chrome window goes away

What happens instead?
The Relaunch Chrome window stays onscreen. It appears that the only way to get rid of this window may be to click its Relaunch now button, which I do not want to do right now.



Please use labels and text to provide additional information.

If this is a regression (i.e., worked before), please consider using the
bisect tool (https://www.chromium.org/developers/bisect-builds-py) to help
us identify the root cause and more rapidly triage the issue.

For graphics-related bugs, please copy/paste the contents of the about:gpu
page at the end of this report.


 
Screen Shot 2018-09-17 at 10.46.11 AM.png
23.6 KB View Download
Components: -UI Internals>Installer
Labels: -Pri-3 Pri-2
Cc: robliao@chromium.org bsep@chromium.org
Owner: grt@chromium.org
Status: Started (was: Untriaged)
That ain't right. :-)

Since this is M68, maybe it's a macViews issue? robliao, bsep: any idea why a dialog created via constrained_window::CreateBrowserModalDialogViews wouldn't dismiss when its cancel button was pressed?

Do any of you happen to have a mac build handy? Could you try this:

browser_tests --gtest_filter=BrowserUiTest.Invoke --test-launcher-interactive --ui=RelaunchRequiredDialogViewDialogTest.InvokeUi_default

does the dialog dismiss on hitting "Got it" (it does for me on Windows)?
Hitting "Got it" dismisses the dialog and Chrome for me on Mac's browser_tests too.
Components: -Internals>Installer Enterprise
Labels: Enterprise-Triaged
Hmm. Could someone with a mac try browser_tests from the M69 branch point to see if it works there:

https://commondatastorage.googleapis.com/chromium-browser-snapshots/index.html?prefix=Mac/576753/

or even from M68 branch point:

https://commondatastorage.googleapis.com/chromium-browser-snapshots/index.html?prefix=Mac/561733/

Thanks.
Extracting both 561733 and 576753 and placing the browser_tests into their respective "Chromium Framework.framework" directories from the corresponding chrome-mac.zips, both version dismiss and close Chrome upon clicking "Got it"
I'm at a loss. Could there be something specific to finch configs in M68?

I'm tempted to close this out without any sort of repro. What do you think, shrike@?

Thanks for the investigative help, Rob.
Status: WontFix (was: Started)
Closing due to inactivity and lack of repro case.
Mergedinto: 901002
Status: Duplicate (was: WontFix)
Hmm, still happening.

Sign in to add a comment