New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 884788 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Oct 10
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocked on:
issue 892281

Blocking:
issue 634542



Sign in to add a comment

Use SkImage::makeColorSpace() in StaticBitmapImage::ConvertToColorSpace()

Project Member Reported by zakerinasab@chromium.org, Sep 17

Issue description

SkImage::makeColorSpace() always changes the backing storage to 8-8-8-8 pixel format (skia:8382). Whenever the respective Skia bug was fixed, change back the StaticBitmapImage::ConvertToColorSpace() code to directly use SkImage::makeColorSpace(). 
 

Comment 1 Deleted

This is not only a possible performance improvement. This roll back is important since SkImage::makeColorSpace() avoids GPU read back when the source is accelerated.
This is not causing a GPU read back anymore.
Status: WontFix (was: Assigned)
SkImage::makeColorSpace(), if ever fixed, is drawing on a surface internally, which is the same as what we do here.
Status: Assigned (was: WontFix)
Blockedon: -skia:8382 892281
We can fix this when switching to the new SkImage::makeColorSpace() behavior on Chromium is done.
Project Member

Comment 7 by bugdroid1@chromium.org, Oct 10

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0d3ac24352f61db94d75b38d3393eb8cebb8e545

commit 0d3ac24352f61db94d75b38d3393eb8cebb8e545
Author: Reza.Zakerinasab <zakerinasab@chromium.org>
Date: Wed Oct 10 17:28:14 2018

Use SkImage::makeColorSpace() in StaticBitmapImage::ConvertToColorSpace()

Bug:  884788 
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: Iad75ea106feaff1124eb80a543551b96c80d5188
Reviewed-on: https://chromium-review.googlesource.com/c/1273273
Reviewed-by: Fernando Serboncini <fserb@chromium.org>
Commit-Queue: Mohammad Reza Zakerinasab <zakerinasab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#598384}
[modify] https://crrev.com/0d3ac24352f61db94d75b38d3393eb8cebb8e545/third_party/blink/renderer/core/imagebitmap/image_bitmap.cc
[modify] https://crrev.com/0d3ac24352f61db94d75b38d3393eb8cebb8e545/third_party/blink/renderer/platform/graphics/static_bitmap_image.cc

Status: Fixed (was: Assigned)

Sign in to add a comment