Use SkImage::makeColorSpace() in StaticBitmapImage::ConvertToColorSpace() |
|||||
Issue descriptionSkImage::makeColorSpace() always changes the backing storage to 8-8-8-8 pixel format (skia:8382). Whenever the respective Skia bug was fixed, change back the StaticBitmapImage::ConvertToColorSpace() code to directly use SkImage::makeColorSpace().
,
Sep 17
This is not only a possible performance improvement. This roll back is important since SkImage::makeColorSpace() avoids GPU read back when the source is accelerated.
,
Sep 17
This is not causing a GPU read back anymore.
,
Sep 19
SkImage::makeColorSpace(), if ever fixed, is drawing on a surface internally, which is the same as what we do here.
,
Sep 24
,
Oct 9
We can fix this when switching to the new SkImage::makeColorSpace() behavior on Chromium is done.
,
Oct 10
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0d3ac24352f61db94d75b38d3393eb8cebb8e545 commit 0d3ac24352f61db94d75b38d3393eb8cebb8e545 Author: Reza.Zakerinasab <zakerinasab@chromium.org> Date: Wed Oct 10 17:28:14 2018 Use SkImage::makeColorSpace() in StaticBitmapImage::ConvertToColorSpace() Bug: 884788 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: Iad75ea106feaff1124eb80a543551b96c80d5188 Reviewed-on: https://chromium-review.googlesource.com/c/1273273 Reviewed-by: Fernando Serboncini <fserb@chromium.org> Commit-Queue: Mohammad Reza Zakerinasab <zakerinasab@chromium.org> Cr-Commit-Position: refs/heads/master@{#598384} [modify] https://crrev.com/0d3ac24352f61db94d75b38d3393eb8cebb8e545/third_party/blink/renderer/core/imagebitmap/image_bitmap.cc [modify] https://crrev.com/0d3ac24352f61db94d75b38d3393eb8cebb8e545/third_party/blink/renderer/platform/graphics/static_bitmap_image.cc
,
Oct 10
|
|||||
►
Sign in to add a comment |
|||||
Comment 1 Deleted