New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 884785 link

Starred by 1 user
Status: Fixed
Owner:
█ oka@chromium.org
Last visit > 30 days ago
Closed: Sep 21
Cc:
jclinton@chromium.org
bhthompson@google.com
nya@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment

webserver ebuild broken by GN upgrade

Project Member Reported by jclinton@chromium.org, Sep 17 
This CL broke the gale-paladin build in the N+1 ebuild after the CL successfully landed: https://chromium-review.googlesource.com/c/chromiumos/platform2/+/1221447

See failure: https://luci-milo.appspot.com/buildbot/chromeos/master-paladin/19633

Error message: webserver-0.0.1-r2010: FAILED: gen/include/libwebserv/dbus-proxies.h gen/include/libwebserv/dbus-mocks.h 

Marking gale-paladin as experimental.

Comment 2 Deleted

Comment 3 by oka@chromium.org, Sep 17 

Thank you for the revert.

Proto library was wrong. I made a fix. 
https://chromium-review.googlesource.com/c/chromiumos/platform2/+/1227866

Comment 4 by oka@chromium.org, Sep 17 

Well, no. Looks like dbus generator is also wrong.
I'm on it.

Comment 5 by oka@chromium.org, Sep 17

Status: Started (was: Assigned)

Comment 6 by jclinton@chromium.org, Sep 17

Components: -Infra>Client>ChromeOS>CI OS>Packages

Comment 7 by oka@chromium.org, Sep 18

Cc: jclinton@chromium.org bhthompson@google.com nya@chromium.org
Done anyone know how to reproduce the paladin test failure locally?

I couldn't reproduce it locally. What I've done are:
(0) exclude the revert change
(1) cros_sdk BOARD=gale
(2) cros_workon --board=$BOARD start webserver
(3) FEATURES=test USE=test emerge-$BOARD webserver
Project Member

Comment 8 by bugdroid1@chromium.org, Sep 19 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/e0931f8ff59aa6fb91c7ad4a36528ec3c7737b83

commit e0931f8ff59aa6fb91c7ad4a36528ec3c7737b83
Author: Keigo Oka <oka@chromium.org>
Date: Wed Sep 19 15:59:25 2018

common-mk: fix generate-dbus-proxies.gni

The sources should be rebased onto root_build_dir according to
`gn help action`.
This hopefully fix the  bug chromium:884785  .
CL:1230894 relands webserver depending on this CL.

TEST=The failure is not yet reproduced locally.
BUG=chromium:767517
BUG= chromium:884785 

Change-Id: I1ac4cc9ab894487b601030d562d38a48e0a00bff
Reviewed-on: https://chromium-review.googlesource.com/1230893
Commit-Ready: Keigo Oka <oka@chromium.org>
Tested-by: Keigo Oka <oka@chromium.org>
Reviewed-by: Keigo Oka <oka@chromium.org>
Reviewed-by: Shuhei Takahashi <nya@chromium.org>

[modify] https://crrev.com/e0931f8ff59aa6fb91c7ad4a36528ec3c7737b83/common-mk/generate-dbus-proxies.gni

Comment 9 by oka@chromium.org, Sep 21

Status: Fixed (was: Started)
gale-paladin is green after the CL is in.
►

Sign in to add a comment