New issue
Advanced search Search tips

Issue 884778 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Sep 26
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug-Security

Blocking:
issue 884511



Sign in to add a comment

dc: add a --sandbox flag

Project Member Reported by vapier@chromium.org, Sep 17

Issue description

since the bc package is getting pulled into images now, we should harden it a bit.  the dc program has a ! operator which grants access to system().  we should double check any other operations that it allows (related to file access).
 
Is there any known security vulnerabilities with dc? Otherwise we can probably track is a feature request bug, specific to security hardening.
Nevermind, now I see that this is fallout from the root exploit.
Owner: vapier@chromium.org
Status: Started (was: Available)
sent patches upstream for it, but bc tends to not be updated and doesn't have a real project page to speak of, so i'm just going to throw into Gentoo now
Cc: r...@rorym.cnamara.com
Labels: Security_Severity-High Security_Impact-Stable M-69 Target-69
Are 'bc' and 'dc' in the same package?
yep
Project Member

Comment 9 by bugdroid1@chromium.org, Sep 25

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/portage-stable/+/b33c3fb222f29060c0d80b6f4604d21c063f1e83

commit b33c3fb222f29060c0d80b6f4604d21c063f1e83
Author: Mike Frysinger <vapier@chromium.org>
Date: Tue Sep 25 18:58:27 2018

bc: upgrade to latest version

This brings in new sandbox features.

BUG= chromium:884778 
TEST=precq passes

Change-Id: I69d63db0d42f227064e866efc3f3cb60fc9f824e
Reviewed-on: https://chromium-review.googlesource.com/1229236
Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com>
Tested-by: Mike Frysinger <vapier@chromium.org>
Reviewed-by: Greg Kerr <kerrnel@chromium.org>

[delete] https://crrev.com/6e8abea3871768cec0e9b6f002d26d3bee3d3043/sys-devel/bc/bc-1.06.95.ebuild
[add] https://crrev.com/b33c3fb222f29060c0d80b6f4604d21c063f1e83/sys-devel/bc/bc-1.07.1-r2.ebuild
[modify] https://crrev.com/b33c3fb222f29060c0d80b6f4604d21c063f1e83/sys-devel/bc/Manifest
[add] https://crrev.com/b33c3fb222f29060c0d80b6f4604d21c063f1e83/sys-devel/bc/files/bc-1.07.1-no-ed-its-sed.patch
[add] https://crrev.com/b33c3fb222f29060c0d80b6f4604d21c063f1e83/sys-devel/bc/files/bc-1.07.1-sandbox.patch
[modify] https://crrev.com/b33c3fb222f29060c0d80b6f4604d21c063f1e83/sys-devel/bc/metadata.xml
[delete] https://crrev.com/6e8abea3871768cec0e9b6f002d26d3bee3d3043/sys-devel/bc/files/bc-1.06.95-void_uninitialized.patch
[add] https://crrev.com/b33c3fb222f29060c0d80b6f4604d21c063f1e83/sys-devel/bc/files/bc-1.07.1-use-system-bc.patch

Project Member

Comment 10 by bugdroid1@chromium.org, Sep 26

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/bcb61568d46dd20800e203016c1210befd937526

commit bcb61568d46dd20800e203016c1210befd937526
Author: Mike Frysinger <vapier@chromium.org>
Date: Wed Sep 26 17:33:06 2018

bc: enable USE=forced-sandbox

We have no need for the ! command in the dc program so disable it.

BUG= chromium:884778 
TEST=precq passes

Change-Id: Ia11d9a967d8e3587fce2926c302f8c0d7e6b6bff
Reviewed-on: https://chromium-review.googlesource.com/1229238
Commit-Ready: Mike Frysinger <vapier@chromium.org>
Tested-by: Mike Frysinger <vapier@chromium.org>
Reviewed-by: Greg Kerr <kerrnel@chromium.org>

[modify] https://crrev.com/bcb61568d46dd20800e203016c1210befd937526/profiles/targets/chromeos/package.use

Status: Fixed (was: Started)
this is done for R71, but i don't think it's worth backporting as this program shouldn't have been run the first place, and if people have arbitrary code exec, seems like dc doesn't make it worse.
Project Member

Comment 12 by sheriffbot@chromium.org, Sep 27

Labels: Restrict-View-SecurityNotify
Project Member

Comment 13 by sheriffbot@chromium.org, Jan 3

Labels: -Restrict-View-SecurityNotify allpublic
This bug has been closed for more than 14 weeks. Removing security view restrictions.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Sign in to add a comment