The assistant needs to be able to open a page from Ash and that page has a user activation so it can autoplay.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f59e6c6ab6bb5c639cdac94eea5a5cc9035dba12 commit f59e6c6ab6bb5c639cdac94eea5a5cc9035dba12 Author: Becca Hughes <beccahughes@chromium.org> Date: Mon Sep 24 18:52:51 2018 [Autoplay] Expose was activated to embedders Adds a WasActivatedOption to allow embedders to override the `was_activated` logic for browser initiated navigations. This is for when a user activation occurs on a surface outside of the page and we want this to be passed to a navigation as if this had occured on a previous page. BUG= 884777 Change-Id: Ifc7ce9352c3736d9e5c5c7d6909b3c5b2ead0cd8 Reviewed-on: https://chromium-review.googlesource.com/1228502 Reviewed-by: Camille Lamy <clamy@chromium.org> Reviewed-by: Greg Kerr <kerrnel@chromium.org> Reviewed-by: Peter Kasting <pkasting@chromium.org> Commit-Queue: Becca Hughes <beccahughes@chromium.org> Cr-Commit-Position: refs/heads/master@{#593614} [modify] https://crrev.com/f59e6c6ab6bb5c639cdac94eea5a5cc9035dba12/chrome/browser/media/unified_autoplay_browsertest.cc [modify] https://crrev.com/f59e6c6ab6bb5c639cdac94eea5a5cc9035dba12/chrome/browser/ui/browser_navigator.cc [modify] https://crrev.com/f59e6c6ab6bb5c639cdac94eea5a5cc9035dba12/chrome/browser/ui/browser_navigator_params.h [modify] https://crrev.com/f59e6c6ab6bb5c639cdac94eea5a5cc9035dba12/content/browser/frame_host/navigation_controller_impl.cc [modify] https://crrev.com/f59e6c6ab6bb5c639cdac94eea5a5cc9035dba12/content/browser/frame_host/navigation_controller_impl.h [modify] https://crrev.com/f59e6c6ab6bb5c639cdac94eea5a5cc9035dba12/content/browser/frame_host/navigation_request.cc [modify] https://crrev.com/f59e6c6ab6bb5c639cdac94eea5a5cc9035dba12/content/browser/frame_host/navigation_request.h [modify] https://crrev.com/f59e6c6ab6bb5c639cdac94eea5a5cc9035dba12/content/browser/frame_host/render_frame_host_manager_unittest.cc [modify] https://crrev.com/f59e6c6ab6bb5c639cdac94eea5a5cc9035dba12/content/common/frame_messages.h [modify] https://crrev.com/f59e6c6ab6bb5c639cdac94eea5a5cc9035dba12/content/common/navigation_params.h [modify] https://crrev.com/f59e6c6ab6bb5c639cdac94eea5a5cc9035dba12/content/public/browser/navigation_controller.cc [modify] https://crrev.com/f59e6c6ab6bb5c639cdac94eea5a5cc9035dba12/content/public/browser/navigation_controller.h [modify] https://crrev.com/f59e6c6ab6bb5c639cdac94eea5a5cc9035dba12/content/public/common/BUILD.gn [add] https://crrev.com/f59e6c6ab6bb5c639cdac94eea5a5cc9035dba12/content/public/common/was_activated_option.h [modify] https://crrev.com/f59e6c6ab6bb5c639cdac94eea5a5cc9035dba12/content/renderer/render_frame_impl.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/24b721cdc18ca04c7e911dcab842d08875e9d58c commit 24b721cdc18ca04c7e911dcab842d08875e9d58c Author: Becca Hughes <beccahughes@chromium.org> Date: Fri Sep 28 20:44:40 2018 [Autoplay] Fix assistant activation bug Adds a NewTabWithUserActivation method to open a new tab with a user activation. This means that the page will behave as if the user has interacted with it and autoplay will always be allowed. This CL also tweaks assistant to use it so that it can open tabs without the autoplay restriction. BUG= 884777 Change-Id: I7c9327b438ac51003442f0e97bd6e63086fb48cd Reviewed-on: https://chromium-review.googlesource.com/1239543 Reviewed-by: Ken Buchanan <kenrb@chromium.org> Reviewed-by: James Cook <jamescook@chromium.org> Commit-Queue: Becca Hughes <beccahughes@chromium.org> Cr-Commit-Position: refs/heads/master@{#595202} [modify] https://crrev.com/24b721cdc18ca04c7e911dcab842d08875e9d58c/ash/assistant/assistant_controller.cc [modify] https://crrev.com/24b721cdc18ca04c7e911dcab842d08875e9d58c/ash/dbus/url_handler_service_provider.cc [modify] https://crrev.com/24b721cdc18ca04c7e911dcab842d08875e9d58c/ash/new_window_controller.cc [modify] https://crrev.com/24b721cdc18ca04c7e911dcab842d08875e9d58c/ash/new_window_controller.h [modify] https://crrev.com/24b721cdc18ca04c7e911dcab842d08875e9d58c/ash/public/interfaces/new_window.mojom [modify] https://crrev.com/24b721cdc18ca04c7e911dcab842d08875e9d58c/chrome/browser/ui/ash/chrome_new_window_client.cc [modify] https://crrev.com/24b721cdc18ca04c7e911dcab842d08875e9d58c/chrome/browser/ui/ash/chrome_new_window_client.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e530beb07063584896937b37b70a5d9008bc6075 commit e530beb07063584896937b37b70a5d9008bc6075 Author: Becca Hughes <beccahughes@chromium.org> Date: Mon Oct 01 22:01:23 2018 [Autoplay] Persist user gesture before nav In some cases we have a gesture on a previous navigation but the `has_received_user_gesture` flag is not set so we should also check the `has_received_user_gesture_before_nav` flag too and allow propagation on the same eTLD+1. BUG= 884777 Change-Id: Iaabf03816bc4638f534321b1e9236bfa41d29938 Reviewed-on: https://chromium-review.googlesource.com/1255150 Reviewed-by: Avi Drissman <avi@chromium.org> Commit-Queue: Becca Hughes <beccahughes@chromium.org> Cr-Commit-Position: refs/heads/master@{#595551} [modify] https://crrev.com/e530beb07063584896937b37b70a5d9008bc6075/chrome/browser/media/unified_autoplay_browsertest.cc [modify] https://crrev.com/e530beb07063584896937b37b70a5d9008bc6075/content/browser/frame_host/frame_tree_node.h [modify] https://crrev.com/e530beb07063584896937b37b70a5d9008bc6075/content/browser/frame_host/navigation_request.cc
Comment 1 by johnpallett@chromium.org
, Sep 18