New issue
Advanced search Search tips

Issue 884770 link

Starred by 1 user
Status: Fixed
Owner:
steimel@chromium.org
Closed: Oct 15
Cc:
mlamouri@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , Chrome , Mac
Pri: 1
Type: Task


Show other hotlists

Hotlists containing this issue:
Modern-Media-Controls


Sign in to add a comment

Media Controls: Refactor unnecessary elements and event handling from the overlay play button

Project Member Reported by steimel@chromium.org, Sep 17 
The overlay play button currently contains the logic for double-tapping to ff/rw and double-tapping to go to fullscreen. It also contains the animated arrows that display during a ff/rw. We want to refactor that logic out of the overlay play button, and shrink the overlay play button down to the size of the button itself (so no unnecessary checks to see whether the button was actually clicked on).

doc: https://docs.google.com/document/d/1PANoNky7IWRidW_tTGM8tMsPMCeb2Ki_3x0W4-zOgY8/edit?usp=sharing

Comment 1 by steimel@chromium.org, Sep 17

Cc: -mlamo...@google.com mlamouri@chromium.org
Project Member

Comment 2 by bugdroid1@chromium.org, Sep 18 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8acb82c2c0a04010c460477b64d28f6cf010835c

commit 8acb82c2c0a04010c460477b64d28f6cf010835c
Author: Tommy Steimel <steimel@chromium.org>
Date: Tue Sep 18 17:54:36 2018

[Media Controls] Refactor AnimatedArrows out of the overlay play button

This CL removes the double-tap AnimatedArrows from the overlay play
button and adds them into a new MediaControlAnimatedArrowContainer
element. This is the first step of a refactoring of the overlay play
button to remove non-play-button-related logic and elements.

Bug:  884770 
Change-Id: I4d247a0178fd353b294d70c510b9b5b230220c68
Reviewed-on: https://chromium-review.googlesource.com/1228984
Reviewed-by: Becca Hughes <beccahughes@chromium.org>
Reviewed-by: Jeremy Roman <jbroman@chromium.org>
Commit-Queue: Tommy Steimel <steimel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#592104}
[modify] https://crrev.com/8acb82c2c0a04010c460477b64d28f6cf010835c/third_party/blink/renderer/modules/BUILD.gn
[modify] https://crrev.com/8acb82c2c0a04010c460477b64d28f6cf010835c/third_party/blink/renderer/modules/accessibility/ax_media_controls.cc
[modify] https://crrev.com/8acb82c2c0a04010c460477b64d28f6cf010835c/third_party/blink/renderer/modules/media_controls/BUILD.gn
[add] https://crrev.com/8acb82c2c0a04010c460477b64d28f6cf010835c/third_party/blink/renderer/modules/media_controls/elements/media_control_animated_arrow_container_element.cc
[add] https://crrev.com/8acb82c2c0a04010c460477b64d28f6cf010835c/third_party/blink/renderer/modules/media_controls/elements/media_control_animated_arrow_container_element.h
[rename] https://crrev.com/8acb82c2c0a04010c460477b64d28f6cf010835c/third_party/blink/renderer/modules/media_controls/elements/media_control_animated_arrow_container_element_test.cc
[modify] https://crrev.com/8acb82c2c0a04010c460477b64d28f6cf010835c/third_party/blink/renderer/modules/media_controls/elements/media_control_element_type.h
[modify] https://crrev.com/8acb82c2c0a04010c460477b64d28f6cf010835c/third_party/blink/renderer/modules/media_controls/elements/media_control_overlay_play_button_element.cc
[modify] https://crrev.com/8acb82c2c0a04010c460477b64d28f6cf010835c/third_party/blink/renderer/modules/media_controls/elements/media_control_overlay_play_button_element.h
[modify] https://crrev.com/8acb82c2c0a04010c460477b64d28f6cf010835c/third_party/blink/renderer/modules/media_controls/media_controls_impl.cc
[modify] https://crrev.com/8acb82c2c0a04010c460477b64d28f6cf010835c/third_party/blink/renderer/modules/media_controls/media_controls_impl.h
[modify] https://crrev.com/8acb82c2c0a04010c460477b64d28f6cf010835c/third_party/blink/renderer/modules/media_controls/media_controls_resource_loader.cc
[modify] https://crrev.com/8acb82c2c0a04010c460477b64d28f6cf010835c/third_party/blink/renderer/modules/media_controls/media_controls_resource_loader.h
[modify] https://crrev.com/8acb82c2c0a04010c460477b64d28f6cf010835c/third_party/blink/renderer/modules/media_controls/resources/media_controls_resources.grd
[modify] https://crrev.com/8acb82c2c0a04010c460477b64d28f6cf010835c/third_party/blink/renderer/modules/media_controls/resources/modernMediaControls.css
[rename] https://crrev.com/8acb82c2c0a04010c460477b64d28f6cf010835c/third_party/blink/renderer/modules/media_controls/resources/modernMediaControls_animated_arrow.css
Project Member

Comment 3 by bugdroid1@chromium.org, Sep 20 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2dfe550c2ef6712eecc39e0702246d27648bb646

commit 2dfe550c2ef6712eecc39e0702246d27648bb646
Author: Tommy Steimel <steimel@chromium.org>
Date: Thu Sep 20 22:45:32 2018

[Media Controls] Move doubletap handling to MediaControlsImpl

This CL removes the doubletap handling logic out of the overlay play
button and onto MediaControlsImpl. This allows us to shrink the overlay
play button down to only be the clickable area for play/pause,
simplifying the event handling logic and removing zoom calculations
that were crashing.

As a side effect, this CL also fixes an issue where the user couldn't
doubletap to fast-forward/rewind without first showing the controls.

Bug:  884770 ,  827535 
Change-Id: Ic5ff2b911d631bb10d10ac60a3b2e199ac2c3b01
Reviewed-on: https://chromium-review.googlesource.com/1235326
Reviewed-by: Becca Hughes <beccahughes@chromium.org>
Commit-Queue: Tommy Steimel <steimel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#592980}
[rename] https://crrev.com/2dfe550c2ef6712eecc39e0702246d27648bb646/third_party/WebKit/LayoutTests/media/controls/click-on-side-of-video-is-propagated.html
[modify] https://crrev.com/2dfe550c2ef6712eecc39e0702246d27648bb646/third_party/WebKit/LayoutTests/media/controls/modern/doubletap-to-jump-backwards-at-start.html
[modify] https://crrev.com/2dfe550c2ef6712eecc39e0702246d27648bb646/third_party/WebKit/LayoutTests/media/controls/modern/doubletap-to-jump-backwards.html
[modify] https://crrev.com/2dfe550c2ef6712eecc39e0702246d27648bb646/third_party/WebKit/LayoutTests/media/controls/modern/doubletap-to-jump-forwards-too-short.html
[modify] https://crrev.com/2dfe550c2ef6712eecc39e0702246d27648bb646/third_party/WebKit/LayoutTests/media/controls/modern/doubletap-to-jump-forwards.html
[modify] https://crrev.com/2dfe550c2ef6712eecc39e0702246d27648bb646/third_party/WebKit/LayoutTests/media/controls/modern/doubletap-to-toggle-fullscreen.html
[modify] https://crrev.com/2dfe550c2ef6712eecc39e0702246d27648bb646/third_party/WebKit/LayoutTests/media/controls/modern/slow-doubletap.html
[modify] https://crrev.com/2dfe550c2ef6712eecc39e0702246d27648bb646/third_party/WebKit/LayoutTests/media/controls/remove-on-click-does-not-crash.html
[modify] https://crrev.com/2dfe550c2ef6712eecc39e0702246d27648bb646/third_party/WebKit/LayoutTests/media/media-controls-tap-show-controls-without-activating.html
[modify] https://crrev.com/2dfe550c2ef6712eecc39e0702246d27648bb646/third_party/WebKit/LayoutTests/media/media-controls.js
[modify] https://crrev.com/2dfe550c2ef6712eecc39e0702246d27648bb646/third_party/WebKit/LayoutTests/paint/invalidation/video-paint-invalidation-expected.txt
[modify] https://crrev.com/2dfe550c2ef6712eecc39e0702246d27648bb646/third_party/WebKit/LayoutTests/platform/linux/compositing/video/video-controls-layer-creation-expected.png
[modify] https://crrev.com/2dfe550c2ef6712eecc39e0702246d27648bb646/third_party/WebKit/LayoutTests/platform/linux/fast/overflow/overflow-of-video-outline-expected.png
[modify] https://crrev.com/2dfe550c2ef6712eecc39e0702246d27648bb646/third_party/WebKit/LayoutTests/platform/linux/media/controls-after-reload-expected.txt
[modify] https://crrev.com/2dfe550c2ef6712eecc39e0702246d27648bb646/third_party/WebKit/LayoutTests/platform/linux/media/controls-layout-direction-expected.png
[modify] https://crrev.com/2dfe550c2ef6712eecc39e0702246d27648bb646/third_party/WebKit/LayoutTests/platform/linux/media/controls-strict-expected.txt
[modify] https://crrev.com/2dfe550c2ef6712eecc39e0702246d27648bb646/third_party/WebKit/LayoutTests/platform/linux/media/controls-styling-expected.txt
[modify] https://crrev.com/2dfe550c2ef6712eecc39e0702246d27648bb646/third_party/WebKit/LayoutTests/platform/linux/media/controls-styling-strict-expected.png
[modify] https://crrev.com/2dfe550c2ef6712eecc39e0702246d27648bb646/third_party/WebKit/LayoutTests/platform/linux/media/controls-styling-strict-expected.txt
[modify] https://crrev.com/2dfe550c2ef6712eecc39e0702246d27648bb646/third_party/WebKit/LayoutTests/platform/linux/media/controls-without-preload-expected.txt
[modify] https://crrev.com/2dfe550c2ef6712eecc39e0702246d27648bb646/third_party/WebKit/LayoutTests/platform/linux/media/controls/lazy-loaded-style-expected.txt
[modify] https://crrev.com/2dfe550c2ef6712eecc39e0702246d27648bb646/third_party/WebKit/LayoutTests/platform/linux/media/controls/paint-controls-webkit-appearance-none-custom-bg-expected.txt
[modify] https://crrev.com/2dfe550c2ef6712eecc39e0702246d27648bb646/third_party/WebKit/LayoutTests/platform/linux/media/controls/paint-controls-webkit-appearance-none-expected.txt
[modify] https://crrev.com/2dfe550c2ef6712eecc39e0702246d27648bb646/third_party/WebKit/LayoutTests/platform/linux/media/controls/video-controls-with-cast-rendering-expected.txt
[modify] https://crrev.com/2dfe550c2ef6712eecc39e0702246d27648bb646/third_party/WebKit/LayoutTests/platform/linux/media/media-controls-clone-expected.png
[modify] https://crrev.com/2dfe550c2ef6712eecc39e0702246d27648bb646/third_party/WebKit/LayoutTests/platform/linux/media/media-controls-grey-scrubber-expected.png
[modify] https://crrev.com/2dfe550c2ef6712eecc39e0702246d27648bb646/third_party/WebKit/LayoutTests/platform/linux/media/media-controls-grey-scrubber-expected.txt
[modify] https://crrev.com/2dfe550c2ef6712eecc39e0702246d27648bb646/third_party/WebKit/LayoutTests/platform/linux/media/video-controls-rendering-expected.txt
[modify] https://crrev.com/2dfe550c2ef6712eecc39e0702246d27648bb646/third_party/WebKit/LayoutTests/platform/linux/media/video-display-toggle-expected.txt
[modify] https://crrev.com/2dfe550c2ef6712eecc39e0702246d27648bb646/third_party/WebKit/LayoutTests/platform/linux/media/video-empty-source-expected.png
[modify] https://crrev.com/2dfe550c2ef6712eecc39e0702246d27648bb646/third_party/WebKit/LayoutTests/platform/linux/media/video-empty-source-expected.txt
[modify] https://crrev.com/2dfe550c2ef6712eecc39e0702246d27648bb646/third_party/WebKit/LayoutTests/platform/linux/media/video-no-audio-expected.txt
[modify] https://crrev.com/2dfe550c2ef6712eecc39e0702246d27648bb646/third_party/WebKit/LayoutTests/platform/linux/media/video-zoom-controls-expected.png
[modify] https://crrev.com/2dfe550c2ef6712eecc39e0702246d27648bb646/third_party/WebKit/LayoutTests/platform/linux/media/video-zoom-controls-expected.txt
[modify] https://crrev.com/2dfe550c2ef6712eecc39e0702246d27648bb646/third_party/WebKit/LayoutTests/platform/linux/virtual/android/fullscreen/full-screen-iframe-allowed-video-expected.png
[modify] https://crrev.com/2dfe550c2ef6712eecc39e0702246d27648bb646/third_party/WebKit/LayoutTests/platform/linux/virtual/android/fullscreen/video-controls-timeline-expected.png
[add] https://crrev.com/2dfe550c2ef6712eecc39e0702246d27648bb646/third_party/WebKit/LayoutTests/platform/linux/virtual/android/fullscreen/video-overlay-scroll-expected.txt
[modify] https://crrev.com/2dfe550c2ef6712eecc39e0702246d27648bb646/third_party/WebKit/LayoutTests/platform/linux/virtual/android/fullscreen/video-scrolled-iframe-expected.png
[modify] https://crrev.com/2dfe550c2ef6712eecc39e0702246d27648bb646/third_party/WebKit/LayoutTests/platform/linux/virtual/new-remote-playback-pipeline/media/controls/lazy-loaded-style-expected.txt
[modify] https://crrev.com/2dfe550c2ef6712eecc39e0702246d27648bb646/third_party/WebKit/LayoutTests/platform/linux/virtual/new-remote-playback-pipeline/media/controls/paint-controls-webkit-appearance-none-custom-bg-expected.txt
[modify] https://crrev.com/2dfe550c2ef6712eecc39e0702246d27648bb646/third_party/WebKit/LayoutTests/platform/linux/virtual/new-remote-playback-pipeline/media/controls/paint-controls-webkit-appearance-none-expected.txt
[modify] https://crrev.com/2dfe550c2ef6712eecc39e0702246d27648bb646/third_party/WebKit/LayoutTests/platform/linux/virtual/new-remote-playback-pipeline/media/controls/video-controls-with-cast-rendering-expected.txt
[modify] https://crrev.com/2dfe550c2ef6712eecc39e0702246d27648bb646/third_party/WebKit/LayoutTests/platform/linux/virtual/video-surface-layer/media/controls-after-reload-expected.txt
[modify] https://crrev.com/2dfe550c2ef6712eecc39e0702246d27648bb646/third_party/WebKit/LayoutTests/platform/linux/virtual/video-surface-layer/media/controls-layout-direction-expected.png
[modify] https://crrev.com/2dfe550c2ef6712eecc39e0702246d27648bb646/third_party/WebKit/LayoutTests/platform/linux/virtual/video-surface-layer/media/controls-strict-expected.txt
[modify] https://crrev.com/2dfe550c2ef6712eecc39e0702246d27648bb646/third_party/WebKit/LayoutTests/platform/linux/virtual/video-surface-layer/media/controls-styling-expected.txt
[modify] https://crrev.com/2dfe550c2ef6712eecc39e0702246d27648bb646/third_party/WebKit/LayoutTests/platform/linux/virtual/video-surface-layer/media/controls-styling-strict-expected.png
[modify] https://crrev.com/2dfe550c2ef6712eecc39e0702246d27648bb646/third_party/WebKit/LayoutTests/platform/linux/virtual/video-surface-layer/media/controls-styling-strict-expected.txt
[modify] https://crrev.com/2dfe550c2ef6712eecc39e0702246d27648bb646/third_party/WebKit/LayoutTests/platform/linux/virtual/video-surface-layer/media/controls-without-preload-expected.txt
[modify] https://crrev.com/2dfe550c2ef6712eecc39e0702246d27648bb646/third_party/WebKit/LayoutTests/platform/linux/virtual/video-surface-layer/media/controls/video-controls-with-cast-rendering-expected.txt
[modify] https://crrev.com/2dfe550c2ef6712eecc39e0702246d27648bb646/third_party/WebKit/LayoutTests/platform/linux/virtual/video-surface-layer/media/media-controls-clone-expected.png
[modify] https://crrev.com/2dfe550c2ef6712eecc39e0702246d27648bb646/third_party/WebKit/LayoutTests/platform/linux/virtual/video-surface-layer/media/media-controls-grey-scrubber-expected.png
[modify] https://crrev.com/2dfe550c2ef6712eecc39e0702246d27648bb646/third_party/WebKit/LayoutTests/platform/linux/virtual/video-surface-layer/media/media-controls-grey-scrubber-expected.txt
[modify] https://crrev.com/2dfe550c2ef6712eecc39e0702246d27648bb646/third_party/WebKit/LayoutTests/platform/linux/virtual/video-surface-layer/media/video-controls-rendering-expected.txt
[modify] https://crrev.com/2dfe550c2ef6712eecc39e0702246d27648bb646/third_party/WebKit/LayoutTests/platform/linux/virtual/video-surface-layer/media/video-display-toggle-expected.txt
[modify] https://crrev.com/2dfe550c2ef6712eecc39e0702246d27648bb646/third_party/WebKit/LayoutTests/platform/linux/virtual/video-surface-layer/media/video-empty-source-expected.png
[modify] https://crrev.com/2dfe550c2ef6712eecc39e0702246d27648bb646/third_party/WebKit/LayoutTests/platform/linux/virtual/video-surface-layer/media/video-empty-source-expected.txt
[modify] https://crrev.com/2dfe550c2ef6712eecc39e0702246d27648bb646/third_party/WebKit/LayoutTests/platform/linux/virtual/video-surface-layer/media/video-no-audio-expected.txt
[modify] https://crrev.com/2dfe550c2ef6712eecc39e0702246d27648bb646/third_party/WebKit/LayoutTests/platform/linux/virtual/video-surface-layer/media/video-zoom-controls-expected.png
[modify] https://crrev.com/2dfe550c2ef6712eecc39e0702246d27648bb646/third_party/WebKit/LayoutTests/platform/linux/virtual/video-surface-layer/media/video-zoom-controls-expected.txt
[modify] https://crrev.com/2dfe550c2ef6712eecc39e0702246d27648bb646/third_party/WebKit/LayoutTests/platform/mac-mac10.11/media/video-zoom-controls-expected.png
[modify] https://crrev.com/2dfe550c2ef6712eecc39e0702246d27648bb646/third_party/WebKit/LayoutTests/platform/mac-mac10.11/virtual/video-surface-layer/media/video-zoom-controls-expected.png
[modify] https://crrev.com/2dfe550c2ef6712eecc39e0702246d27648bb646/third_party/WebKit/LayoutTests/platform/mac-mac10.12/compositing/video/video-controls-layer-creation-expected.png
[modify] https://crrev.com/2dfe550c2ef6712eecc39e0702246d27648bb646/third_party/WebKit/LayoutTests/platform/mac-mac10.12/fast/overflow/overflow-of-video-outline-expected.png
[modify] https://crrev.com/2dfe550c2ef6712eecc39e0702246d27648bb646/third_party/WebKit/LayoutTests/platform/mac-mac10.12/media/controls-layout-direction-expected.png
[modify] https://crrev.com/2dfe550c2ef6712eecc39e0702246d27648bb646/third_party/WebKit/LayoutTests/platform/mac-mac10.12/media/controls-styling-strict-expected.png
[modify] https://crrev.com/2dfe550c2ef6712eecc39e0702246d27648bb646/third_party/WebKit/LayoutTests/platform/mac-mac10.12/media/controls/paint-controls-webkit-appearance-none-custom-bg-expected.png
[modify] https://crrev.com/2dfe550c2ef6712eecc39e0702246d27648bb646/third_party/WebKit/LayoutTests/platform/mac-mac10.12/media/controls/paint-controls-webkit-appearance-none-expected.png
[modify] https://crrev.com/2dfe550c2ef6712eecc39e0702246d27648bb646/third_party/WebKit/LayoutTests/platform/mac-mac10.12/media/media-controls-clone-expected.png
[modify] https://crrev.com/2dfe550c2ef6712eecc39e0702246d27648bb646/third_party/WebKit/LayoutTests/platform/mac-mac10.12/media/media-controls-grey-scrubber-expected.png
[modify] https://crrev.com/2dfe550c2ef6712eecc39e0702246d27648bb646/third_party/WebKit/LayoutTests/platform/mac-mac10.12/media/video-empty-source-expected.png
[modify] https://crrev.com/2dfe550c2ef6712eecc39e0702246d27648bb646/third_party/WebKit/LayoutTests/platform/mac-mac10.12/media/video-zoom-controls-expected.png
[modify] https://crrev.com/2dfe550c2ef6712eecc39e0702246d27648bb646/third_party/WebKit/LayoutTests/platform/mac-mac10.12/virtual/new-remote-playback-pipeline/media/controls/paint-controls-webkit-appearance-none-custom-bg-expected.png
[modify] https://crrev.com/2dfe550c2ef6712eecc39e0702246d27648bb646/third_party/WebKit/LayoutTests/platform/mac-mac10.12/virtual/new-remote-playback-pipeline/media/controls/paint-controls-webkit-appearance-none-expected.png
[modify] https://crrev.com/2dfe550c2ef6712eecc39e0702246d27648bb646/third_party/WebKit/LayoutTests/platform/mac-mac10.12/virtual/video-surface-layer/media/controls-layout-direction-expected.png
[modify] https://crrev.com/2dfe550c2ef6712eecc39e0702246d27648bb646/third_party/WebKit/LayoutTests/platform/mac-mac10.12/virtual/video-surface-layer/media/controls-styling-strict-expected.png
[modify] https://crrev.com/2dfe550c2ef6712eecc39e0702246d27648bb646/third_party/WebKit/LayoutTests/platform/mac-mac10.12/virtual/video-surface-layer/media/media-controls-clone-expected.png
[modify] https://crrev.com/2dfe550c2ef6712eecc39e0702246d27648bb646/third_party/WebKit/LayoutTests/platform/mac-mac10.12/virtual/video-surface-layer/media/media-controls-grey-scrubber-expected.png
[modify] https://crrev.com/2dfe550c2ef6712eecc39e0702246d27648bb646/third_party/WebKit/LayoutTests/platform/mac-mac10.12/virtual/video-surface-layer/media/video-empty-source-expected.png
[modify] https://crrev.com/2dfe550c2ef6712eecc39e0702246d27648bb646/third_party/WebKit/LayoutTests/platform/mac-mac10.12/virtual/video-surface-layer/media/video-zoom-controls-expected.png
[modify] https://crrev.com/2dfe550c2ef6712eecc39e0702246d27648bb646/third_party/WebKit/LayoutTests/platform/mac/compositing/video/video-controls-layer-creation-expected.png
[modify] https://crrev.com/2dfe550c2ef6712eecc39e0702246d27648bb646/third_party/WebKit/LayoutTests/platform/mac/fast/overflow/overflow-of-video-outline-expected.png
[modify] https://crrev.com/2dfe550c2ef6712eecc39e0702246d27648bb646/third_party/WebKit/LayoutTests/platform/mac/media/controls-after-reload-expected.txt
[modify] https://crrev.com/2dfe550c2ef6712eecc39e0702246d27648bb646/third_party/WebKit/LayoutTests/platform/mac/media/controls-layout-direction-expected.png
[modify] https://crrev.com/2dfe550c2ef6712eecc39e0702246d27648bb646/third_party/WebKit/LayoutTests/platform/mac/media/controls-strict-expected.txt
[modify] https://crrev.com/2dfe550c2ef6712eecc39e0702246d27648bb646/third_party/WebKit/LayoutTests/platform/mac/media/controls-styling-expected.txt
[modify] https://crrev.com/2dfe550c2ef6712eecc39e0702246d27648bb646/third_party/WebKit/LayoutTests/platform/mac/media/controls-styling-strict-expected.png
[modify] https://crrev.com/2dfe550c2ef6712eecc39e0702246d27648bb646/third_party/WebKit/LayoutTests/platform/mac/media/controls-styling-strict-expected.txt
[modify] https://crrev.com/2dfe550c2ef6712eecc39e0702246d27648bb646/third_party/WebKit/LayoutTests/platform/mac/media/controls-without-preload-expected.txt
[modify] https://crrev.com/2dfe550c2ef6712eecc39e0702246d27648bb646/third_party/WebKit/LayoutTests/platform/mac/media/controls/lazy-loaded-style-expected.txt
[modify] https://crrev.com/2dfe550c2ef6712eecc39e0702246d27648bb646/third_party/WebKit/LayoutTests/platform/mac/media/controls/paint-controls-webkit-appearance-none-custom-bg-expected.png
[modify] https://crrev.com/2dfe550c2ef6712eecc39e0702246d27648bb646/third_party/WebKit/LayoutTests/platform/mac/media/controls/paint-controls-webkit-appearance-none-custom-bg-expected.txt
[modify] https://crrev.com/2dfe550c2ef6712eecc39e0702246d27648bb646/third_party/WebKit/LayoutTests/platform/mac/media/controls/paint-controls-webkit-appearance-none-expected.png
[modify] https://crrev.com/2dfe550c2ef6712eecc39e0702246d27648bb646/third_party/WebKit/LayoutTests/platform/mac/media/controls/paint-controls-webkit-appearance-none-expected.txt
[modify] https://crrev.com/2dfe550c2ef6712eecc39e0702246d27648bb646/third_party/WebKit/LayoutTests/platform/mac/media/media-controls-clone-expected.png
[modify] https://crrev.com/2dfe550c2ef6712eecc39e0702246d27648bb646/third_party/WebKit/LayoutTests/platform/mac/media/media-controls-grey-scrubber-expected.png
[modify] https://crrev.com/2dfe550c2ef6712eecc39e0702246d27648bb646/third_party/WebKit/LayoutTests/platform/mac/media/media-controls-grey-scrubber-expected.txt
[modify] https://crrev.com/2dfe550c2ef6712eecc39e0702246d27648bb646/third_party/WebKit/LayoutTests/platform/mac/media/video-controls-rendering-expected.txt
[modify] https://crrev.com/2dfe550c2ef6712eecc39e0702246d27648bb646/third_party/WebKit/LayoutTests/platform/mac/media/video-display-toggle-expected.txt
[modify] https://crrev.com/2dfe550c2ef6712eecc39e0702246d27648bb646/third_party/WebKit/LayoutTests/platform/mac/media/video-empty-source-expected.png
[modify] https://crrev.com/2dfe550c2ef6712eecc39e0702246d27648bb646/third_party/WebKit/LayoutTests/platform/mac/media/video-empty-source-expected.txt
[modify] https://crrev.com/2dfe550c2ef6712eecc39e0702246d27648bb646/third_party/WebKit/LayoutTests/platform/mac/media/video-no-audio-expected.txt
[modify] https://crrev.com/2dfe550c2ef6712eecc39e0702246d27648bb646/third_party/WebKit/LayoutTests/platform/mac/media/video-zoom-controls-expected.png
[modify] https://crrev.com/2dfe550c2ef6712eecc39e0702246d27648bb646/third_party/WebKit/LayoutTests/platform/mac/media/video-zoom-controls-expected.txt
[modify] https://crrev.com/2dfe550c2ef6712eecc39e0702246d27648bb646/third_party/WebKit/LayoutTests/platform/mac/virtual/video-surface-layer/media/controls-after-reload-expected.txt
[modify] https://crrev.com/2dfe550c2ef6712eecc39e0702246d27648bb646/third_party/WebKit/LayoutTests/platform/mac/virtual/video-surface-layer/media/controls-strict-expected.txt
[modify] https://crrev.com/2dfe550c2ef6712eecc39e0702246d27648bb646/third_party/WebKit/LayoutTests/platform/mac/virtual/video-surface-layer/media/controls-styling-expected.txt
[modify] https://crrev.com/2dfe550c2ef6712eecc39e0702246d27648bb646/third_party/WebKit/LayoutTests/platform/mac/virtual/video-surface-layer/media/controls-styling-strict-expected.png
[modify] https://crrev.com/2dfe550c2ef6712eecc39e0702246d27648bb646/third_party/WebKit/LayoutTests/platform/mac/virtual/video-surface-layer/media/controls-styling-strict-expected.txt
[modify] https://crrev.com/2dfe550c2ef6712eecc39e0702246d27648bb646/third_party/WebKit/LayoutTests/platform/mac/virtual/video-surface-layer/media/controls-without-preload-expected.txt
[modify] https://crrev.com/2dfe550c2ef6712eecc39e0702246d27648bb646/third_party/WebKit/LayoutTests/platform/mac/virtual/video-surface-layer/media/video-controls-rendering-expected.txt
[modify] https://crrev.com/2dfe550c2ef6712eecc39e0702246d27648bb646/third_party/WebKit/LayoutTests/platform/mac/virtual/video-surface-layer/media/video-display-toggle-expected.txt
[modify] https://crrev.com/2dfe550c2ef6712eecc39e0702246d27648bb646/third_party/WebKit/LayoutTests/platform/mac/virtual/video-surface-layer/media/video-zoom-controls-expected.png
[modify] https://crrev.com/2dfe550c2ef6712eecc39e0702246d27648bb646/third_party/WebKit/LayoutTests/platform/mac/virtual/video-surface-layer/media/video-zoom-controls-expected.txt
[modify] https://crrev.com/2dfe550c2ef6712eecc39e0702246d27648bb646/third_party/WebKit/LayoutTests/platform/win/fast/overflow/overflow-of-video-outline-expected.png
[modify] https://crrev.com/2dfe550c2ef6712eecc39e0702246d27648bb646/third_party/WebKit/LayoutTests/platform/win/media/controls-after-reload-expected.txt
[modify] https://crrev.com/2dfe550c2ef6712eecc39e0702246d27648bb646/third_party/WebKit/LayoutTests/platform/win/media/controls-layout-direction-expected.png
[modify] https://crrev.com/2dfe550c2ef6712eecc39e0702246d27648bb646/third_party/WebKit/LayoutTests/platform/win/media/controls-strict-expected.txt
[modify] https://crrev.com/2dfe550c2ef6712eecc39e0702246d27648bb646/third_party/WebKit/LayoutTests/platform/win/media/controls-styling-expected.txt
[modify] https://crrev.com/2dfe550c2ef6712eecc39e0702246d27648bb646/third_party/WebKit/LayoutTests/platform/win/media/controls-styling-strict-expected.png
[modify] https://crrev.com/2dfe550c2ef6712eecc39e0702246d27648bb646/third_party/WebKit/LayoutTests/platform/win/media/controls-styling-strict-expected.txt
[modify] https://crrev.com/2dfe550c2ef6712eecc39e0702246d27648bb646/third_party/WebKit/LayoutTests/platform/win/media/controls-without-preload-expected.txt
[modify] https://crrev.com/2dfe550c2ef6712eecc39e0702246d27648bb646/third_party/WebKit/LayoutTests/platform/win/media/controls/lazy-loaded-style-expected.txt
[modify] https://crrev.com/2dfe550c2ef6712eecc39e0702246d27648bb646/third_party/WebKit/LayoutTests/platform/win/media/controls/paint-controls-webkit-appearance-none-custom-bg-expected.txt
[modify] https://crrev.com/2dfe550c2ef6712eecc39e0702246d27648bb646/third_party/WebKit/LayoutTests/platform/win/media/controls/paint-controls-webkit-appearance-none-expected.txt
[modify] https://crrev.com/2dfe550c2ef6712eecc39e0702246d27648bb646/third_party/WebKit/LayoutTests/platform/win/media/media-controls-clone-expected.png
[modify] https://crrev.com/2dfe550c2ef6712eecc39e0702246d27648bb646/third_party/WebKit/LayoutTests/platform/win/media/media-controls-grey-scrubber-expected.png
[modify] https://crrev.com/2dfe550c2ef6712eecc39e0702246d27648bb646/third_party/WebKit/LayoutTests/platform/win/media/media-controls-grey-scrubber-expected.txt
[modify] https://crrev.com/2dfe550c2ef6712eecc39e0702246d27648bb646/third_party/WebKit/LayoutTests/platform/win/media/video-controls-rendering-expected.txt
[modify] https://crrev.com/2dfe550c2ef6712eecc39e0702246d27648bb646/third_party/WebKit/LayoutTests/platform/win/media/video-display-toggle-expected.txt
[modify] https://crrev.com/2dfe550c2ef6712eecc39e0702246d27648bb646/third_party/WebKit/LayoutTests/platform/win/media/video-empty-source-expected.png
[modify] https://crrev.com/2dfe550c2ef6712eecc39e0702246d27648bb646/third_party/WebKit/LayoutTests/platform/win/media/video-empty-source-expected.txt
[modify] https://crrev.com/2dfe550c2ef6712eecc39e0702246d27648bb646/third_party/WebKit/LayoutTests/platform/win/media/video-no-audio-expected.txt
[modify] https://crrev.com/2dfe550c2ef6712eecc39e0702246d27648bb646/third_party/WebKit/LayoutTests/platform/win/media/video-zoom-controls-expected.png
[modify] https://crrev.com/2dfe550c2ef6712eecc39e0702246d27648bb646/third_party/WebKit/LayoutTests/platform/win/media/video-zoom-controls-expected.txt
[modify] https://crrev.com/2dfe550c2ef6712eecc39e0702246d27648bb646/third_party/WebKit/LayoutTests/platform/win/virtual/video-surface-layer/media/controls-after-reload-expected.txt
[modify] https://crrev.com/2dfe550c2ef6712eecc39e0702246d27648bb646/third_party/WebKit/LayoutTests/platform/win/virtual/video-surface-layer/media/controls-strict-expected.txt
[modify] https://crrev.com/2dfe550c2ef6712eecc39e0702246d27648bb646/third_party/WebKit/LayoutTests/platform/win/virtual/video-surface-layer/media/controls-styling-expected.txt
[modify] https://crrev.com/2dfe550c2ef6712eecc39e0702246d27648bb646/third_party/WebKit/LayoutTests/platform/win/virtual/video-surface-layer/media/controls-styling-
Project Member

Comment 4 by bugdroid1@chromium.org, Sep 24 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/61befe759f8326e212edc96c18a644dc905ae364

commit 61befe759f8326e212edc96c18a644dc905ae364
Author: Tommy Steimel <steimel@chromium.org>
Date: Mon Sep 24 23:50:04 2018

[Media Controls] Immersive mode styling fixes

This CL updates the immersive mode styles to handle the new overlay
play button positioning, as well as fixing an issue where the loading
spinner was incorrectly styled for immersive mode.

Bug:  884770 
Change-Id: I395bea19f0047deaf85e4923735418105f833def
Reviewed-on: https://chromium-review.googlesource.com/1241841
Reviewed-by: Becca Hughes <beccahughes@chromium.org>
Commit-Queue: Tommy Steimel <steimel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#593752}
[modify] https://crrev.com/61befe759f8326e212edc96c18a644dc905ae364/third_party/blink/renderer/modules/media_controls/resources/modernMediaControls.css
[modify] https://crrev.com/61befe759f8326e212edc96c18a644dc905ae364/third_party/blink/renderer/modules/media_controls/resources/modernMediaControls_loading.css

Comment 5 by mlamouri@chromium.org, Oct 11 

Is there anything else required here?

Comment 6 by steimel@chromium.org, Oct 15

Status: Fixed (was: Assigned)
I think this is done
►

Sign in to add a comment