M-70 failing to compile. |
|||
Issue description
Someone merged a CL without testing it probably. Just ccing a few people who touched the file.
In file included from ../../chromeos/services/assistant/assistant_manager_service_impl.cc:5:
In file included from ../../chromeos/services/assistant/assistant_manager_service_impl.h:20:
In file included from ../../chromeos/services/assistant/platform_api_impl.h:17:
../../chromeos/services/assistant/platform/system_provider_impl.h:29:19: error: unknown type name 'TpmProcessingType'
void ProcessTpm(TpmProcessingType type,
^
../../chromeos/services/assistant/platform/system_provider_impl.h:31:19: error: unknown type name 'TpmCallback'
TpmCallback on_done) override;
^
2 errors generated.
,
Sep 17
Is this on M70 branch or HEAD?
,
Sep 17
M70 branch
,
Sep 17
This should be HEAD.
,
Sep 17
Xiaohui, Does libassistant code got merged back to M70 or it automatically merged?
,
Sep 17
ProcessTpm was removed in new libassistant code. If libassistant code got merged back to M70, then we need to merge updated code [1] back to M70. [1] https://chromium-review.googlesource.com/c/chromium/src/+/1226203
,
Sep 17
Talked to newcomer@ and it should be a .gclient file setup issue.
,
Sep 17
Yep! Thanks much. |
|||
►
Sign in to add a comment |
|||
Comment 1 by newcomer@chromium.org
, Sep 17