New issue
Advanced search Search tips

Issue 884757 link

Starred by 0 users
Status: Fixed
Owner:
johnchen@chromium.org
Closed: Sep 18
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 2
Type: Bug



Sign in to add a comment

Merge request for ChromeDriver w3c mode flag handling bug fix

Project Member Reported by johnchen@chromium.org, Sep 17 
Requesting merge of https://chromium-review.googlesource.com/1227226 to m70 branch. This CL fixes a ChromeDriver bug in determining when to operate in W3C-compliant mode. This bug created difficulties for using ChromeDriver inside google3 environment, and will also cause problems for external users as WebDriver libraries move to better standard compliance. This fix was originally done under  issue chromedriver:2371 .

Note that these changes are in ChromeDriver directory (src/chrome/test/chromedriver), and Chrome does not depend on that at all, so these will have no impact on Chrome binary that is shipping. See go/chromedriver-versioning and go/chops-proj-rev-27 for background.
Project Member

Comment 1 by sheriffbot@chromium.org, Sep 17

Labels: -Merge-Request-70 Merge-Review-70 Hotlist-Merge-Review
This bug requires manual review: M70 has already been promoted to the beta branch, so this requires manual review
Please contact the milestone owner if you have questions.
Owners: benmason@(Android), kariahda@(iOS), geohsu@(ChromeOS), abdulsyed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 2 by abdulsyed@chromium.org, Sep 18

Labels: -Merge-Review-70 Merge-Approved-70
Project Member

Comment 3 by bugdroid1@chromium.org, Sep 18

Labels: -merge-approved-70 merge-merged-3538
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bdf77f2eff3f028758c2c293a477844c3506e4ce

commit bdf77f2eff3f028758c2c293a477844c3506e4ce
Author: John Chen <johnchen@chromium.org>
Date: Tue Sep 18 02:06:25 2018

[ChromeDriver] Improve W3C mode flag handling

While processing Init Session command, ChromeDriver now looks for W3C
mode flag at more locations, including capabilities.firstMatch and
desiredCapabilities. Also making it possible to change the default mode
using a single constant kW3CDefault.

Bug:  884757 ,  chromedriver:2371 
Change-Id: I674df3571f50762a595a02034bb891513cb10f9d
Reviewed-on: https://chromium-review.googlesource.com/1227226
Commit-Queue: John Chen <johnchen@chromium.org>
Reviewed-by: Caleb Rouleau <crouleau@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#591589}(cherry picked from commit d704de8c3703bbb4d8201423c521f17697b5f9e2)
Reviewed-on: https://chromium-review.googlesource.com/1228306
Cr-Commit-Position: refs/branch-heads/3538@{#470}
Cr-Branched-From: 79f7c91a2b2a2932cd447fa6f865cb6662fa8fa6-refs/heads/master@{#587811}
[modify] https://crrev.com/bdf77f2eff3f028758c2c293a477844c3506e4ce/chrome/test/chromedriver/commands.cc
[modify] https://crrev.com/bdf77f2eff3f028758c2c293a477844c3506e4ce/chrome/test/chromedriver/session.cc
[modify] https://crrev.com/bdf77f2eff3f028758c2c293a477844c3506e4ce/chrome/test/chromedriver/session.h
[modify] https://crrev.com/bdf77f2eff3f028758c2c293a477844c3506e4ce/chrome/test/chromedriver/session_commands.cc
[modify] https://crrev.com/bdf77f2eff3f028758c2c293a477844c3506e4ce/chrome/test/chromedriver/test/run_py_tests.py

Comment 4 by johnchen@chromium.org, Sep 18

Status: Fixed (was: Assigned)
►

Sign in to add a comment