New issue
Advanced search Search tips

Issue 884755 link

Starred by 0 users
Status: Fixed
Owner:
johnchen@chromium.org
Closed: Sep 18
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 2
Type: Bug



Sign in to add a comment

Merge request for ChromeDriver proxy configuration parsing bug fix

Project Member Reported by johnchen@chromium.org, Sep 17 
Requesting merge of https://chromium-review.googlesource.com/1226096 to m70 branch. This CL fixes a ChromeDriver bug in the parsing of proxy configuration capability, to make it conform to W3C standard. This bug created difficulties for using ChromeDriver inside google3 environment, and will also cause problems for external users as WebDriver libraries move to better standard compliance. This fix was originally done under  issue chromedriver:2537 .

Note that these changes are in ChromeDriver directory (src/chrome/test/chromedriver), and Chrome does not depend on that at all, so these will have no impact on Chrome binary that is shipping. See go/chromedriver-versioning and go/chops-proj-rev-27 for background.
Project Member

Comment 1 by sheriffbot@chromium.org, Sep 17

Labels: -Merge-Request-70 Merge-Review-70 Hotlist-Merge-Review
This bug requires manual review: M70 has already been promoted to the beta branch, so this requires manual review
Please contact the milestone owner if you have questions.
Owners: benmason@(Android), kariahda@(iOS), geohsu@(ChromeOS), abdulsyed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 2 by abdulsyed@chromium.org, Sep 18

Labels: -Merge-Review-70 Merge-Approved-70
Project Member

Comment 3 by bugdroid1@chromium.org, Sep 18

Labels: -merge-approved-70 merge-merged-3538
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b0c36d86f1a633520a93efa4d1f3b75c5c5849ad

commit b0c36d86f1a633520a93efa4d1f3b75c5c5849ad
Author: John Chen <johnchen@chromium.org>
Date: Tue Sep 18 02:06:11 2018

[ChromeDriver] W3C compliant parsing proxy setting

Update parsing of proxy settings in session capabilities, for W3C
compliance. Changes include:
* Handle noProxy containing a list of strings.
* Handle socksProxy and socksVersion.
* Return kInvalidArgument for errors.

Bug:  884755 ,  chromedriver:2537 
Change-Id: I545291b8249e147f75babee5dfe72137bfc4cdca
Reviewed-on: https://chromium-review.googlesource.com/1226096
Reviewed-by: Caleb Rouleau <crouleau@chromium.org>
Commit-Queue: John Chen <johnchen@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#591496}(cherry picked from commit 1b25ac3d1c6342ef8af34041dd545067b8f815bf)
Reviewed-on: https://chromium-review.googlesource.com/1228303
Cr-Commit-Position: refs/branch-heads/3538@{#469}
Cr-Branched-From: 79f7c91a2b2a2932cd447fa6f865cb6662fa8fa6-refs/heads/master@{#587811}
[modify] https://crrev.com/b0c36d86f1a633520a93efa4d1f3b75c5c5849ad/chrome/test/chromedriver/capabilities.cc
[modify] https://crrev.com/b0c36d86f1a633520a93efa4d1f3b75c5c5849ad/chrome/test/chromedriver/capabilities_unittest.cc

Comment 4 by johnchen@chromium.org, Sep 18

Status: Fixed (was: Assigned)
►

Sign in to add a comment