New issue
Advanced search Search tips

Issue 884752 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Sep 26
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug
M71



Sign in to add a comment

[Print preview refresh] Line height for validation errors

Project Member Reported by namratakannan@chromium.org, Sep 17

Issue description

Increase line height for validation errors from 10px to 12px.

 
Existing-error.png
20.1 KB View Download
Desired-error.png
21.6 KB View Download
Project Member

Comment 1 by bugdroid1@chromium.org, Sep 20

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e6113ed7a9644d287e512d78a17a08be0c7e2818

commit e6113ed7a9644d287e512d78a17a08be0c7e2818
Author: rbpotter <rbpotter@chromium.org>
Date: Thu Sep 20 00:33:35 2018

Print Preview Refresh: Fix error handling

(1) Make errors expand/contract rather than pre-allocating space
(2) Adjust padding so that padding is always 16px regardless of error
state
(3) Fix an issue with pages error not appearing when radio button is
reselected
(4) Make error line-height correct.
(5) Other changes to ensure labels stay correctly aligned with
controls regardless of control height.
(6) No hand pointer on error text.

Bug:  884752 ,  884729 ,  884603 ,  884640 ,  885039 
Change-Id: I9ff4e0bbc536b0890687b678cf52640c01e5a2ef
Reviewed-on: https://chromium-review.googlesource.com/1229618
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Reviewed-by: Scott Chen <scottchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#592629}
[modify] https://crrev.com/e6113ed7a9644d287e512d78a17a08be0c7e2818/chrome/browser/resources/print_preview/new/copies_settings.html
[modify] https://crrev.com/e6113ed7a9644d287e512d78a17a08be0c7e2818/chrome/browser/resources/print_preview/new/number_settings_section.html
[modify] https://crrev.com/e6113ed7a9644d287e512d78a17a08be0c7e2818/chrome/browser/resources/print_preview/new/number_settings_section.js
[modify] https://crrev.com/e6113ed7a9644d287e512d78a17a08be0c7e2818/chrome/browser/resources/print_preview/new/pages_settings.html
[modify] https://crrev.com/e6113ed7a9644d287e512d78a17a08be0c7e2818/chrome/browser/resources/print_preview/new/pages_settings.js
[modify] https://crrev.com/e6113ed7a9644d287e512d78a17a08be0c7e2818/chrome/browser/resources/print_preview/new/print_preview_shared_css.html
[modify] https://crrev.com/e6113ed7a9644d287e512d78a17a08be0c7e2818/chrome/browser/resources/print_preview/new/scaling_settings.html
[modify] https://crrev.com/e6113ed7a9644d287e512d78a17a08be0c7e2818/chrome/browser/resources/print_preview/new/scaling_settings.js
[modify] https://crrev.com/e6113ed7a9644d287e512d78a17a08be0c7e2818/chrome/test/data/webui/print_preview/new_print_preview_ui_browsertest.js
[modify] https://crrev.com/e6113ed7a9644d287e512d78a17a08be0c7e2818/chrome/test/data/webui/print_preview/pages_settings_test.js
[modify] https://crrev.com/e6113ed7a9644d287e512d78a17a08be0c7e2818/chrome/test/data/webui/print_preview/print_preview_interactive_ui_tests.js
[modify] https://crrev.com/e6113ed7a9644d287e512d78a17a08be0c7e2818/chrome/test/data/webui/print_preview/settings_section_test.js
[modify] https://crrev.com/e6113ed7a9644d287e512d78a17a08be0c7e2818/chrome/test/data/webui/print_preview/system_dialog_browsertest.js
[modify] https://crrev.com/e6113ed7a9644d287e512d78a17a08be0c7e2818/testing/buildbot/filters/webui_polymer2_browser_tests.filter
[modify] https://crrev.com/e6113ed7a9644d287e512d78a17a08be0c7e2818/testing/buildbot/filters/webui_polymer2_interactive_ui_tests.filter
[modify] https://crrev.com/e6113ed7a9644d287e512d78a17a08be0c7e2818/ui/webui/resources/cr_elements/cr_input/cr_input.html
[modify] https://crrev.com/e6113ed7a9644d287e512d78a17a08be0c7e2818/ui/webui/resources/cr_elements/shared_vars_css.html

Cc: namratakannan@chromium.org
Status: Fixed (was: Available)
Should be fixed, please verify and re-open if not.
Verified

Sign in to add a comment