[Print preview refresh] Change destination has two scrollbars |
|||
Issue descriptionCan we have only one scrollbar for the Change destination modal, instead of two. This scrollbar can control scroll for entire modal.
,
Sep 17
Yup! That would work great as well. Thanks Rebekah
,
Sep 18
Issue 885118 has been merged into this issue.
,
Sep 21
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/fa2e08937a5c741634ebb903330a5e46986a4532 commit fa2e08937a5c741634ebb903330a5e46986a4532 Author: rbpotter <rbpotter@chromium.org> Date: Fri Sep 21 17:54:21 2018 Print Preview Refresh: Fix iron-list sizing Fix the sizing of the print destinations list so that it is always set to the maximum of the available space and 3 destinations of height. This will ensure there is no double scrollbar unless the dialog is extremely short. Bug: 884741 Change-Id: Ieba1a4e634d667b2e6e5567cf6f80f5962bd0fde Reviewed-on: https://chromium-review.googlesource.com/1235120 Reviewed-by: Scott Chen <scottchen@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#593250} [modify] https://crrev.com/fa2e08937a5c741634ebb903330a5e46986a4532/chrome/browser/resources/print_preview/new/destination_dialog.html [modify] https://crrev.com/fa2e08937a5c741634ebb903330a5e46986a4532/chrome/browser/resources/print_preview/new/destination_dialog.js [modify] https://crrev.com/fa2e08937a5c741634ebb903330a5e46986a4532/chrome/browser/resources/print_preview/new/destination_list.html [modify] https://crrev.com/fa2e08937a5c741634ebb903330a5e46986a4532/chrome/browser/resources/print_preview/new/destination_list.js [modify] https://crrev.com/fa2e08937a5c741634ebb903330a5e46986a4532/chrome/browser/resources/print_preview/new/print_preview_shared_css.html
,
Sep 26
Should now be fixed, please verify and re-open if not.
,
Sep 27
Verified |
|||
►
Sign in to add a comment |
|||
Comment 1 by rbpotter@chromium.org
, Sep 17