Issue 884739 link

Starred by 1 user

Issue metadata

Status:	Fixed
Owner:	rbpotter@chromium.org
Closed:	Sep 26
Cc:	namratakannan@chromium.org
Components:	UI>Browser>PrintPreview
EstimatedDays:	----
NextAction:	----
OS:	----
Pri:	2
Type:	Bug
M71

[Print preview refresh] Change the hover and pressed state color for More settings

Project Member Reported by namratakannan@chromium.org, Sep 17

Issue description

Current More settings displays button like behavior.
Behavior should be similar to languages in settings (expansion panel). Hover and pressed state color for More settings:

1. Pressed/focus state for icon button-GG 900,15%
2. Remove ripple from pressed state.
3. Focus state on icon and not on entire More settings

	More settings.png 208 KB View Download

Project Member

Comment 1 by bugdroid1@chromium.org, Sep 19

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/81dad65fc78501a5355fb175fb291173d5a0b3b1

commit 81dad65fc78501a5355fb175fb291173d5a0b3b1
Author: rbpotter <rbpotter@chromium.org>
Date: Wed Sep 19 23:31:28 2018

Print Preview refresh: Fix more settings styling

Bug:  884739 ,  884632 ,  885043 
Change-Id: I59303415e30a288c8adc2799a06500f33e60ddee
Reviewed-on: https://chromium-review.googlesource.com/1231253
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#592606}
[modify] https://crrev.com/81dad65fc78501a5355fb175fb291173d5a0b3b1/chrome/browser/resources/print_preview/new/BUILD.gn
[modify] https://crrev.com/81dad65fc78501a5355fb175fb291173d5a0b3b1/chrome/browser/resources/print_preview/new/more_settings.html
[modify] https://crrev.com/81dad65fc78501a5355fb175fb291173d5a0b3b1/chrome/browser/resources/print_preview/new/more_settings.js

Comment 2 by rbpotter@chromium.org, Sep 26

Cc: namratakannan@chromium.org
Status: Fixed (was: Available)

Should be fixed, please verify and re-open if not.

Comment 3 by namratakannan@google.com, Sep 27

Verified

►

Issue 884739 link

Issue metadata

[Print preview refresh] Change the hover and pressed state color for More settings

Issue description

Comment 1 by bugdroid1@chromium.org, Sep 19

Comment 1 Deleted

Comment 2 by rbpotter@chromium.org, Sep 26

Comment 2 Deleted

Comment 3 by namratakannan@google.com, Sep 27

Comment 3 Deleted

Sign in to add a comment