1. Below the last row in the print preview settings increase the padding. Can we try 16px or 24px? 2. Change padding between Print using system dialog and More settings (16px) Refer spec: https://print-preview---local-spec-dot-show.googleplex.com/print-preview---local-spec:7/
Also reduce padding after Pages (custom) and Copies to original (16px from 24px). Expand when there is an error vs keeping additional padding aka existing print preview behavior.
Lastly, reduce padding after Scale to match padding between remaining settings under Advanced settings (16px). Increase padding after Background graphics (8px) Refer: https://print-preview-advanced-dot-show.googleplex.com/print-preview-advanced:5/
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/740492f9aba228edd794d7bd9d148d0929895a54 commit 740492f9aba228edd794d7bd9d148d0929895a54 Author: rbpotter <rbpotter@chromium.org> Date: Wed Sep 19 23:55:35 2018 Print Preview refresh: Fix some issues with the link container Fixes some padding and focus issues in and around the link-container. (1) Correct padding above and below link-container (2) Make icon focusable rather than the entire row (3) Restore shortcut in system dialog string (4) Make icon not focusable when disabled (5) Correct padding in other-options-settings Bug: 884729 , 885102 , 884605 Change-Id: I0c8e1ac700ef93a4c6e247329d66285386af9f9f Reviewed-on: https://chromium-review.googlesource.com/1231826 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#592614} [modify] https://crrev.com/740492f9aba228edd794d7bd9d148d0929895a54/chrome/app/printing_strings.grdp [modify] https://crrev.com/740492f9aba228edd794d7bd9d148d0929895a54/chrome/browser/resources/print_preview/new/advanced_options_settings.html [modify] https://crrev.com/740492f9aba228edd794d7bd9d148d0929895a54/chrome/browser/resources/print_preview/new/app.html [modify] https://crrev.com/740492f9aba228edd794d7bd9d148d0929895a54/chrome/browser/resources/print_preview/new/link_container.html [modify] https://crrev.com/740492f9aba228edd794d7bd9d148d0929895a54/chrome/browser/resources/print_preview/new/link_container.js [modify] https://crrev.com/740492f9aba228edd794d7bd9d148d0929895a54/chrome/browser/resources/print_preview/new/other_options_settings.html [modify] https://crrev.com/740492f9aba228edd794d7bd9d148d0929895a54/chrome/browser/resources/print_preview/new/other_options_settings.js [modify] https://crrev.com/740492f9aba228edd794d7bd9d148d0929895a54/chrome/browser/ui/webui/print_preview/print_preview_ui.cc [modify] https://crrev.com/740492f9aba228edd794d7bd9d148d0929895a54/chrome/test/data/webui/print_preview/system_dialog_browsertest.js
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e6113ed7a9644d287e512d78a17a08be0c7e2818 commit e6113ed7a9644d287e512d78a17a08be0c7e2818 Author: rbpotter <rbpotter@chromium.org> Date: Thu Sep 20 00:33:35 2018 Print Preview Refresh: Fix error handling (1) Make errors expand/contract rather than pre-allocating space (2) Adjust padding so that padding is always 16px regardless of error state (3) Fix an issue with pages error not appearing when radio button is reselected (4) Make error line-height correct. (5) Other changes to ensure labels stay correctly aligned with controls regardless of control height. (6) No hand pointer on error text. Bug: 884752 , 884729 , 884603 , 884640 , 885039 Change-Id: I9ff4e0bbc536b0890687b678cf52640c01e5a2ef Reviewed-on: https://chromium-review.googlesource.com/1229618 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by: Scott Chen <scottchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#592629} [modify] https://crrev.com/e6113ed7a9644d287e512d78a17a08be0c7e2818/chrome/browser/resources/print_preview/new/copies_settings.html [modify] https://crrev.com/e6113ed7a9644d287e512d78a17a08be0c7e2818/chrome/browser/resources/print_preview/new/number_settings_section.html [modify] https://crrev.com/e6113ed7a9644d287e512d78a17a08be0c7e2818/chrome/browser/resources/print_preview/new/number_settings_section.js [modify] https://crrev.com/e6113ed7a9644d287e512d78a17a08be0c7e2818/chrome/browser/resources/print_preview/new/pages_settings.html [modify] https://crrev.com/e6113ed7a9644d287e512d78a17a08be0c7e2818/chrome/browser/resources/print_preview/new/pages_settings.js [modify] https://crrev.com/e6113ed7a9644d287e512d78a17a08be0c7e2818/chrome/browser/resources/print_preview/new/print_preview_shared_css.html [modify] https://crrev.com/e6113ed7a9644d287e512d78a17a08be0c7e2818/chrome/browser/resources/print_preview/new/scaling_settings.html [modify] https://crrev.com/e6113ed7a9644d287e512d78a17a08be0c7e2818/chrome/browser/resources/print_preview/new/scaling_settings.js [modify] https://crrev.com/e6113ed7a9644d287e512d78a17a08be0c7e2818/chrome/test/data/webui/print_preview/new_print_preview_ui_browsertest.js [modify] https://crrev.com/e6113ed7a9644d287e512d78a17a08be0c7e2818/chrome/test/data/webui/print_preview/pages_settings_test.js [modify] https://crrev.com/e6113ed7a9644d287e512d78a17a08be0c7e2818/chrome/test/data/webui/print_preview/print_preview_interactive_ui_tests.js [modify] https://crrev.com/e6113ed7a9644d287e512d78a17a08be0c7e2818/chrome/test/data/webui/print_preview/settings_section_test.js [modify] https://crrev.com/e6113ed7a9644d287e512d78a17a08be0c7e2818/chrome/test/data/webui/print_preview/system_dialog_browsertest.js [modify] https://crrev.com/e6113ed7a9644d287e512d78a17a08be0c7e2818/testing/buildbot/filters/webui_polymer2_browser_tests.filter [modify] https://crrev.com/e6113ed7a9644d287e512d78a17a08be0c7e2818/testing/buildbot/filters/webui_polymer2_interactive_ui_tests.filter [modify] https://crrev.com/e6113ed7a9644d287e512d78a17a08be0c7e2818/ui/webui/resources/cr_elements/cr_input/cr_input.html [modify] https://crrev.com/e6113ed7a9644d287e512d78a17a08be0c7e2818/ui/webui/resources/cr_elements/shared_vars_css.html
Should be fixed, please verify and re-open if not.
Verified
Comment 1 by namratakannan@chromium.org
, Sep 17