New issue
Advanced search Search tips

Issue 884722 link

Starred by 0 users

Issue metadata

Status: Fixed
Owner:
Closed: Sep 27
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 2
Type: Bug

Blocking:
issue 884716



Sign in to add a comment

🚿Remove all usage of IsRefreshInfobarEnabled()

Project Member Reported by marq@chromium.org, Sep 17

Issue description

Tracking bug for the removal of IsRefreshInfobarEnabled()
 
Summary: 🚿Remove all usage of IsRefreshInfobarEnabled() (was: 🚿Remove all usage of IsRecentTabsUIRebootEnabled())
Blocking: 884716
Description: Show this description
Components: UI>Browser
Owner: marq@chromium.org
Status: Started
Project Member

Comment 7 by bugdroid1@chromium.org, Sep 27

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/095286637df4ee5fe482c4119288f57fb2e7a9d8

commit 095286637df4ee5fe482c4119288f57fb2e7a9d8
Author: Mark Cogan <marq@google.com>
Date: Thu Sep 27 10:09:06 2018

[iOS] Remove IsRefreshInfobarEnabled()

This CL removes the IsRefreshInfobarEnabled() flag function and refactors code around its use.

Bug:  884722 
Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
Change-Id: I90dea9cf5e196f455eda1fe516140daa8ad68a8c
Reviewed-on: https://chromium-review.googlesource.com/1245366
Commit-Queue: Mark Cogan <marq@chromium.org>
Reviewed-by: Peter Lee <pkl@chromium.org>
Cr-Commit-Position: refs/heads/master@{#594654}
[modify] https://crrev.com/095286637df4ee5fe482c4119288f57fb2e7a9d8/ios/chrome/browser/ui/autofill/BUILD.gn
[modify] https://crrev.com/095286637df4ee5fe482c4119288f57fb2e7a9d8/ios/chrome/browser/ui/autofill/save_card_infobar_controller.mm
[modify] https://crrev.com/095286637df4ee5fe482c4119288f57fb2e7a9d8/ios/chrome/browser/ui/autofill/save_card_infobar_view.mm
[modify] https://crrev.com/095286637df4ee5fe482c4119288f57fb2e7a9d8/ios/chrome/browser/ui/infobars/BUILD.gn
[modify] https://crrev.com/095286637df4ee5fe482c4119288f57fb2e7a9d8/ios/chrome/browser/ui/infobars/confirm_infobar_view.mm
[modify] https://crrev.com/095286637df4ee5fe482c4119288f57fb2e7a9d8/ios/chrome/browser/ui/infobars/resources/BUILD.gn
[delete] https://crrev.com/b0a1ee9e4b748a979cfd456ef34585ec31ca8db5/ios/chrome/browser/ui/infobars/resources/infobar_shadow.imageset/Contents.json
[delete] https://crrev.com/b0a1ee9e4b748a979cfd456ef34585ec31ca8db5/ios/chrome/browser/ui/infobars/resources/infobar_shadow.imageset/infobar_shadow.png
[delete] https://crrev.com/b0a1ee9e4b748a979cfd456ef34585ec31ca8db5/ios/chrome/browser/ui/infobars/resources/infobar_shadow.imageset/infobar_shadow@2x.png
[modify] https://crrev.com/095286637df4ee5fe482c4119288f57fb2e7a9d8/ios/chrome/browser/ui/ui_util.h
[modify] https://crrev.com/095286637df4ee5fe482c4119288f57fb2e7a9d8/ios/chrome/browser/ui/ui_util.mm

Status: Fixed (was: Started)
Project Member

Comment 9 by bugdroid1@chromium.org, Sep 27

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5db2221360c1372961f85f51b78dd844538544de

commit 5db2221360c1372961f85f51b78dd844538544de
Author: Mark Cogan <marq@google.com>
Date: Thu Sep 27 13:53:03 2018

[iOS] Move infobar close image

Move infobar_close into downloads/, which is the only place where it's
used, and rename it.

Bug:  884722 
Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
Change-Id: I539058203790b7ba7b0e28e94e989ce32e0e95fd
Reviewed-on: https://chromium-review.googlesource.com/1248704
Commit-Queue: Mark Cogan <marq@chromium.org>
Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#594708}
[modify] https://crrev.com/5db2221360c1372961f85f51b78dd844538544de/ios/chrome/browser/ui/download/BUILD.gn
[modify] https://crrev.com/5db2221360c1372961f85f51b78dd844538544de/ios/chrome/browser/ui/download/download_manager_view_controller.mm
[modify] https://crrev.com/5db2221360c1372961f85f51b78dd844538544de/ios/chrome/browser/ui/download/resources/BUILD.gn
[rename] https://crrev.com/5db2221360c1372961f85f51b78dd844538544de/ios/chrome/browser/ui/download/resources/download_close.imageset/Contents.json
[rename] https://crrev.com/5db2221360c1372961f85f51b78dd844538544de/ios/chrome/browser/ui/download/resources/download_close.imageset/download_close.png
[rename] https://crrev.com/5db2221360c1372961f85f51b78dd844538544de/ios/chrome/browser/ui/download/resources/download_close.imageset/download_close@2x.png
[rename] https://crrev.com/5db2221360c1372961f85f51b78dd844538544de/ios/chrome/browser/ui/download/resources/download_close.imageset/download_close@3x.png
[modify] https://crrev.com/5db2221360c1372961f85f51b78dd844538544de/ios/chrome/browser/ui/infobars/BUILD.gn
[modify] https://crrev.com/5db2221360c1372961f85f51b78dd844538544de/ios/chrome/browser/ui/infobars/resources/BUILD.gn

Sign in to add a comment