Issue metadata
Sign in to add a comment
|
Tryjob checkboxes don't update as filters are changed in Buildbucket plugin |
||||||||||||||||||||||
Issue descriptionUsing the web interface to Choose Tryjobs: 1) Type something in the filter box that changes the initially visible list of tryjobs. 2) Click the box next to one of the shown tryjobs. 3) Select the filter text and erase it (Backspace) 4) The list of tryjobs shows resets to the default, but the checkbox that was clicked in #2 will remain checked, even though it's now next to a new/different job. At this point, after doing "enough" interaction with the filter, the option that seemed to be checked in #4 will no longer be checked, but I've also seen both the real item (#2) and the wrong item (#4) checked at the same time, if filtering causes them both to show up. I also can't get this to fail in the other direction (by checking a box, then filtering to jump elsewhere in the list).
,
Sep 17
https://chromium-review.googlesource.com/c/infra/gerrit-plugins/buildbucket/+/1228422
,
Sep 17
Issue 866185 has been merged into this issue.
,
Sep 17
Issue 855966 has been merged into this issue.
,
Sep 17
The following revision refers to this bug: https://chromium.googlesource.com/infra/gerrit-plugins/buildbucket/+/de11c14e11a9e1d193e7b47c6865612a520da0cc commit de11c14e11a9e1d193e7b47c6865612a520da0cc Author: Nodir Turakulov <nodir@google.com> Date: Mon Sep 17 20:13:04 2018 [buildbucket] Fix typo in checked binding Bug: 884704 Change-Id: I663ca7e7364780d07fb41a2a0b7c031d6360120b Reviewed-on: https://chromium-review.googlesource.com/1228422 Reviewed-by: Ryan Tseng <hinoka@chromium.org> [modify] https://crrev.com/de11c14e11a9e1d193e7b47c6865612a520da0cc/src/main/resources/static/cr-tryjob-picker.html
,
Sep 17
,
Sep 19
deployed
,
Sep 19
This appears to be fixed. Thanks! Was the bug filed on Jun 11 in the wrong place, let me know if I could have done anything differently. Thanks.
,
Sep 19
ah sorry I did not see the earlier one, I should have probably duped my bug filed on Jul 20 into the earlier one? Just let me know if I was using the wrong component or labels. Thanks!
,
Sep 19
the correct component for buildbucket-gerrit plugin is Infra>Platform>Buildbucket>Gerrit. i think you did everything right. It would be unreasonable to expect anyone to guess correct components, especially when gerrit suggests a different component. Even most infra people didn't know the correct component. The latency of the fix has nothing to do with this. |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by rmis...@google.com
, Sep 17Components: -Infra Infra>Platform>Buildbucket>Gerrit
Labels: -Restrict-View-Google
Owner: no...@chromium.org
Status: Assigned (was: Untriaged)
Summary: Tryjob checkboxes don't update as filters are changed in Buildbucket plugin (was: Tryjob checkboxes don't update as filters are changed)