New issue
Advanced search Search tips

Issue 884691 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Sep 17
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug



Sign in to add a comment

[📍] Pinpoint job fail on compilation

Project Member Reported by cbruni@chromium.org, Sep 17

Issue description

Currently all my pinpoint perf tryjobs fail with an seemingly unrelated compilation error


Pinpoint Page: https://pinpoint-dot-chromeperf.appspot.com/job/10f6a595640000
Job: https://ci.chromium.org/buildbot/tryserver.chromium.perf/Linux%20Builder%20Perf/1747

Compilation Error:
[7938/39313] CXX obj/chrome/test/load_library_perf_tests/load_library_perf_test.o
FAILED: obj/chrome/test/load_library_perf_tests/load_library_perf_test.o 
/b/c/goma_cache/client/gomacc ../../third_party/llvm-build/Release+Asserts/bin/clang++...  -c ../../chrome/browser/load_library_perf_test.cc -o obj/chrome/test/load_library_perf_tests/load_library_perf_test.o
../../chrome/browser/load_library_perf_test.cc:81:7: error: use of undeclared identifier 'kWidevineCdmBaseDirectory'
      kWidevineCdmBaseDirectory,
      ^
../../chrome/browser/load_library_perf_test.cc:82:34: error: use of undeclared identifier 'kWidevineCdmLibraryName'
      base::GetNativeLibraryName(kWidevineCdmLibraryName));
                                 ^
2 errors generated.
 
Cc: simonhatch@chromium.org
Cc: xhw...@chromium.org
Labels: OS-Mac
Status: Fixed (was: Assigned)
This also affects perf waterfall on Mac, Linux, Windows.
https://ci.chromium.org/p/chrome/builders/luci.chrome.ci/linux-builder-perf/6019

Starting at this Widevine roll (from Friday night/Saturday morning):
https://chrome-internal.googlesource.com/chrome/src-internal/+/3e84386bf87e92289579f7dee131759e6eed267e

I've landed a revert.
https://chrome-internal-review.googlesource.com/c/chrome/src-internal/+/680351

It looks like there's a mismatch between Widevine upstream and load_library_perf_tests.cc, so it only affects the perf builders.

Sign in to add a comment