New issue
Advanced search Search tips

Issue 884687 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Oct 2
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 1
Type: Bug

Blocking:
issue 884675



Sign in to add a comment

Disable ZeroSuggest and URL-what-you-typed for omnibox shortcuts experiment.

Project Member Reported by stkhapugin@chromium.org, Sep 17

Issue description

Users running with the shortcuts experiment should not receive ZeroSuggest and zero-state UWYT suggestions. 
 
Project Member

Comment 1 by bugdroid1@chromium.org, Oct 2

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5b899dc705b86ca49b2d3dec447154c68b11e788

commit 5b899dc705b86ca49b2d3dec447154c68b11e788
Author: stkhapugin@chromium.org <stkhapugin@chromium.org>
Date: Tue Oct 02 09:20:01 2018

Disable ZeroSuggest provider for shortcuts experiment.

Moves the shortcuts experiment flag from iOS-only list to omnibox flags,
and disables ZeroSuggest provider when it's on.

Bug:  884687 
Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
Change-Id: Iaa709a78b0ae0a5862edec457ec0f2555e45dced
Reviewed-on: https://chromium-review.googlesource.com/1233454
Reviewed-by: Mark Pearson <mpearson@chromium.org>
Reviewed-by: Mark Cogan <marq@chromium.org>
Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595767}
[modify] https://crrev.com/5b899dc705b86ca49b2d3dec447154c68b11e788/components/omnibox/browser/omnibox_field_trial.cc
[modify] https://crrev.com/5b899dc705b86ca49b2d3dec447154c68b11e788/components/omnibox/browser/omnibox_field_trial.h
[modify] https://crrev.com/5b899dc705b86ca49b2d3dec447154c68b11e788/components/omnibox/browser/zero_suggest_provider.cc
[modify] https://crrev.com/5b899dc705b86ca49b2d3dec447154c68b11e788/ios/chrome/browser/about_flags.mm
[modify] https://crrev.com/5b899dc705b86ca49b2d3dec447154c68b11e788/ios/chrome/browser/ios_chrome_flag_descriptions.cc
[modify] https://crrev.com/5b899dc705b86ca49b2d3dec447154c68b11e788/ios/chrome/browser/ios_chrome_flag_descriptions.h
[modify] https://crrev.com/5b899dc705b86ca49b2d3dec447154c68b11e788/ios/chrome/browser/ui/ui_feature_flags.cc
[modify] https://crrev.com/5b899dc705b86ca49b2d3dec447154c68b11e788/ios/chrome/browser/ui/ui_feature_flags.h

Status: Fixed (was: Started)

Sign in to add a comment