New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 884677 link

Starred by 1 user

Issue metadata

Status: Duplicate
Merged: issue 775332
Owner:
Closed: Nov 3
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android , iOS
Pri: 2
Type: Task



Sign in to add a comment

Consider unifying ios's and android's ContextualSearchDelegate implementations

Project Member Reported by toniki...@chromium.org, Sep 17

Issue description

when migrating  ios/chrome/browser/ui/contextual_search/contextual_search_delegate.cc ( issue 879775 ) and chrome/browser/android/contextualsearch/contextual_search_delegate.cc ( issue 872875 ), it was noticed that the implementations could share code.

This bug is to track it.
 
Owner: marq@chromium.org
Status: Assigned (was: Untriaged)
Marq, you have worked on contextual search before. PTAL and see if still relevant.
If we decide to unify, it may be possible to move the implementation in to the Contextual Search component.  Most of the contextual Search code lives in the Android browser but we've been slowly working to move what can be shared into the component, and it should now have a layered architecture that's designed to be compatible with iOS.  Pointers to code locations here: https://sites.google.com/a/google.com/contextualsearch/engineering/code-location

Mergedinto: 775332
Status: Duplicate (was: Assigned)

Sign in to add a comment