New issue
Advanced search Search tips

Issue 884668 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Nov 13
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug-Regression


Participants' hotlists:
LoginRefresh


Sign in to add a comment

Regression : Unable to click on 'Learn more' link available at Error message in Lock Screen

Project Member Reported by mmanchala@chromium.org, Sep 17

Issue description

Chrome Version:  71.0.3552.6/11073.0.0 dev channel Daisy,Reks and Kip
OS: Chrome

What steps will reproduce the problem?
(1)Sign into User -> Now at Uber Tray -> click on 'Sign out' option
(2)In 'Sign out' screen -> enter wrong password  for 2 times -> Error message is seen ->now at second time try to click on 'Learn more' link available at  Error message and observe 'Help' overlay is not seen
(Please refer Video and Screenshot)

Expected: Should be able to click on 'Learn more' link and 'Help' overlay should be seen
Actual: Instead unable to click on 'Learn more' and observe 'Help' overlay is not seen

This is Regression Issue as same is working fine in 71.0.3544.0/11064.0.0 dev-channel Reks
 
Actual_HelpOverlay.mp4
10.1 MB View Download
Expected_HelpOverlay.mp4
10.1 MB View Download
Owner: qnnguyen@google.com
Status: Assigned (was: Untriaged)
I'm not sure of the issue here -- I see the same behavior in both videos?
C#2>>

1)In 'Sign out' screen -> enter wrong password  -> Error message is seen -> able to click on 'Learn more' link for first Wrong message 
2)Now again enter wrong password for 2nd time -> Error message is seen -> try to click on 'Learn more' link available at  Error message and observe 'Help' overlay is not seen
(Please refer Video and Screenshot)

Thanks..!!
<Bulk edit> Reminder M71 Stable is approaching. Please review this bug and assess if this is indeed a RBS. If not, please remove the RBS label. If so, please make sure any planned work will be tested in Beta and verified before the Stable date. Thanks
Owner: qnnguyen@chromium.org
Project Member

Comment 6 by bugdroid1@chromium.org, Nov 13

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/29fa932b58e2ef571a93c04291300e58a1ab1ec2

commit 29fa932b58e2ef571a93c04291300e58a1ab1ec2
Author: Quan Nguyen <qnnguyen@chromium.org>
Date: Tue Nov 13 22:33:57 2018

cros: Ensure login bubbles are clickable when overlapping with shelf and virtual keyboard

Bug:  884668 
Change-Id: I16dd2c5b0156bf1490b57acd4185c1d80d193a67
Reviewed-on: https://chromium-review.googlesource.com/c/1330206
Reviewed-by: Jacob Dufault <jdufault@chromium.org>
Commit-Queue: Quan Nguyen <qnnguyen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#607771}
[modify] https://crrev.com/29fa932b58e2ef571a93c04291300e58a1ab1ec2/ash/login/ui/login_base_bubble_view.cc
[modify] https://crrev.com/29fa932b58e2ef571a93c04291300e58a1ab1ec2/ash/login/ui/login_base_bubble_view.h
[modify] https://crrev.com/29fa932b58e2ef571a93c04291300e58a1ab1ec2/ash/login/ui/login_bubble.cc

Labels: Merge-Request-71
Status: Fixed (was: Assigned)
Project Member

Comment 8 by sheriffbot@chromium.org, Nov 14

Labels: -Merge-Request-71 Hotlist-Merge-Review Merge-Review-71
This bug requires manual review: M71 has already been promoted to the beta branch, so this requires manual review
Please contact the milestone owner if you have questions.
Owners: benmason@(Android), kariahda@(iOS), kbleicher@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: -Merge-Review-71 Merge-Approved-71
Merge Approved for ChromeOS M71
Project Member

Comment 10 by sheriffbot@chromium.org, Nov 19

Cc: geo...@google.com
This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible!

If all merges have been completed, please remove any remaining Merge-Approved labels from this issue.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 11 by sheriffbot@chromium.org, Nov 23

This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible!

If all merges have been completed, please remove any remaining Merge-Approved labels from this issue.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 12 by bugdroid1@chromium.org, Nov 27

Labels: -merge-approved-71 merge-merged-3578
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4e1b775a3fd52c834f5bfaa29570c84119225ad9

commit 4e1b775a3fd52c834f5bfaa29570c84119225ad9
Author: Quan Nguyen <qnnguyen@chromium.org>
Date: Tue Nov 27 17:26:05 2018

cros: Ensure login bubbles are clickable when overlapping with shelf and virtual keyboard

Bug:  884668 
Change-Id: I16dd2c5b0156bf1490b57acd4185c1d80d193a67
Reviewed-on: https://chromium-review.googlesource.com/c/1330206
Reviewed-by: Jacob Dufault <jdufault@chromium.org>
Commit-Queue: Quan Nguyen <qnnguyen@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#607771}(cherry picked from commit 29fa932b58e2ef571a93c04291300e58a1ab1ec2)
Reviewed-on: https://chromium-review.googlesource.com/c/1352054
Reviewed-by: Quan Nguyen <qnnguyen@chromium.org>
Cr-Commit-Position: refs/branch-heads/3578@{#823}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}
[modify] https://crrev.com/4e1b775a3fd52c834f5bfaa29570c84119225ad9/ash/login/ui/login_base_bubble_view.cc
[modify] https://crrev.com/4e1b775a3fd52c834f5bfaa29570c84119225ad9/ash/login/ui/login_base_bubble_view.h
[modify] https://crrev.com/4e1b775a3fd52c834f5bfaa29570c84119225ad9/ash/login/ui/login_bubble.cc

Labels: Merge-Merged-71-3578
The following revision refers to this bug: 
https://chromium.googlesource.com/chromium/src.git/+/4e1b775a3fd52c834f5bfaa29570c84119225ad9

Commit: 4e1b775a3fd52c834f5bfaa29570c84119225ad9
Author: qnnguyen@chromium.org
Commiter: qnnguyen@chromium.org
Date: 2018-11-27 17:26:05 +0000 UTC

cros: Ensure login bubbles are clickable when overlapping with shelf and virtual keyboard

Bug:  884668 
Change-Id: I16dd2c5b0156bf1490b57acd4185c1d80d193a67
Reviewed-on: https://chromium-review.googlesource.com/c/1330206
Reviewed-by: Jacob Dufault <jdufault@chromium.org>
Commit-Queue: Quan Nguyen <qnnguyen@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#607771}(cherry picked from commit 29fa932b58e2ef571a93c04291300e58a1ab1ec2)
Reviewed-on: https://chromium-review.googlesource.com/c/1352054
Reviewed-by: Quan Nguyen <qnnguyen@chromium.org>
Cr-Commit-Position: refs/branch-heads/3578@{#823}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}

Sign in to add a comment