Issue metadata
Sign in to add a comment
|
Regression : Keypad & Buttons are misplaced in 'Enter your PIN' overlay of chrome://settings/lockScreen page |
||||||||||||||||||||||
Issue descriptionChrome Version: 71.0.3552.6/11073.0.0 dev channel Daisy,Reks and Kip OS: Chrome What steps will reproduce the problem? (1)Sign into User -> Go to chrome://settings -> Now under 'People' section click on 'Screen lock' option (2)Now enter User Password in 'Confirm your password' dialog box -> At 'screen lock options' section select 'PIN or Password' option -> click on 'SET UP PIN' ->'Enter your PIN' overlay is seen -> observe PIN field and digits moved to LHS and 'Cancel' & 'Continue' buttons at RHS (Please refer Screenshot) Expected: Keypad & Buttons should be at center Actual: Instead Keypad & Buttons are misplaced This is Regression Issue as same is working fine in M-69
,
Oct 17
,
Oct 18
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/76e77ff0012c21a18f341a2b95627f456fd43433 commit 76e77ff0012c21a18f341a2b95627f456fd43433 Author: Alexander Alekseev <alemate@chromium.org> Date: Thu Oct 18 01:44:54 2018 Chrome OS: Update PIN setup element to new look. This Cl changes layout of PIN setup input/keyboard to match new specs. This changes behavior both in First Run and in Settings UI. Bug: 884667 ,890685 Change-Id: Ie0f94dfaa3ea22cdf99f478eb21ec1631de41bd5 Reviewed-on: https://chromium-review.googlesource.com/c/1286199 Reviewed-by: Michael Giuffrida <michaelpg@chromium.org> Reviewed-by: Jacob Dufault <jdufault@chromium.org> Reviewed-by: Wenzhao (Colin) Zang <wzang@chromium.org> Commit-Queue: Alexander Alekseev <alemate@chromium.org> Cr-Commit-Position: refs/heads/master@{#600632} [modify] https://crrev.com/76e77ff0012c21a18f341a2b95627f456fd43433/chrome/browser/resources/chromeos/login/discover/modules/discover_module_pin_setup.css [modify] https://crrev.com/76e77ff0012c21a18f341a2b95627f456fd43433/chrome/browser/resources/settings/people_page/setup_pin_dialog.html [modify] https://crrev.com/76e77ff0012c21a18f341a2b95627f456fd43433/ui/webui/resources/cr_components/chromeos/quick_unlock/pin_keyboard.html [modify] https://crrev.com/76e77ff0012c21a18f341a2b95627f456fd43433/ui/webui/resources/cr_components/chromeos/quick_unlock/setup_pin_keyboard.html
,
Oct 18
,
Oct 19
Your change meets the bar and is auto-approved for M71. Please go ahead and merge the CL to branch 3578 manually. Please contact milestone owner if you have questions. Owners: benmason@(Android), kariahda@(iOS), kbleicher@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Oct 22
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0e0359dafec64b21818e23f902f710b3bc29fce6 commit 0e0359dafec64b21818e23f902f710b3bc29fce6 Author: Alexander Alekseev <alemate@chromium.org> Date: Mon Oct 22 05:08:59 2018 Chrome OS: Update PIN setup element to new look. This Cl changes layout of PIN setup input/keyboard to match new specs. This changes behavior both in First Run and in Settings UI. TBR=alemate@chromium.org (cherry picked from commit 76e77ff0012c21a18f341a2b95627f456fd43433) Bug: 884667 ,890685 Change-Id: Ie0f94dfaa3ea22cdf99f478eb21ec1631de41bd5 Reviewed-on: https://chromium-review.googlesource.com/c/1286199 Reviewed-by: Michael Giuffrida <michaelpg@chromium.org> Reviewed-by: Jacob Dufault <jdufault@chromium.org> Reviewed-by: Wenzhao (Colin) Zang <wzang@chromium.org> Commit-Queue: Alexander Alekseev <alemate@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#600632} Reviewed-on: https://chromium-review.googlesource.com/c/1293182 Reviewed-by: Alexander Alekseev <alemate@chromium.org> Cr-Commit-Position: refs/branch-heads/3578@{#199} Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034} [modify] https://crrev.com/0e0359dafec64b21818e23f902f710b3bc29fce6/chrome/browser/resources/chromeos/login/discover/modules/discover_module_pin_setup.css [modify] https://crrev.com/0e0359dafec64b21818e23f902f710b3bc29fce6/chrome/browser/resources/settings/people_page/setup_pin_dialog.html [modify] https://crrev.com/0e0359dafec64b21818e23f902f710b3bc29fce6/ui/webui/resources/cr_components/chromeos/quick_unlock/pin_keyboard.html [modify] https://crrev.com/0e0359dafec64b21818e23f902f710b3bc29fce6/ui/webui/resources/cr_components/chromeos/quick_unlock/setup_pin_keyboard.html
,
Oct 23
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0e0359dafec64b21818e23f902f710b3bc29fce6 Commit: 0e0359dafec64b21818e23f902f710b3bc29fce6 Author: alemate@chromium.org Commiter: alemate@chromium.org Date: 2018-10-22 05:08:59 +0000 UTC Chrome OS: Update PIN setup element to new look. This Cl changes layout of PIN setup input/keyboard to match new specs. This changes behavior both in First Run and in Settings UI. TBR=alemate@chromium.org (cherry picked from commit 76e77ff0012c21a18f341a2b95627f456fd43433) Bug: 884667 ,890685 Change-Id: Ie0f94dfaa3ea22cdf99f478eb21ec1631de41bd5 Reviewed-on: https://chromium-review.googlesource.com/c/1286199 Reviewed-by: Michael Giuffrida <michaelpg@chromium.org> Reviewed-by: Jacob Dufault <jdufault@chromium.org> Reviewed-by: Wenzhao (Colin) Zang <wzang@chromium.org> Commit-Queue: Alexander Alekseev <alemate@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#600632} Reviewed-on: https://chromium-review.googlesource.com/c/1293182 Reviewed-by: Alexander Alekseev <alemate@chromium.org> Cr-Commit-Position: refs/branch-heads/3578@{#199} Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}
,
Oct 31
Issue 889318 has been merged into this issue. |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by sammiequon@chromium.org
, Sep 17Status: Assigned (was: Untriaged)