Issue metadata
Sign in to add a comment
|
Regression: Unnecessary thin white border is seen around ubertray menu |
||||||||||||||||||||||
Issue descriptionChrome Version:71.0.3552.6/11073.0.0 dev channel Daisy,Reks,Kip OS:Chrome OS What steps will reproduce the problem? (1)Sign-in to user>> Lock the screen and click on ubertray (2)Observe unnecessary thin white border is seen around ubertray menu and while continuously expanding and collapsing, the thin white boarder goes disappear and then appear. Actual: Unnecessary thin white border is seen around ubertray menu and while continuously expanding and collapsing, the thin white boarder goes disappear and then appear. Expected: If the thin white border is intended, then while expanding/collapsing it should stay than disappearing and appearing. This is a Regression issue as same is working fine in 71.0.3544.0/11061.0.0 dev NOTE: Issue is also seen in signed-out screen Attaching screencasts for reference...
,
Sep 21
Issue 885234 has been merged into this issue.
,
Sep 21
,
Sep 21
Bisected. https://crrev.com/c/1195342 is the regression CL. Reassigning to alancutter@ who is the author of the CL.
,
Sep 24
Looks like my code searching skills weren't 100% that day. Missed one use of NO_SHADOW. WIP CL screenshots.
,
Sep 25
Thanks for the report.
,
Sep 25
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8a4e530f4fe04c07b6dc6efa52cf273d735abe6f commit 8a4e530f4fe04c07b6dc6efa52cf273d735abe6f Author: Alan Cutter <alancutter@chromium.org> Date: Tue Sep 25 00:16:56 2018 Fix grey border around Chrome OS system tray bubble The BubbleBorder shadow setting NO_SHADOW was identical to BIG_SHADOW until https://chromium-review.googlesource.com/c/chromium/src/+/1195342. That CL attempted to update all existing uses of NO_SHADOW to BIG_SHADOW to avoid changing existing behaviour but it missed the usage in TrayBubbleView. This CL updates NO_SHADOW to BIG_SHADOW to revert an unintended change in behaviour. Current: https://bugs.chromium.org/p/chromium/issues/attachment?aid=359605&signed_aid=gEEyLLd-AdZImC9nKec-5A==&inline=1 After reverting https://chromium-review.googlesource.com/c/chromium/src/+/1195342: https://bugs.chromium.org/p/chromium/issues/attachment?aid=359606&signed_aid=iw3ONXWvygIGZHFz4GBIoQ==&inline=1 After this CL: https://bugs.chromium.org/p/chromium/issues/attachment?aid=359607&signed_aid=_oDSWBycRhw3Vs3_Tgp0Qg==&inline=1 Bug: 884653 Change-Id: Idd33394fbf92b7711705fd081889d0d964c5ba37 Reviewed-on: https://chromium-review.googlesource.com/1240216 Reviewed-by: Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Alan Cutter <alancutter@chromium.org> Cr-Commit-Position: refs/heads/master@{#593765} [modify] https://crrev.com/8a4e530f4fe04c07b6dc6efa52cf273d735abe6f/ash/system/tray/tray_bubble_view.cc
,
Oct 1
Issue 890485 has been merged into this issue. |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by tetsui@chromium.org
, Sep 18