New issue
Advanced search Search tips

Issue 884649 link

Starred by 4 users
Status: Fixed
Owner:
pbos@chromium.org
Closed: Dec 19
Cc:
ajha@chromium.org
yamaguchi@chromium.org
tetsui@chromium.org
alemate@chromium.org
wzang@chromium.org
osh...@chromium.org
manucornet@chromium.org
jdufault@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug-Regression


Show other hotlists

Hotlists containing this issue:
Launcher-Polish


Sign in to add a comment

Chopped blue focus on ubertray for Welcome screen

Project Member Reported by kebalaji@chromium.org, Sep 17 
Chrome Version:71.0.3552.6/11073.0.0 dev channel Daisy,Reks,Kip
OS:Chrome OS

What steps will reproduce the problem?
(1)Recover build>> In OOBE, tab until focus reaches ubertray and observe chopped blue focus is seen 

Actual: Chopped blue focus is seen on ubertray
Expected: No such issue should be seen

This is a Regression issue as same is working fine in 71.0.3544.0/11061.0.0 dev

NOTE: Issue is also seen in lock screen and signed-out screen

Attaching screencasts for reference...
ActualUTFocus.mp4
2.8 MB View Download
ExpectedUTFocus.mp4
2.4 MB View Download

Comment 1 by alemate@chromium.org, Sep 17

Cc: osh...@chromium.org

Comment 2 by tkent@chromium.org, Sep 18

Components: -Blink>HTML>Focus

Comment 3 by tetsui@chromium.org, Sep 18

Owner: tetsui@chromium.org
Status: Assigned (was: Untriaged)

Comment 4 by tetsui@chromium.org, Sep 28

Owner: manucornet@chromium.org

Comment 5 by manucornet@chromium.org, Oct 17

Summary: Chopped blue focus on ubertray for Welcome screen (was: Regression:Chopped blue focus is seen on ubertray )

Comment 6 by manucornet@chromium.org, Oct 17

Labels: -Pri-1 Pri-2
Visual polish, worth fixing as soon as possible, but I would say this is P2.

Comment 7 by manucornet@chromium.org, Oct 17

Components: UI>Shell>Shelf

Comment 8 by manucornet@chromium.org, Oct 18 

As an added bonus, this is what it looks like in the lock screen.
2018-10-18-113325_287x182_scrot.png
3.8 KB View Download

Comment 9 by newcomer@chromium.org, Oct 30

Labels: -M-71 M-72

Comment 10 by newcomer@chromium.org, Dec 3

Labels: -M-72 -m-72 M-73
Bulk moving <p-1's to the next milestone because we branched to M-73.

Comment 11 by manucornet@chromium.org, Dec 8

Labels: -ReleaseBlock-Stable

Comment 12 by manucornet@chromium.org, Dec 14

Cc: manucornet@chromium.org
 Issue 882402  has been merged into this issue.

Comment 13 by manucornet@chromium.org, Dec 19

Owner: pbos@chromium.org
Project Member

Comment 14 by bugdroid1@chromium.org, Dec 19 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/653ea1c9e8fdf662607cb715de9bc2cd0a247300

commit 653ea1c9e8fdf662607cb715de9bc2cd0a247300
Author: Peter Boström <pbos@chromium.org>
Date: Wed Dec 19 18:35:35 2018

Fix TrayBackgroundView FocusRing

Makes the focus ring match the RoundRect outline of the drawn button.

Bug:  chromium:884649 
Change-Id: I7f20f0131a86d6a8d419a6d5581407c86151c733
Reviewed-on: https://chromium-review.googlesource.com/c/1383496
Commit-Queue: Peter Boström <pbos@chromium.org>
Reviewed-by: Michael Wasserman <msw@chromium.org>
Reviewed-by: Tetsui Ohkubo <tetsui@chromium.org>
Cr-Commit-Position: refs/heads/master@{#617889}
[modify] https://crrev.com/653ea1c9e8fdf662607cb715de9bc2cd0a247300/ash/shelf/login_shelf_view.cc
[modify] https://crrev.com/653ea1c9e8fdf662607cb715de9bc2cd0a247300/ash/system/tray/tray_background_view.cc
[modify] https://crrev.com/653ea1c9e8fdf662607cb715de9bc2cd0a247300/ash/system/tray/tray_background_view.h
[modify] https://crrev.com/653ea1c9e8fdf662607cb715de9bc2cd0a247300/ui/views/controls/focus_ring.cc
[modify] https://crrev.com/653ea1c9e8fdf662607cb715de9bc2cd0a247300/ui/views/controls/focus_ring.h

Comment 15 by pbos@chromium.org, Dec 19

Status: Fixed (was: Assigned)

Comment 16 by pbos@chromium.org, Dec 19 

Please verify as I've only looked at this from the regular lock screen.
►

Sign in to add a comment