New issue
Advanced search Search tips

Issue 884648 link

Starred by 1 user
Status: Fixed
Owner:
vasi...@chromium.org
Closed: Sep 18
Cc:
nyerramilli@chromium.org
rbasuvula@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression:Password suggestion drop-down turns transparent on second click in 'New Password' field.

Reported by shruti.j...@etouch.net, Sep 17 
Chrome Version : 71.0.3554.0 (Official Build) Revision50b24262ba0c4e14c723112f9aad3686dc6462c1-refs/branch-heads/3554@{#1}(64-bit)
OS: Win(7,8,8.1,10) and Linux(14.04 LTS)

Pre-condition:
-Enable flag 'Automatic password generation' from chrome://flags
-Sign in to chrome with valid credentials 

Steps to reproduce:
1.Launch chrome and Navigate to facebook.com
2.Click on 'New Password' so that password generation auto-populate and select the password.
3.Click again in 'New Password' field.

Actual Result:Password suggestion drop-down turns transparent on second click in 'New Password' field.
Expected Result: Password suggestion drop-down should not turn transparent on second click in 'New Password' field.

This is a regression issue, broken in 'M-70' and will soon inform bisect info:
Good build: 70.0.3537.0(Revision: 587303)
Bad build : 70.0.3538.0(Revision: 587811)

Kindly refer the attached screen-cast.

Thank You.
Expected_Result.mp4
439 KB View Download
Actual_Result.mp4
488 KB View Download

Comment 1 by shruti.j...@etouch.net, Sep 17

Labels: hasbisect
Owner: vasi...@chromium.org
Status: Assigned (was: Unconfirmed)
Update:

Change Log:
https://chromium.googlesource.com/chromium/src/+log/70.0.3537.0..70.0.3538.0?pretty=fuller&n=10000

Suspect:https://chromium.googlesource.com/chromium/src/+/184d5957347e7c56567f8bad00590e36e741604d

@Vasilii Sukhanov: Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner.

Note:
1. Tried to perform 'per-revision' bisect but it shows "We don't have enough builds to bisect" error message (tried on different machines but still got the same error.)
2.In  'Chromium bisect' Sign-in chrome is not available.
3.Issue is not seen on Mac(10.12.6, 10.13.1, 10.14, 10.13.6).
4.Hence providing suspect Manually from Change Log
Project Member

Comment 2 by bugdroid1@chromium.org, Sep 17 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d8eaf1b863688da7ea4187094299667fc7c55845

commit d8eaf1b863688da7ea4187094299667fc7c55845
Author: Vasilii Sukhanov <vasilii@chromium.org>
Date: Mon Sep 17 16:07:49 2018

Fix the generation dropdown update.

The bug happened because we didn't call Layout().

Bug:  884648 
Change-Id: Iadd1d5b66de2b60103470eccff8862ad14d185a2
Reviewed-on: https://chromium-review.googlesource.com/1228195
Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org>
Commit-Queue: Dominic Battré <battre@chromium.org>
Reviewed-by: Dominic Battré <battre@chromium.org>
Cr-Commit-Position: refs/heads/master@{#591695}
[modify] https://crrev.com/d8eaf1b863688da7ea4187094299667fc7c55845/chrome/browser/ui/views/autofill/autofill_popup_base_view.cc

Comment 3 by vasi...@chromium.org, Sep 18

Labels: Merge-Request-70
I want to merge r591695 back.

Comment 4 by shruti.j...@etouch.net, Sep 18

Labels: TE-Verified-M71 TE-Verified-71.0.3555.0
Update : 
Retested above issue on  Win(7,8,8.1,10) and Linux(14.04 LTS) OS using latest Canary #71.0.3555.0 and issue is fixed.Now password generation drop-down is not seen transparent on second click.Kindly review the attached screen-cast.
Thank you
CanaryBehaviour#71.0.3555.0.mp4
478 KB View Download
Project Member

Comment 5 by sheriffbot@chromium.org, Sep 18

Labels: -Merge-Request-70 Merge-Review-70 Hotlist-Merge-Review
This bug requires manual review: M70 has already been promoted to the beta branch, so this requires manual review
Please contact the milestone owner if you have questions.
Owners: benmason@(Android), kariahda@(iOS), geohsu@(ChromeOS), abdulsyed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 6 by abdulsyed@chromium.org, Sep 18

Labels: -Merge-Review-70 Merge-Approved-70
Project Member

Comment 7 by bugdroid1@chromium.org, Sep 18

Labels: -merge-approved-70 merge-merged-3538
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b0e9e05d39e3d779bfd093aa99214760959d3dbf

commit b0e9e05d39e3d779bfd093aa99214760959d3dbf
Author: Vasilii Sukhanov <vasilii@chromium.org>
Date: Tue Sep 18 17:14:55 2018

Fix the generation dropdown update.

The bug happened because we didn't call Layout().

TBR=vasilii@chromium.org

(cherry picked from commit d8eaf1b863688da7ea4187094299667fc7c55845)

Bug:  884648 
Change-Id: Iadd1d5b66de2b60103470eccff8862ad14d185a2
Reviewed-on: https://chromium-review.googlesource.com/1228195
Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org>
Commit-Queue: Dominic Battré <battre@chromium.org>
Reviewed-by: Dominic Battré <battre@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#591695}
Reviewed-on: https://chromium-review.googlesource.com/1231194
Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Cr-Commit-Position: refs/branch-heads/3538@{#500}
Cr-Branched-From: 79f7c91a2b2a2932cd447fa6f865cb6662fa8fa6-refs/heads/master@{#587811}
[modify] https://crrev.com/b0e9e05d39e3d779bfd093aa99214760959d3dbf/chrome/browser/ui/views/autofill/autofill_popup_base_view.cc

Comment 8 by vasi...@chromium.org, Sep 18

Status: Fixed (was: Assigned)

Comment 9 by shruti.j...@etouch.net, Sep 26

Labels: TE-Verified-M70 TE-Verified-70.0.3538.35
Update : 
Retested above issue on  Win(7,8,8.1,10) and Linux(14.04 LTS) OS using beta #70.0.3538.35 and issue is fixed.Now password generation drop-down is not seen transparent on second click.Kindly review the attached screen-cast.
Thank you
Beta_Behaviour70.0.3538.35.mp4
372 KB View Download
►

Sign in to add a comment