Regression: [Print Preview] Unable to select radio buttons using Up/Down Arrow key input
Reported by
khushal....@etouch.net,
Sep 17
|
|||
Issue descriptionChrome Version: 71.0.3554.0 (Official Build) Revision 50b24262ba0c4e14c723112f9aad3686dc6462c1-refs/branch-heads/3554@{#1} (32/64-Bit) OS: Windows (7, 8, 8.1, 10), Mac (10.12.6, 10.13.1, 10.13.6, 10.14) and Linux (14.04 LTS) What steps will reproduce the problem? (1) Launch chrome, open NTP and press 'Ctrl+P' to open preview page. (2) Traverse the focus on "All" radio button of 'Pages' section. (3) Now try to select next radio button using Up/Down Arrow key input. (4) Observe. Actual Result: Unable to select radio buttons using Up/Down Arrow key input. Expected Result: Should be able to select radio buttons using Up/Down Arrow key input. This is a regression issue broken in ‘M-71’ and below is the 'Chromium bisect' information: Good Build: 71.0.3551.0 (Revision: 590851) Bad Build : 71.0.3552.2 (Revision: 591210) Chromium bisect URL: https://chromium.googlesource.com/chromium/src/+log/affcf0c8f45e22c2aed34257714da66182c0d015..a67666adf1d4f52f814c59f22bef20096fb565ee Suspect: r591109 ?? @rbpotter: Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner. NOTE: 1. Tried to perform 'per-revision' bisect but it shows "We don't have enough builds to bisect" error message (tried on different machines but still got the same error). 2. Hence providing suspect through 'Chromium bisect'. Kindly refer the attached screen-cast. Thank You..!!
,
Sep 26
,
Sep 28
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/311f9860ef228835607ad94d32504b71d58d58d3 commit 311f9860ef228835607ad94d32504b71d58d58d3 Author: rbpotter <rbpotter@chromium.org> Date: Fri Sep 28 03:46:13 2018 Print Preview Refresh: Add radio group Put radio buttons in a paper-radio-group. Also ensure that behavior stays the same. Specific behaviors that were tested: (1) Selecting "custom" radio button when "all" radio button was previously selected should automatically focus the custom input. However, focusing it if it was already selected does not have this effect. (2) Shifting focus from an empty custom input field, or from the "custom" radio button while it is selected and the input is empty, automatically reselects the "all" radio button, unless the focus is shifting to the custom radio button or input. (3) left/right arrow keys in the custom input move through the user's entered text and do not change to the "All" radio button. (4) Keep feature of radio group that the radio-button that is not selected is not in the tab order. However, if custom is selected, the custom input should be in the tab order as well as the custom radio button. (5) Behavior for which bug was filed - i.e. up/down arrow keys should work to change between the radio buttons. Bug: 884645 Change-Id: I88bb990db3a3c760892c65e704ac6ca877a15d96 Reviewed-on: https://chromium-review.googlesource.com/1248129 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#594974} [modify] https://crrev.com/311f9860ef228835607ad94d32504b71d58d58d3/chrome/browser/resources/print_preview/new/pages_settings.html [modify] https://crrev.com/311f9860ef228835607ad94d32504b71d58d58d3/chrome/browser/resources/print_preview/new/pages_settings.js [modify] https://crrev.com/311f9860ef228835607ad94d32504b71d58d58d3/chrome/test/data/webui/print_preview/pages_settings_test.js [modify] https://crrev.com/311f9860ef228835607ad94d32504b71d58d58d3/chrome/test/data/webui/print_preview/settings_section_test.js
,
Oct 4
|
|||
►
Sign in to add a comment |
|||
Comment 1 by nyerramilli@chromium.org
, Sep 17Labels: ReleaseBlock-Stable