New issue
Advanced search Search tips

Issue 884642 link

Starred by 1 user
Status: Fixed
Owner:
y...@chromium.org
Closed: Sep 17
Cc:
ajha@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

Non-Regression: 'Take photo' tooltip is seen for video recording button in camera app

Project Member Reported by rkalavakuntla@chromium.org, Sep 17 
Chrome Version:71.0.3552.6/11073.0.0 dev channel Daisy,Reks,Kip
OS:Chrome OS

Test URL: CCA 5.2-https://chrome.google.com/webstore/detail/camera/afoodkbadjkccjlgmeldfjefkfgpalan?hl=en-US

What steps will reproduce the problem?
(1)Install and open the above Camera app
(2)Switch to record video
(3)hover the mouse pointer on Record video button and observe the tooltip

Actual:'Take photo' tooltip is seen for video recording button
Expected:'Start Recording' tooltip should be seen for video recording button

Raising this as a Non-Regression issue as it is a new Camera app

Attached the screencast for reference..
Actual.jpg
4.2 MB View Download
Expected.jpg
1.9 MB View Download
Actual.mp4
8.3 MB View Download

Comment 1 by y...@chromium.org, Sep 17 

This issue is introduced from a recent commit:
https://chromium.googlesource.com/apps/camera/+/0704a43fed3f5790f0fb412d65b99cadb1f5279c
I'll fix it before release. Thanks for catching this.

Comment 2 by y...@chromium.org, Sep 17

Labels: -Pri-2 Pri-1
Project Member

Comment 3 by bugdroid1@chromium.org, Sep 17 

The following revision refers to this bug:
  https://chromium.googlesource.com/apps/camera/+/ec6d470b7d015b81c34fee0bb1d7debdb2ca44a4

commit ec6d470b7d015b81c34fee0bb1d7debdb2ca44a4
Author: Yuli Huang <yuli@chromium.org>
Date: Mon Sep 17 13:29:21 2018

Fix shutter label not updated for stream changes.

BUG= chromium:884642 
TEST=Tested by showing tooltips for stream/take-state changes.

Change-Id: I8355b5ae05b85629285d34f7b7eb78c383c7fdde
Reviewed-on: https://chromium-review.googlesource.com/1226956
Reviewed-by: Sheng-hao Tsao <shenghao@google.com>
Tested-by: yuli <yuli@chromium.org>

[modify] https://crrev.com/ec6d470b7d015b81c34fee0bb1d7debdb2ca44a4/src/js/views/camera.js

Comment 4 by y...@chromium.org, Sep 17

Status: Fixed (was: Assigned)
Project Member

Comment 5 by bugdroid1@chromium.org, Sep 17

Labels: merge-merged-version-5.2
The following revision refers to this bug:
  https://chromium.googlesource.com/apps/camera/+/60a4ac64304514fbab516c6bfd550d0c50c2977c

commit 60a4ac64304514fbab516c6bfd550d0c50c2977c
Author: Yuli Huang <yuli@chromium.org>
Date: Mon Sep 17 13:29:53 2018

Fix shutter label not updated for stream changes.

BUG= chromium:884642 
TEST=Tested by showing tooltips for stream/take-state changes.

Change-Id: I8355b5ae05b85629285d34f7b7eb78c383c7fdde
Reviewed-on: https://chromium-review.googlesource.com/1226956
Reviewed-by: Sheng-hao Tsao <shenghao@google.com>
Tested-by: yuli <yuli@chromium.org>
(cherry picked from commit 17dd90dd2f72ad31dfeacbcabc763697dab6937e)
Reviewed-on: https://chromium-review.googlesource.com/1226957
Reviewed-by: yuli <yuli@chromium.org>

[modify] https://crrev.com/60a4ac64304514fbab516c6bfd550d0c50c2977c/src/js/views/camera.js
Project Member

Comment 6 by bugdroid1@chromium.org, Jan 15 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ec6d470b7d015b81c34fee0bb1d7debdb2ca44a4

commit ec6d470b7d015b81c34fee0bb1d7debdb2ca44a4
Author: Yuli Huang <yuli@chromium.org>
Date: Mon Sep 17 13:29:21 2018

Fix shutter label not updated for stream changes.

BUG= chromium:884642 
TEST=Tested by showing tooltips for stream/take-state changes.

Change-Id: I8355b5ae05b85629285d34f7b7eb78c383c7fdde
Reviewed-on: https://chromium-review.googlesource.com/1226956
Reviewed-by: Sheng-hao Tsao <shenghao@google.com>
Tested-by: yuli <yuli@chromium.org>

[modify] https://crrev.com/ec6d470b7d015b81c34fee0bb1d7debdb2ca44a4/src/js/views/camera.js
►

Sign in to add a comment