New issue
Advanced search Search tips

Issue 884640 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Sep 21
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression: [Print Preview] 'Invalid page range' error message doesn't appear second times in 'Pages' text-box.

Reported by dchau...@etouch.net, Sep 17

Issue description

Chrome Version: 71.0.3554.0 (Official Build) Revision	50b24262ba0c4e14c723112f9aad3686dc6462c1-refs/branch-heads/3554@{#1} (32/64-bit)
OS: Windows(7,8,8.1,10), Mac(10.12.6, 10.13.1, 10.13.6, 10.14) and Linux(14.04 LTs).

What steps will reproduce the problem?
1. Launch Chrome and give print command on any webpage.
2. Type any keyword in 'Pages' text-box so that 'Invalid page range' error message appears.
3. Select 'All' radio button under pages section ('Invalid page range' error message will disappear).
3. Now again click in 'Pages' text-box and observe.

Actual: 'Invalid page range' error message doesn't appear.
Expected: 'Invalid page range' error message should appear.

This is a regression issue, broken in M-71 series, below is manual regression range.

Good build: 71.0.3551.0 (Revision: 590851)
Bad build: 71.0.3552.2 (Revision: 591210)

Using the 'per-revision' script providing the bisect result:

You are probably looking for a change made after 591108 (known good), but no later than 591109 (first known bad).
CHANGELOG URL:
The script might not always return single CL as suspect as some perf builds might get missing due to failure.
  https://chromium.googlesource.com/chromium/src/+log/974aa7b559b4361d7410479796becb0b933dc6a4..e73e92b7fbf4206ffdb20282ac73bcbed7cf910e

Suspecting: https://chromium.googlesource.com/chromium/src/+/e73e92b7fbf4206ffdb20282ac73bcbed7cf910e

@rbpotter: Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner.

Kindly review the attached screen-cast for reference.

Thank you.
 
Actual behavior.mp4
799 KB View Download
Expected behavior.mp4
494 KB View Download
Project Member

Comment 1 by bugdroid1@chromium.org, Sep 20

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e6113ed7a9644d287e512d78a17a08be0c7e2818

commit e6113ed7a9644d287e512d78a17a08be0c7e2818
Author: rbpotter <rbpotter@chromium.org>
Date: Thu Sep 20 00:33:35 2018

Print Preview Refresh: Fix error handling

(1) Make errors expand/contract rather than pre-allocating space
(2) Adjust padding so that padding is always 16px regardless of error
state
(3) Fix an issue with pages error not appearing when radio button is
reselected
(4) Make error line-height correct.
(5) Other changes to ensure labels stay correctly aligned with
controls regardless of control height.
(6) No hand pointer on error text.

Bug:  884752 ,  884729 ,  884603 ,  884640 ,  885039 
Change-Id: I9ff4e0bbc536b0890687b678cf52640c01e5a2ef
Reviewed-on: https://chromium-review.googlesource.com/1229618
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Reviewed-by: Scott Chen <scottchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#592629}
[modify] https://crrev.com/e6113ed7a9644d287e512d78a17a08be0c7e2818/chrome/browser/resources/print_preview/new/copies_settings.html
[modify] https://crrev.com/e6113ed7a9644d287e512d78a17a08be0c7e2818/chrome/browser/resources/print_preview/new/number_settings_section.html
[modify] https://crrev.com/e6113ed7a9644d287e512d78a17a08be0c7e2818/chrome/browser/resources/print_preview/new/number_settings_section.js
[modify] https://crrev.com/e6113ed7a9644d287e512d78a17a08be0c7e2818/chrome/browser/resources/print_preview/new/pages_settings.html
[modify] https://crrev.com/e6113ed7a9644d287e512d78a17a08be0c7e2818/chrome/browser/resources/print_preview/new/pages_settings.js
[modify] https://crrev.com/e6113ed7a9644d287e512d78a17a08be0c7e2818/chrome/browser/resources/print_preview/new/print_preview_shared_css.html
[modify] https://crrev.com/e6113ed7a9644d287e512d78a17a08be0c7e2818/chrome/browser/resources/print_preview/new/scaling_settings.html
[modify] https://crrev.com/e6113ed7a9644d287e512d78a17a08be0c7e2818/chrome/browser/resources/print_preview/new/scaling_settings.js
[modify] https://crrev.com/e6113ed7a9644d287e512d78a17a08be0c7e2818/chrome/test/data/webui/print_preview/new_print_preview_ui_browsertest.js
[modify] https://crrev.com/e6113ed7a9644d287e512d78a17a08be0c7e2818/chrome/test/data/webui/print_preview/pages_settings_test.js
[modify] https://crrev.com/e6113ed7a9644d287e512d78a17a08be0c7e2818/chrome/test/data/webui/print_preview/print_preview_interactive_ui_tests.js
[modify] https://crrev.com/e6113ed7a9644d287e512d78a17a08be0c7e2818/chrome/test/data/webui/print_preview/settings_section_test.js
[modify] https://crrev.com/e6113ed7a9644d287e512d78a17a08be0c7e2818/chrome/test/data/webui/print_preview/system_dialog_browsertest.js
[modify] https://crrev.com/e6113ed7a9644d287e512d78a17a08be0c7e2818/testing/buildbot/filters/webui_polymer2_browser_tests.filter
[modify] https://crrev.com/e6113ed7a9644d287e512d78a17a08be0c7e2818/testing/buildbot/filters/webui_polymer2_interactive_ui_tests.filter
[modify] https://crrev.com/e6113ed7a9644d287e512d78a17a08be0c7e2818/ui/webui/resources/cr_elements/cr_input/cr_input.html
[modify] https://crrev.com/e6113ed7a9644d287e512d78a17a08be0c7e2818/ui/webui/resources/cr_elements/shared_vars_css.html

Status: Fixed (was: Assigned)

Sign in to add a comment