[Print preview]Unnecessary grey focus highlight is seen on 'Paper icon' button even when it is in disabled state.
Reported by
rp...@etouch.net,
Sep 17
|
||||
Issue descriptionChrome version: 71.0.3554.0 (Official Build)Revision 50b24262ba0c4e14c723112f9aad3686dc6462c1-refs/branch-heads/3554@{#1}(32/64-bit) OS: Windows (7,8,8.1,10),Linux (14.04 LTS),Mac OS X(10.12.6,10.13.1,10.13.6,10.14) What steps will reproduce the problem? 1. Launch chrome,navigate to NTP and press 'Ctrl + P' to open print preview 2. Now type any invalid text under 'Pages' text field so that all options get disabled 3. Now press 'Tab' key and observe Actual: Unnecessary grey focus highlight is seen on 'Paper icon' button even when it is in disabled state Expected: Grey focus highlight should not be seen on 'Paper icon' button when it is in disabled state This is a Non-regression issue seen from M-71 series as 'Paper icon' button is introduced from build #71.0.3552.2 Kindly review the attached screen-cast for reference. Note : In Mac OS Print using system dialog gets open after pressing space bar key even when it is in disabled state. Thank you.
,
Sep 17
,
Sep 19
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/81dad65fc78501a5355fb175fb291173d5a0b3b1 commit 81dad65fc78501a5355fb175fb291173d5a0b3b1 Author: rbpotter <rbpotter@chromium.org> Date: Wed Sep 19 23:31:28 2018 Print Preview refresh: Fix more settings styling Bug: 884739 , 884632 , 885043 Change-Id: I59303415e30a288c8adc2799a06500f33e60ddee Reviewed-on: https://chromium-review.googlesource.com/1231253 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#592606} [modify] https://crrev.com/81dad65fc78501a5355fb175fb291173d5a0b3b1/chrome/browser/resources/print_preview/new/BUILD.gn [modify] https://crrev.com/81dad65fc78501a5355fb175fb291173d5a0b3b1/chrome/browser/resources/print_preview/new/more_settings.html [modify] https://crrev.com/81dad65fc78501a5355fb175fb291173d5a0b3b1/chrome/browser/resources/print_preview/new/more_settings.js
,
Sep 20
Update : Rechecked the above issue on Windows (7,8,8.1,10),Linux (14.04 LTS),Mac OS X(10.12.6,10.13.1,10.13.6,10.14) using latest Canary build : 71.0.3557.0 and the issue is Fixed.Hence adding TE Verified Labels. Kindly refer the attached screen cast. Thank you..!!
,
Sep 20
|
||||
►
Sign in to add a comment |
||||
Comment 1 by rbasuvula@chromium.org
, Sep 17