cros factory: image_tool RMA shim improvement |
||
Issue description`image-tool rma-merge` can merge multiple RMA shims into a universal shim, but it can only merge shims with a single board, and cannot resolve duplicate boards. Proposal: 1. Let `rma-merge` can merge universal shims. 2. Resolve duplicate boards by asking user to decide which version to use. Using 1. and 2. we can also update a universal shim by creating a new shim and merge with original shim to override the contents.
,
Nov 5
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform/factory/+/b360be95caabbb8b740bafabc818fb75e9f2f09a commit b360be95caabbb8b740bafabc818fb75e9f2f09a Author: Cheng-Han Yang <chenghan@google.com> Date: Mon Nov 05 12:55:02 2018 image_tool: Support merging RMA shim with multiple boards. Previously `image_tool rma-merge` can only merge RMA shims with single board. Add support for RMA shims with multiple boards. BUG=chromium:884617 TEST=make test; manually test on DUT Change-Id: I223b5eb2a790b4d2d345dd37638b2cb8485473d0 Reviewed-on: https://chromium-review.googlesource.com/1226772 Commit-Ready: Cheng-Han Yang <chenghan@chromium.org> Tested-by: Cheng-Han Yang <chenghan@chromium.org> Reviewed-by: Hung-Te Lin <hungte@chromium.org> Reviewed-by: Wei-Han Chen <stimim@chromium.org> [modify] https://crrev.com/b360be95caabbb8b740bafabc818fb75e9f2f09a/py/tools/image_tool.py [modify] https://crrev.com/b360be95caabbb8b740bafabc818fb75e9f2f09a/py/tools/image_tool_unittest.py [add] https://crrev.com/b360be95caabbb8b740bafabc818fb75e9f2f09a/py/tools/image_tool_rma_unittest.py
,
Nov 27
,
Jan 14
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform/factory/+/fae1445681481bca87a26a712f5af75a3a7b0640 commit fae1445681481bca87a26a712f5af75a3a7b0640 Author: Cheng-Han Yang <chenghan@google.com> Date: Mon Jan 14 21:15:58 2019 image_tool: Refactor rma-show implementation. Extract resource versions to a class that can be used in other functions. BUG=chromium:884617 TEST=`image_tool rma-show <universal_shim>` Change-Id: I1ef8046b213661a972728f05005ae20ce7dc4624 Reviewed-on: https://chromium-review.googlesource.com/1229815 Commit-Ready: Cheng-Han Yang <chenghan@chromium.org> Tested-by: Cheng-Han Yang <chenghan@chromium.org> Reviewed-by: Yong Hong <yhong@google.com> Reviewed-by: Wei-Han Chen <stimim@chromium.org> [modify] https://crrev.com/fae1445681481bca87a26a712f5af75a3a7b0640/py/tools/image_tool.py |
||
►
Sign in to add a comment |
||
Comment 1 by marcochen@chromium.org
, Nov 5