New issue
Advanced search Search tips

Issue 884605 link

Starred by 1 user
Status: Fixed
Owner:
rbpotter@chromium.org
Closed: Sep 20
Cc:
nyerramilli@chromium.org
rbasuvula@chromium.org
namratakannan@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression : (Ctrl + Shift + P) shortcut text is not seen besides 'Print using system dialog...' text in print preview.

Reported by rp...@etouch.net, Sep 17 
Chrome Version: 71.0.3553.0 (Official Build)Revision 5563d93688f01b13ddf785824fe2d9aefb23437a-refs/branch-heads/3553@{#1}(32/64-bit)
OS: Windows(7,8,8.1,10),Mac(10.12.6 , 10.13.1 , 10.13.6, 10.14) and Linux(14.04 LTS)

What steps will reproduce the problem?
1. Launch chrome, navigate to NTP and press 'Ctrl + p' to open print preview
2. Now observe 'Print using system dialog...'

Actual Result: (Ctrl + Shift + P) shortcut text is not seen besides 'Print using system dialog...' text in print preview
Expected Result: (Ctrl + Shift + P) shortcut text should be seen besides 'Print using system dialog...' text in print preview

This is regression issue broken in ‘M-71’ and will soon update other info:
Good build: 71.0.3551.0 (Revision: 590851)
Bad build : 71.0.3552.2 (Revision: 591210)
Actual_video.mp4
232 KB View Download
Expected_video.mp4
191 KB View Download

Comment 1 by rp...@etouch.net, Sep 17

Labels: hasbisect
Owner: rbpotter@chromium.org
Status: Assigned (was: Unconfirmed)
You are probably looking for a change made after 591100 (known good), but no later than 591109 (first known bad).

Chromium bisect URL : 
https://chromium.googlesource.com/chromium/src/+log/33a7b8f5e6947a8c2ecf13f7e353ee0bad0a5e3c..e73e92b7fbf4206ffdb20282ac73bcbed7cf910e?pretty=fuller&n=50

Suspect : r591109 ?

rbpotter@ : Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner.

Note : 
1. Tried to perform 'per-revision' bisect but it shows "We don't have enough builds to bisect" error message (tried on different machines but still got the same error.)
2. Hence providing suspect through 'Chromium bisect'.
3. Issue is also seen on latest Canary chrome version 71.0.3554.0

Comment 2 by rbpotter@chromium.org, Sep 17

Cc: namratakannan@chromium.org
Working as intended per the spec for new print preview. namratakannan@ to confirm.

Comment 3 by namratakannan@chromium.org, Sep 17 

This is a mock bug. The shortcut should also be shown. See remaining mocks:
https://docs.google.com/presentation/d/1YqtarcMLWw_w2AvBq0DQ45UDyxfvbWsCsUF3vjmrMc4/edit#slide=id.g3f9ef46797_0_1
Project Member

Comment 4 by bugdroid1@chromium.org, Sep 19 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/740492f9aba228edd794d7bd9d148d0929895a54

commit 740492f9aba228edd794d7bd9d148d0929895a54
Author: rbpotter <rbpotter@chromium.org>
Date: Wed Sep 19 23:55:35 2018

Print Preview refresh: Fix some issues with the link container

Fixes some padding and focus issues in and around the link-container.
(1) Correct padding above and below link-container
(2) Make icon focusable rather than the entire row
(3) Restore shortcut in system dialog string
(4) Make icon not focusable when disabled
(5) Correct padding in other-options-settings

Bug:  884729 ,  885102 ,  884605 
Change-Id: I0c8e1ac700ef93a4c6e247329d66285386af9f9f
Reviewed-on: https://chromium-review.googlesource.com/1231826
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#592614}
[modify] https://crrev.com/740492f9aba228edd794d7bd9d148d0929895a54/chrome/app/printing_strings.grdp
[modify] https://crrev.com/740492f9aba228edd794d7bd9d148d0929895a54/chrome/browser/resources/print_preview/new/advanced_options_settings.html
[modify] https://crrev.com/740492f9aba228edd794d7bd9d148d0929895a54/chrome/browser/resources/print_preview/new/app.html
[modify] https://crrev.com/740492f9aba228edd794d7bd9d148d0929895a54/chrome/browser/resources/print_preview/new/link_container.html
[modify] https://crrev.com/740492f9aba228edd794d7bd9d148d0929895a54/chrome/browser/resources/print_preview/new/link_container.js
[modify] https://crrev.com/740492f9aba228edd794d7bd9d148d0929895a54/chrome/browser/resources/print_preview/new/other_options_settings.html
[modify] https://crrev.com/740492f9aba228edd794d7bd9d148d0929895a54/chrome/browser/resources/print_preview/new/other_options_settings.js
[modify] https://crrev.com/740492f9aba228edd794d7bd9d148d0929895a54/chrome/browser/ui/webui/print_preview/print_preview_ui.cc
[modify] https://crrev.com/740492f9aba228edd794d7bd9d148d0929895a54/chrome/test/data/webui/print_preview/system_dialog_browsertest.js

Comment 5 by rbpotter@chromium.org, Sep 20

Status: Fixed (was: Assigned)
►

Sign in to add a comment