New issue
Advanced search Search tips

Issue 884603 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Sep 28
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression: [Print Preview] Unwanted hand pointer is seen on error message under 'Pages' section.

Reported by db...@etouch.net, Sep 17

Issue description

Chrome Version: 71.0.3553.2 Revision 82016d8666ab8da0265bddca3735c93790ac38c4-refs/branch-heads/3553@{#4}(32/64 bit)
OS: Windows(7,8,8.1,10), Mac(10.12.6, 10.13.1, 10.13.6, 10.14) and Linux(14.04 LTs).
     
What steps will reproduce the problem?
(1) Launch chrome, open NTP and press Ctrl+P to open preview page.
(2) Type in text box under 'Pages' section (error msg appeared)
(3) Hover mouse on error msg and observe.


Actual: Unwanted hand pointer is seen on error msg.

Expected: Hand pointer should not seen on error msg.

This is a regression issue, broken in 'M71', will soon update the other info:

Good Build:71.0.3552.2
Bad Build: 71.0.3553.2
 
Actual_Pointer.mov
9.1 MB View Download
Expected_Pointer.mov
2.3 MB View Download
Labels: hasbisect
Owner: rbpotter@chromium.org
Status: Assigned (was: Unconfirmed)
Summary: Regression: [Print Preview] Unwanted hand pointer is seen on error message under 'Pages' section. (was: Regression: [Print Preview] Unwanted hand pointer is seen on error msg under Pages section.)
Correction in manual bisect range:

Good build: 71.0.3551.0 (Revision: 590851)
Bad build : 71.0.3552.2 (Revision: 591210)

You are probably looking for a change made after 591100 (known good), but no later than 591109 (first known bad).

Chromium bisect URL : 
https://chromium.googlesource.com/chromium/src/+log/33a7b8f5e6947a8c2ecf13f7e353ee0bad0a5e3c..e73e92b7fbf4206ffdb20282ac73bcbed7cf910e?pretty=fuller&n=50

Suspect : r591109 ?

rbpotter@ : Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner.

Note : 
1. Tried to perform 'per-revision' bisect but it shows "We don't have enough builds to bisect" error message (tried on different machines but still got the same error.)
2. Hence providing suspect through 'Chromium bisect'.
3. Issue is also seen on latest Canary chrome version 71.0.3554.0


Project Member

Comment 2 by bugdroid1@chromium.org, Sep 20

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e6113ed7a9644d287e512d78a17a08be0c7e2818

commit e6113ed7a9644d287e512d78a17a08be0c7e2818
Author: rbpotter <rbpotter@chromium.org>
Date: Thu Sep 20 00:33:35 2018

Print Preview Refresh: Fix error handling

(1) Make errors expand/contract rather than pre-allocating space
(2) Adjust padding so that padding is always 16px regardless of error
state
(3) Fix an issue with pages error not appearing when radio button is
reselected
(4) Make error line-height correct.
(5) Other changes to ensure labels stay correctly aligned with
controls regardless of control height.
(6) No hand pointer on error text.

Bug:  884752 ,  884729 ,  884603 ,  884640 ,  885039 
Change-Id: I9ff4e0bbc536b0890687b678cf52640c01e5a2ef
Reviewed-on: https://chromium-review.googlesource.com/1229618
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Reviewed-by: Scott Chen <scottchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#592629}
[modify] https://crrev.com/e6113ed7a9644d287e512d78a17a08be0c7e2818/chrome/browser/resources/print_preview/new/copies_settings.html
[modify] https://crrev.com/e6113ed7a9644d287e512d78a17a08be0c7e2818/chrome/browser/resources/print_preview/new/number_settings_section.html
[modify] https://crrev.com/e6113ed7a9644d287e512d78a17a08be0c7e2818/chrome/browser/resources/print_preview/new/number_settings_section.js
[modify] https://crrev.com/e6113ed7a9644d287e512d78a17a08be0c7e2818/chrome/browser/resources/print_preview/new/pages_settings.html
[modify] https://crrev.com/e6113ed7a9644d287e512d78a17a08be0c7e2818/chrome/browser/resources/print_preview/new/pages_settings.js
[modify] https://crrev.com/e6113ed7a9644d287e512d78a17a08be0c7e2818/chrome/browser/resources/print_preview/new/print_preview_shared_css.html
[modify] https://crrev.com/e6113ed7a9644d287e512d78a17a08be0c7e2818/chrome/browser/resources/print_preview/new/scaling_settings.html
[modify] https://crrev.com/e6113ed7a9644d287e512d78a17a08be0c7e2818/chrome/browser/resources/print_preview/new/scaling_settings.js
[modify] https://crrev.com/e6113ed7a9644d287e512d78a17a08be0c7e2818/chrome/test/data/webui/print_preview/new_print_preview_ui_browsertest.js
[modify] https://crrev.com/e6113ed7a9644d287e512d78a17a08be0c7e2818/chrome/test/data/webui/print_preview/pages_settings_test.js
[modify] https://crrev.com/e6113ed7a9644d287e512d78a17a08be0c7e2818/chrome/test/data/webui/print_preview/print_preview_interactive_ui_tests.js
[modify] https://crrev.com/e6113ed7a9644d287e512d78a17a08be0c7e2818/chrome/test/data/webui/print_preview/settings_section_test.js
[modify] https://crrev.com/e6113ed7a9644d287e512d78a17a08be0c7e2818/chrome/test/data/webui/print_preview/system_dialog_browsertest.js
[modify] https://crrev.com/e6113ed7a9644d287e512d78a17a08be0c7e2818/testing/buildbot/filters/webui_polymer2_browser_tests.filter
[modify] https://crrev.com/e6113ed7a9644d287e512d78a17a08be0c7e2818/testing/buildbot/filters/webui_polymer2_interactive_ui_tests.filter
[modify] https://crrev.com/e6113ed7a9644d287e512d78a17a08be0c7e2818/ui/webui/resources/cr_elements/cr_input/cr_input.html
[modify] https://crrev.com/e6113ed7a9644d287e512d78a17a08be0c7e2818/ui/webui/resources/cr_elements/shared_vars_css.html

Project Member

Comment 3 by bugdroid1@chromium.org, Sep 25

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4970413d8808b5a5ecc191127bdc9e736d2f8229

commit 4970413d8808b5a5ecc191127bdc9e736d2f8229
Author: rbpotter <rbpotter@chromium.org>
Date: Tue Sep 25 18:20:34 2018

Print Preview Refresh: Fix some pages and link container polish bugs

- Make cr-input full height of radio button so there is no border
area where the hand pointer appears.
- Ignore pointer events on link container when disabled.
- Fix bug where "----" was considered valid input in pages.

Bug:  884603 ,  887823 ,  888493 
Change-Id: Ie9b7f2c42b12d7e2a7026f405b1a61b774578589
Reviewed-on: https://chromium-review.googlesource.com/1242037
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#594013}
[modify] https://crrev.com/4970413d8808b5a5ecc191127bdc9e736d2f8229/chrome/browser/resources/print_preview/new/link_container.html
[modify] https://crrev.com/4970413d8808b5a5ecc191127bdc9e736d2f8229/chrome/browser/resources/print_preview/new/pages_settings.html
[modify] https://crrev.com/4970413d8808b5a5ecc191127bdc9e736d2f8229/chrome/browser/resources/print_preview/new/pages_settings.js
[modify] https://crrev.com/4970413d8808b5a5ecc191127bdc9e736d2f8229/chrome/test/data/webui/print_preview/pages_settings_test.js

Labels: Needs-Feedback
Can't reproduce on current Canary (71.0.3563.0). Is this still an issue, or was it fixed by one of the CLs above?
Labels: -Needs-Feedback
With respect to comment 4:

Above issue is seems to be fixed on latest canary build #71.0.3564.0.

Kindly check attached screen cast for the same.

Thank you.
Issue_Fix.mov
4.0 MB View Download
Status: Verified (was: Assigned)
Thanks for confirming.

Sign in to add a comment