New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 884602 link

Starred by 1 user
Status: Fixed
Owner:
chengong@chromium.org
Closed: Sep 21
Cc:
omrilio@chromium.org
█ blakeo@chromium.org
yhanada@chromium.org
pcovell@chromium.org
█ dvallet@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug

Blocking:
issue 884578



Sign in to add a comment

Space key is not highlighted correctly when double click

Project Member Reported by iloahz@chromium.org, Sep 17 
Chrome Version: 70
OS: ChromeOS

What steps will reproduce the problem?
(1) Fast double click on space.
(2) Observe it's highlight.
(3)

What is the expected result?
Highlight 2 times when pressed each time.

What happens instead?
Only highlighted 1 time.

Comment 1 by chengong@chromium.org, Sep 17

Status: Started (was: Assigned)

Comment 2 by chengong@chromium.org, Sep 17 

DoubleTapRecognizer only checks double tap on touch up, it is too late to highlight the pressed key.
It should check double tap on touch down, highlight the key while it's depressed, and fire the key action on touch up.

Comment 3 by chengong@chromium.org, Sep 21

Blocking: 884578
Status: Fixed (was: Started)
Project Member

Comment 4 by bugdroid1@chromium.org, Sep 21 

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chromeos/overlays/chromeos-overlay/+/2971e337d113fc1c67583fdfa61561dd6ca4b8f6

commit 2971e337d113fc1c67583fdfa61561dd6ca4b8f6
Author: Chen Gong <chengong@google.com>
Date: Fri Sep 21 17:11:35 2018
►

Sign in to add a comment