New issue
Advanced search Search tips

Issue 884600 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Sep 24
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression: Focus ring on 'Manage' button is overlapped with text in Print preview.

Reported by db...@etouch.net, Sep 17

Issue description

Chrome Version: 71.0.3553.2 Revision 82016d8666ab8da0265bddca3735c93790ac38c4-refs/branch-heads/3553@{#4}(64 bit)
OS: Mac (10.12.6, 10.13.1, 10.13.6, 10.14)
     
What steps will reproduce the problem?
(1) Launch chrome, open NTP and press Ctrl+P to open preview page.
(2) Click on 'Change' button under 'Destination' then press Tab key upto focus reaches to 'Managae'
(3) Observe focus ring.


Actual: Focus ring on 'Managae' button is overlapped with text.

Expected: No such overlapping should seen.

This is a regression issue, broken in 'M71', will soon update the other info:

Good Build:71.0.3552.2
Bad Build: 71.0.3553.2
 
Actual_FocusRing.mov
3.3 MB View Download
Expected_FocusRing.mov
2.2 MB View Download
Labels: RegressedIn-71 hasbisect
Owner: rbpotter@chromium.org
Status: Assigned (was: Unconfirmed)
Summary: Regression: Focus ring on 'Manage' button is overlapped with text in Print preview. (was: Regression: Focus ring on 'Managae' button is overlapped with text in Print preview.)
Correction in manual bisect range:

Good build: 71.0.3551.0 (Revision: 590851)
Bad build : 71.0.3552.2 (Revision: 591210)

You are probably looking for a change made after 591100 (known good), but no later than 591109 (first known bad).

Chromium bisect URL : 
https://chromium.googlesource.com/chromium/src/+log/33a7b8f5e6947a8c2ecf13f7e353ee0bad0a5e3c..e73e92b7fbf4206ffdb20282ac73bcbed7cf910e?pretty=fuller&n=50

Suspect : r591109 ?

rbpotter@ : Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner.

Note : 
1.Issue is not seen on Windows(7,8,8.1,10) and Linux(14.04 LTS)
2. Tried to perform 'per-revision' bisect but it shows "We don't have enough builds to bisect" error message (tried on different machines but still got the same error.)
3. Hence providing suspect through 'Chromium bisect'.
4. Issue is also seen on latest Canary chrome version 71.0.3554.0

Project Member

Comment 2 by bugdroid1@chromium.org, Sep 21

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a12770d1657f8823f5e867bd3e60e8d2c05065b6

commit a12770d1657f8823f5e867bd3e60e8d2c05065b6
Author: rbpotter <rbpotter@chromium.org>
Date: Fri Sep 21 16:07:04 2018

Print Preview Refresh: Fix destinations polish bugs

Fixing:
(1) Action links fell out of the tab order because destinations_dialog
and destinations_list were not correctly importing action_link.html
(2) Absolute positioning of icon to set it on top of the cr-input in
print_preview_search_box led to icon getting misplaced when browser
window size changed. Fix by adding a prefix in cr-input.
(3) Destination icon was shrinking for large font sizes due to using
flex layout. Make icon fixed size (20px, per spec).
(4) Ensure there is enough margin on the "Manage" link to show the
focus outline.

Bug:  884600 ,  885090 ,  886593 ,  887227 ,  887229 
Change-Id: Ic7d910ad1460e8d457186b9c189797f12db4de5f
Reviewed-on: https://chromium-review.googlesource.com/1237137
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Reviewed-by: Scott Chen <scottchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#593205}
[modify] https://crrev.com/a12770d1657f8823f5e867bd3e60e8d2c05065b6/chrome/browser/resources/print_preview/new/destination_dialog.html
[modify] https://crrev.com/a12770d1657f8823f5e867bd3e60e8d2c05065b6/chrome/browser/resources/print_preview/new/destination_list.html
[modify] https://crrev.com/a12770d1657f8823f5e867bd3e60e8d2c05065b6/chrome/browser/resources/print_preview/new/destination_settings.html
[modify] https://crrev.com/a12770d1657f8823f5e867bd3e60e8d2c05065b6/chrome/browser/resources/print_preview/new/print_preview_search_box.html
[modify] https://crrev.com/a12770d1657f8823f5e867bd3e60e8d2c05065b6/ui/webui/resources/cr_elements/cr_input/cr_input.html

Update:

Rechecked the above issue on  Mac(10.12.6 , 10.13.1 , 10.13.6 , 10.14) OS using latest canary build#71.0.3559.0 and issue is fixed.

Kindly refer attached screen cast.

Thank You..

Fix_Issue.mov
3.3 MB View Download
Labels: TE-Verified-M71 TE-Verified-71.0.3559.0
Status: Verified (was: Assigned)

Sign in to add a comment